azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Checking that no quickfix reference KotlinType

Browse Source
This commit is contained in:
Valentin Kipyatkov
2016-03-29 21:46:54 +03:00
parent 2ac627efd3
commit 99c232df84
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
idea/idea-analysis/src/org/jetbrains/kotlin/idea/highlighter/KotlinPsiChecker.kt
+10 -2
View File
@@ -48,6 +48,7 @@ import org.jetbrains.kotlin.idea.util.ProjectRootsUtil
import org.jetbrains.kotlin.psi.* import org.jetbrains.kotlin.psi.*
import org.jetbrains.kotlin.resolve.BindingContext import org.jetbrains.kotlin.resolve.BindingContext
import org.jetbrains.kotlin.resolve.diagnostics.Diagnostics import org.jetbrains.kotlin.resolve.diagnostics.Diagnostics
import org.jetbrains.kotlin.types.KotlinType
import org.jetbrains.kotlin.utils.singletonOrEmptyList import org.jetbrains.kotlin.utils.singletonOrEmptyList
import java.lang.reflect.* import java.lang.reflect.*
import java.util.* import java.util.*
@@ -156,9 +157,16 @@ private object NoDeclarationDescriptorsChecker {
private fun checkType(type: Type, field: Field) { private fun checkType(type: Type, field: Field) {
when (type) { when (type) {
is Class<*> -> { is Class<*> -> {
if (DeclarationDescriptor::class.java.isAssignableFrom(type)) { if (DeclarationDescriptor::class.java.isAssignableFrom(type) || KotlinType::class.java.isAssignableFrom(type)) {
LOG.error("QuickFix class ${field.declaringClass.name} contains field ${field.name} that holds DeclarationDescriptor") LOG.error("QuickFix class ${field.declaringClass.name} contains field ${field.name} that holds ${type.simpleName}. "
+ "This leads to holding too much memory through this quick-fix instance. "
+ "Possible solution can be wrapping it using KotlinIntentionActionFactoryWithDelegate.")
} }
if (IntentionAction::class.java.isAssignableFrom(type)) {
check(type)
}
} }
is GenericArrayType -> checkType(type.genericComponentType, field) is GenericArrayType -> checkType(type.genericComponentType, field)