[K/N][Runtime] Switch thread states in termination handlers

This commit is contained in:
Ilya Matveev
2021-07-19 20:14:14 +07:00
committed by Space
parent a1f6c70355
commit 99bd26c2ef
15 changed files with 536 additions and 126 deletions
@@ -3738,7 +3738,7 @@ ALWAYS_INLINE void kotlin::AssertThreadState(MemoryState* thread, std::initializ
// no-op, used by the new MM only.
}
MemoryState* kotlin::mm::GetMemoryState() {
MemoryState* kotlin::mm::GetMemoryState() noexcept {
return ::memoryState;
}
@@ -47,6 +47,18 @@ void ThrowException(KRef exception) {
namespace {
// This function accesses a TLS variable under the hood, so it must not be called from a thread destructor (see kotlin::mm::GetMemoryState).
[[nodiscard]] kotlin::ThreadStateGuard setNativeStateForRegisteredThread(bool reentrant = true) {
auto* memoryState = kotlin::mm::GetMemoryState();
if (memoryState) {
return kotlin::ThreadStateGuard(kotlin::ThreadState::kNative, reentrant);
} else {
// The current thread is not registered in the Kotlin runtime,
// just return an empty guard which doesn't actually switch the state.
return kotlin::ThreadStateGuard();
}
}
class {
/**
* Timeout 5 sec for concurrent (second) terminate attempt to give a chance the first one to finish.
@@ -61,6 +73,7 @@ class {
// block() is supposed to be NORETURN, otherwise go to normal abort()
konan::abort();
} else {
auto guard = setNativeStateForRegisteredThread();
sleep(timeoutSec);
// We come here when another terminate handler hangs for 5 sec, that looks fatally broken. Go to forced exit now.
}
@@ -121,18 +134,25 @@ class TerminateHandler : private kotlin::Pinned {
try {
std::rethrow_exception(currentException);
} catch (ExceptionObjHolder& e) {
// Use the reentrant switch because both states are possible here:
// - runnable, if the exception occured in a pure Kotlin thread (except initialization of globals).
// - native, if the throwing code was called from ObjC/Swift or if the exception occured during initialization of globals.
kotlin::ThreadStateGuard guard(kotlin::ThreadState::kRunnable, /* reentrant = */ true);
// Both thread states are allowed here because there is no guarantee that
// C++ runtime will unwind the stack for an unhandled exception. Thus there
// is no guarantee that state switches made on interop borders will be rolled back.
// Moreover, a native code can catch an exception thrown by a Kotlin callback,
// store it to a global and then re-throw it in another thread which is not attached
// to the Kotlin runtime. To handle this case, use the CalledFromNativeGuard.
// TODO: Forbid throwing Kotlin exceptions through the interop border to get rid of this case.
kotlin::CalledFromNativeGuard guard(/* reentrant = */ true);
processUnhandledException(e.GetExceptionObject());
terminateWithUnhandledException(e.GetExceptionObject());
} catch (...) {
// Not a Kotlin exception - call default handler
auto guard = setNativeStateForRegisteredThread();
queuedHandler();
}
}
// Come here in case of direct terminate() call or unknown exception - go to default terminate handler.
auto guard = setNativeStateForRegisteredThread();
queuedHandler();
}
@@ -2,16 +2,23 @@
* Copyright 2010-2021 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license
* that can be found in the LICENSE file.
*/
#include "Exceptions.h"
#include <csignal>
#include <memory>
#include <future>
#include "gtest/gtest.h"
#include "gmock/gmock.h"
#include "Memory.h"
#include "ObjectTestSupport.hpp"
#include "TestSupportCompilerGenerated.hpp"
#include "TestSupport.hpp"
using namespace kotlin;
using namespace testing;
using namespace kotlin;
using ::testing::_;
@@ -131,125 +138,125 @@ TEST(ExceptionDeathTest, TerminateWithUnhandledException) {
TEST(ExceptionDeathTest, TerminateHandler_WithHook) {
test_support::TypeInfoHolder typeHolder{test_support::TypeInfoHolder::ObjectBuilder<Payload>().setSuperType(theThrowableTypeInfo)};
kotlin::RunInNewThread([&typeHolder]() {
Object exception(typeHolder.typeInfo());
exception.header()->typeInfoOrMeta_ = setPointerBits(exception.header()->typeInfoOrMeta_, OBJECT_TAG_PERMANENT_CONTAINER);
exception->value = 42;
auto reportUnhandledExceptionMock = ScopedReportUnhandledExceptionMock();
auto Kotlin_runUnhandledExceptionHookMock = ScopedKotlin_runUnhandledExceptionHookMock();
ON_CALL(*reportUnhandledExceptionMock, Call(_)).WillByDefault([](KRef exception) {
konan::consoleErrorf("Reporting %d\n", Object::FromObjHeader(exception)->value);
});
ON_CALL(*Kotlin_runUnhandledExceptionHookMock, Call(_)).WillByDefault([](KRef exception) {
konan::consoleErrorf("Hook %d\n", Object::FromObjHeader(exception)->value);
});
EXPECT_DEATH(
{
std::set_terminate([]() {
konan::consoleErrorf("Custom terminate\n");
if (auto exception = std::current_exception()) {
try {
std::rethrow_exception(exception);
} catch (int i) {
konan::consoleErrorf("Exception %d\n", i);
} catch (...) {
konan::consoleErrorf("Unknown Exception\n");
}
}
});
SetKonanTerminateHandler();
try {
ThrowException(exception.header());
} catch (...) {
std::terminate();
}
},
"Hook 42\n");
Object exception(typeHolder.typeInfo());
exception.header()->typeInfoOrMeta_ = setPointerBits(exception.header()->typeInfoOrMeta_, OBJECT_TAG_PERMANENT_CONTAINER);
exception->value = 42;
auto reportUnhandledExceptionMock = ScopedReportUnhandledExceptionMock();
auto Kotlin_runUnhandledExceptionHookMock = ScopedKotlin_runUnhandledExceptionHookMock();
ON_CALL(*reportUnhandledExceptionMock, Call(_)).WillByDefault([](KRef exception) {
konan::consoleErrorf("Reporting %d\n", Object::FromObjHeader(exception)->value);
});
ON_CALL(*Kotlin_runUnhandledExceptionHookMock, Call(_)).WillByDefault([](KRef exception) {
konan::consoleErrorf("Hook %d\n", Object::FromObjHeader(exception)->value);
});
EXPECT_DEATH(
{
std::set_terminate([]() {
konan::consoleErrorf("Custom terminate\n");
if (auto exception = std::current_exception()) {
try {
std::rethrow_exception(exception);
} catch (int i) {
konan::consoleErrorf("Exception %d\n", i);
} catch (...) {
konan::consoleErrorf("Unknown Exception\n");
}
}
});
// The termination handler will check the initialization of the whole runtime, so we cannot use RunInNewThread here.
// This call also sets the K/N termination handler.
Kotlin_initRuntimeIfNeeded();
try {
ThrowException(exception.header());
} catch (...) {
std::terminate();
}
},
"Hook 42\n");
}
TEST(ExceptionDeathTest, TerminateHandler_NoHook) {
test_support::TypeInfoHolder typeHolder{test_support::TypeInfoHolder::ObjectBuilder<Payload>().setSuperType(theThrowableTypeInfo)};
kotlin::RunInNewThread([&typeHolder]() {
Object exception(typeHolder.typeInfo());
exception.header()->typeInfoOrMeta_ = setPointerBits(exception.header()->typeInfoOrMeta_, OBJECT_TAG_PERMANENT_CONTAINER);
exception->value = 42;
auto reportUnhandledExceptionMock = ScopedReportUnhandledExceptionMock();
auto Kotlin_runUnhandledExceptionHookMock = ScopedKotlin_runUnhandledExceptionHookMock();
ON_CALL(*reportUnhandledExceptionMock, Call(_)).WillByDefault([](KRef exception) {
konan::consoleErrorf("Reporting %d\n", Object::FromObjHeader(exception)->value);
});
ON_CALL(*Kotlin_runUnhandledExceptionHookMock, Call(_)).WillByDefault([](KRef exception) {
konan::consoleErrorf("Hook %d\n", Object::FromObjHeader(exception)->value);
// Kotlin_runUnhandledExceptionHookMock rethrows original exception when hook is unset.
ThrowException(exception);
});
EXPECT_DEATH(
{
std::set_terminate([]() {
konan::consoleErrorf("Custom terminate\n");
if (auto exception = std::current_exception()) {
try {
std::rethrow_exception(exception);
} catch (int i) {
konan::consoleErrorf("Exception %d\n", i);
} catch (...) {
konan::consoleErrorf("Unknown Exception\n");
}
}
});
SetKonanTerminateHandler();
try {
ThrowException(exception.header());
} catch (...) {
std::terminate();
}
},
"Hook 42\nReporting 42\n");
Object exception(typeHolder.typeInfo());
exception.header()->typeInfoOrMeta_ = setPointerBits(exception.header()->typeInfoOrMeta_, OBJECT_TAG_PERMANENT_CONTAINER);
exception->value = 42;
auto reportUnhandledExceptionMock = ScopedReportUnhandledExceptionMock();
auto Kotlin_runUnhandledExceptionHookMock = ScopedKotlin_runUnhandledExceptionHookMock();
ON_CALL(*reportUnhandledExceptionMock, Call(_)).WillByDefault([](KRef exception) {
konan::consoleErrorf("Reporting %d\n", Object::FromObjHeader(exception)->value);
});
ON_CALL(*Kotlin_runUnhandledExceptionHookMock, Call(_)).WillByDefault([](KRef exception) {
konan::consoleErrorf("Hook %d\n", Object::FromObjHeader(exception)->value);
// Kotlin_runUnhandledExceptionHookMock rethrows original exception when hook is unset.
ThrowException(exception);
});
EXPECT_DEATH(
{
std::set_terminate([]() {
konan::consoleErrorf("Custom terminate\n");
if (auto exception = std::current_exception()) {
try {
std::rethrow_exception(exception);
} catch (int i) {
konan::consoleErrorf("Exception %d\n", i);
} catch (...) {
konan::consoleErrorf("Unknown Exception\n");
}
}
});
// The termination handler will check the initialization of the whole runtime, so we cannot use RunInNewThread here.
// This call also sets the K/N termination handler.
Kotlin_initRuntimeIfNeeded();
try {
ThrowException(exception.header());
} catch (...) {
std::terminate();
}
},
"Hook 42\nReporting 42\n");
}
TEST(ExceptionDeathTest, TerminateHandler_WithFailingHook) {
test_support::TypeInfoHolder typeHolder{test_support::TypeInfoHolder::ObjectBuilder<Payload>().setSuperType(theThrowableTypeInfo)};
kotlin::RunInNewThread([&typeHolder]() {
Object exception(typeHolder.typeInfo());
exception.header()->typeInfoOrMeta_ = setPointerBits(exception.header()->typeInfoOrMeta_, OBJECT_TAG_PERMANENT_CONTAINER);
exception->value = 42;
Object hookException(typeHolder.typeInfo());
hookException.header()->typeInfoOrMeta_ = setPointerBits(hookException.header()->typeInfoOrMeta_, OBJECT_TAG_PERMANENT_CONTAINER);
hookException->value = 13;
auto reportUnhandledExceptionMock = ScopedReportUnhandledExceptionMock();
auto Kotlin_runUnhandledExceptionHookMock = ScopedKotlin_runUnhandledExceptionHookMock();
ON_CALL(*reportUnhandledExceptionMock, Call(_)).WillByDefault([](KRef exception) {
konan::consoleErrorf("Reporting %d\n", Object::FromObjHeader(exception)->value);
});
ON_CALL(*Kotlin_runUnhandledExceptionHookMock, Call(_)).WillByDefault([&hookException](KRef exception) {
konan::consoleErrorf("Hook %d\n", Object::FromObjHeader(exception)->value);
ThrowException(hookException.header());
});
EXPECT_DEATH(
{
std::set_terminate([]() {
konan::consoleErrorf("Custom terminate\n");
if (auto exception = std::current_exception()) {
try {
std::rethrow_exception(exception);
} catch (int i) {
konan::consoleErrorf("Exception %d\n", i);
} catch (...) {
konan::consoleErrorf("Unknown Exception\n");
}
}
});
SetKonanTerminateHandler();
try {
ThrowException(exception.header());
} catch (...) {
std::terminate();
}
},
"Hook 42\nReporting 13\n");
Object exception(typeHolder.typeInfo());
exception.header()->typeInfoOrMeta_ = setPointerBits(exception.header()->typeInfoOrMeta_, OBJECT_TAG_PERMANENT_CONTAINER);
exception->value = 42;
Object hookException(typeHolder.typeInfo());
hookException.header()->typeInfoOrMeta_ = setPointerBits(hookException.header()->typeInfoOrMeta_, OBJECT_TAG_PERMANENT_CONTAINER);
hookException->value = 13;
auto reportUnhandledExceptionMock = ScopedReportUnhandledExceptionMock();
auto Kotlin_runUnhandledExceptionHookMock = ScopedKotlin_runUnhandledExceptionHookMock();
ON_CALL(*reportUnhandledExceptionMock, Call(_)).WillByDefault([](KRef exception) {
konan::consoleErrorf("Reporting %d\n", Object::FromObjHeader(exception)->value);
});
ON_CALL(*Kotlin_runUnhandledExceptionHookMock, Call(_)).WillByDefault([&hookException](KRef exception) {
konan::consoleErrorf("Hook %d\n", Object::FromObjHeader(exception)->value);
ThrowException(hookException.header());
});
EXPECT_DEATH(
{
std::set_terminate([]() {
konan::consoleErrorf("Custom terminate\n");
if (auto exception = std::current_exception()) {
try {
std::rethrow_exception(exception);
} catch (int i) {
konan::consoleErrorf("Exception %d\n", i);
} catch (...) {
konan::consoleErrorf("Unknown Exception\n");
}
}
});
// The termination handler will check the initialization of the whole runtime, so we cannot use RunInNewThread here.
// This call also sets the K/N termination handler.
Kotlin_initRuntimeIfNeeded();
try {
ThrowException(exception.header());
} catch (...) {
std::terminate();
}
},
"Hook 42\nReporting 13\n");
}
TEST(ExceptionDeathTest, TerminateHandler_IgnoreHooks) {
@@ -287,3 +294,236 @@ TEST(ExceptionDeathTest, TerminateHandler_IgnoreHooks) {
"Custom terminate\nException 3\n");
});
}
namespace {
using NativeHandlerMock = NiceMock<MockFunction<void(void)>>;
using OnUnhandledExceptionMock = NiceMock<MockFunction<void(KRef)>>;
KStdUniquePtr<NativeHandlerMock> gNativeHandlerMock = nullptr;
KStdUniquePtr<test_support::ScopedMockFunction<void(KRef), /* Strict = */ false>> gOnUnhandledExceptionMock = nullptr;
// Google Test's death tests do not fail in case of a failed EXPECT_*/ASSERT_* check in a death statement.
// To workaround it, manually check the conditions to be asserted, log all failed conditions and then
// validate that there were no failure messages.
void loggingAssert(bool condition, const char* message) noexcept {
if (!condition) {
std::cerr << "FAIL: " << message << std::endl;
}
}
void log(const char* message) noexcept {
std::cerr << message << std::endl;
}
NativeHandlerMock& setNativeTerminateHandler() noexcept {
gNativeHandlerMock = make_unique<NativeHandlerMock>();
std::set_terminate([]() {
gNativeHandlerMock->Call();
std::abort();
});
return *gNativeHandlerMock;
}
OnUnhandledExceptionMock& setKotlinTerminationHandler() noexcept {
gOnUnhandledExceptionMock =
make_unique<test_support::ScopedMockFunction<void(KRef), /* Strict = */ false>>(ScopedKotlin_runUnhandledExceptionHookMock</* Strict = */ false>());
SetKonanTerminateHandler();
return gOnUnhandledExceptionMock->get();
}
void setupMocks(bool expectRegisteredThread = true) noexcept {
auto& nativeHandlerMock = setNativeTerminateHandler();
ON_CALL(nativeHandlerMock, Call)
.WillByDefault([expectRegisteredThread]() {
if (expectRegisteredThread) {
loggingAssert(mm::GetMemoryState() != nullptr, "Expected registered thread in the native handler");
loggingAssert(GetThreadState() == ThreadState::kNative, "Expected kNative thread state in the native handler");
} else {
loggingAssert(mm::GetMemoryState() == nullptr, "Expected unregistered thread in the native handler");
}
log("Native handler");
});
auto& onUnhandledExceptionMock = setKotlinTerminationHandler();
ON_CALL(onUnhandledExceptionMock, Call)
.WillByDefault([]() {
loggingAssert(GetThreadState() == ThreadState::kRunnable, "Expected kRunnable state in the Kotlin handler");
log("Kotlin handler");
});
}
} // namespace
#define EXPERIMENTAL_MM_ONLY() \
do { \
if (CurrentMemoryModel != MemoryModel::kExperimental) { \
GTEST_SKIP() << "This test requires the Experimental MM"; \
} \
} while(false)
#define ASSERTS_PASSED AllOf(Not(HasSubstr("FAIL")), Not(HasSubstr("runtime assert")))
#define KOTLIN_HANDLER_RAN HasSubstr("Kotlin handler")
#define NATIVE_HANDLER_RAN HasSubstr("Native handler")
TEST(TerminationThreadStateDeathTest, TerminationInRunnableState) {
EXPERIMENTAL_MM_ONLY();
auto testBlock = []() {
setupMocks();
ScopedMemoryInit init;
loggingAssert(GetThreadState() == ThreadState::kRunnable, "Expected kRunnable thread state before std::terminate");
std::terminate();
};
EXPECT_DEATH(testBlock(), AllOf(ASSERTS_PASSED, NATIVE_HANDLER_RAN, Not(KOTLIN_HANDLER_RAN)));
}
TEST(TerminationThreadStateDeathTest, TerminationInNativeState) {
EXPERIMENTAL_MM_ONLY();
auto testBlock = []() {
setupMocks();
ScopedMemoryInit init;
ThreadStateGuard stateGuard(ThreadState::kNative);
loggingAssert(GetThreadState() == ThreadState::kNative, "Expected native thread state before std::terminate");
std::terminate();
};
EXPECT_DEATH(testBlock(),
AllOf(ASSERTS_PASSED, NATIVE_HANDLER_RAN, Not(KOTLIN_HANDLER_RAN)));
}
TEST(TerminationThreadStateDeathTest, TerminationInForeignThread) {
EXPERIMENTAL_MM_ONLY();
auto testBlock = []() {
setupMocks(/* expectRegisteredThread = */ false);
loggingAssert(mm::GetMemoryState() == nullptr, "Expected unregistered thread before std::terminate");
std::terminate();
};
EXPECT_DEATH(testBlock(), AllOf(ASSERTS_PASSED, NATIVE_HANDLER_RAN, Not(KOTLIN_HANDLER_RAN)));
}
TEST(TerminationThreadStateDeathTest, UnhandledKotlinExceptionInRunnableState) {
EXPERIMENTAL_MM_ONLY();
auto testBlock = []() {
setupMocks();
// Do not use RunInNewThread because the termination handler will check initiliazation
// of the whole runtime while RunInNewThread initializes the memory only.
std::thread thread([]() {
Kotlin_initRuntimeIfNeeded();
SwitchThreadState(mm::GetMemoryState(), ThreadState::kRunnable);
loggingAssert(GetThreadState() == ThreadState::kRunnable, "Expected kRunanble thread state before throwing");
ObjHeader exception{};
ExceptionObjHolder::Throw(&exception);
});
thread.join();
};
EXPECT_DEATH(testBlock(), AllOf(ASSERTS_PASSED, KOTLIN_HANDLER_RAN, Not(NATIVE_HANDLER_RAN)));
}
TEST(TerminationThreadStateDeathTest, UnhandledKotlinExceptionInNativeState) {
EXPERIMENTAL_MM_ONLY();
auto testBlock = []() {
setupMocks();
// This situation is possible if a Kotlin exception thrown by a Kotlin callback is re-thrown in
// another thread which is attached to the Kotlin runtime but has the kNative state.
// Do not use RunInNewThread because the termination handler will check initiliazation
// of the whole runtime while RunInNewThread initializes the memory only.
std::thread thread([]() {
Kotlin_initRuntimeIfNeeded();
loggingAssert(GetThreadState() == ThreadState::kNative, "Expected kNative thread state before throwing");
ObjHeader exception{};
ExceptionObjHolder::Throw(&exception);
});
thread.join();
};
EXPECT_DEATH(testBlock(), AllOf(ASSERTS_PASSED, KOTLIN_HANDLER_RAN, Not(NATIVE_HANDLER_RAN)));
}
TEST(TerminationThreadStateDeathTest, UnhandledKotlinExceptionInForeignThread) {
EXPERIMENTAL_MM_ONLY();
auto testBlock = []() {
setupMocks(/* expectRegisteredThread = */ false);
// It is possible if a Kotlin exception thrown by a Kotlin callback is re-thrown in
// another thread which is not attached to the Kotlin runtime at all.
std::thread foreignThread([]() {
loggingAssert(mm::GetMemoryState() == nullptr, "Expected unregistered thread before throwing");
auto future = std::async(std::launch::async, []() {
// Initial Kotlin exception throwing requires the runtime to be initialized.
// Do not use ScopedMemoryInit because it clears the stable ref queue
// of the current thread on deinitialization. After that the ExceptionObjHolder
// will contain a dangling pointer to the stable ref queue entry.
Kotlin_initRuntimeIfNeeded();
ObjHeader exception{};
ExceptionObjHolder::Throw(&exception);
});
// Re-throw the Kotlin exception in a foreign thread.
future.get();
});
foreignThread.join();
};
EXPECT_DEATH(testBlock(), AllOf(ASSERTS_PASSED, KOTLIN_HANDLER_RAN, Not(NATIVE_HANDLER_RAN)));
}
TEST(TerminationThreadStateDeathTest, UnhandledForeignExceptionInNativeState) {
EXPERIMENTAL_MM_ONLY();
auto testBlock = []() {
setupMocks();
RunInNewThread([](MemoryState* thread) {
SwitchThreadState(thread, ThreadState::kNative);
loggingAssert(GetThreadState(thread) == ThreadState::kNative, "Expected kNative thread state before throwing");
throw std::runtime_error("Foreign exception");
});
};
EXPECT_DEATH(testBlock(), AllOf(ASSERTS_PASSED, NATIVE_HANDLER_RAN, Not(KOTLIN_HANDLER_RAN)));
}
TEST(TerminationThreadStateDeathTest, UnhandledForeignExceptionInForeignThread) {
EXPERIMENTAL_MM_ONLY();
auto testBlock = []() {
setupMocks(/* expectRegisteredThread = */ false);
std::thread foreignThread([]() {
loggingAssert(mm::GetMemoryState() == nullptr, "Expected unregistered thread before throwing");
throw std::runtime_error("Foreign exception");
});
foreignThread.join();
};
EXPECT_DEATH(testBlock(), AllOf(ASSERTS_PASSED, NATIVE_HANDLER_RAN, Not(KOTLIN_HANDLER_RAN)));
}
// Model a filtering exception handler which terminates the program if an interop call throws a foreign exception.
TEST(TerminationThreadStateDeathTest, TerminationInForeignExceptionCatch) {
EXPERIMENTAL_MM_ONLY();
auto testBlock = []() {
setupMocks();
ScopedMemoryInit init;
loggingAssert(GetThreadState(init.memoryState()) == ThreadState::kRunnable, "Expected kRunnable state before catching");
try {
throw std::runtime_error("Foreign exception");
} catch(...) {
std::terminate();
}
};
EXPECT_DEATH(testBlock(), AllOf(ASSERTS_PASSED, NATIVE_HANDLER_RAN, Not(KOTLIN_HANDLER_RAN)));
}
+3 -2
View File
@@ -388,10 +388,11 @@ public:
namespace kotlin {
namespace mm {
// Returns the MemoryState for the current thread. The runtime must be initialized.
// Returns the MemoryState for the current thread.
// If the memory subsystem isn't initialized for the current thread, returns nullptr.
// Try not to use it very often, as (1) thread local access can be slow on some platforms,
// (2) TLS gets deallocated before our thread destruction hooks run.
MemoryState* GetMemoryState();
MemoryState* GetMemoryState() noexcept;
} // namespace mm
@@ -0,0 +1,24 @@
/*
* Copyright 2010-2021 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license
* that can be found in the LICENSE file.
*/
#include "Memory.h"
#include <gtest/gtest.h>
#include "TestSupport.hpp"
using namespace kotlin;
TEST(MemoryStateTest, GetMemoryStateForUnregisteredThread) {
EXPECT_EQ(mm::GetMemoryState(), nullptr);
}
TEST(MemoryStateTest, GetMemoryStateForRegisteredThread) {
RunInNewThread([](MemoryState* expectedState) {
MemoryState* actualState = mm::GetMemoryState();
EXPECT_NE(actualState, nullptr);
EXPECT_EQ(actualState, expectedState);
});
}
+1 -1
View File
@@ -537,7 +537,7 @@ extern "C" ALWAYS_INLINE RUNTIME_NOTHROW void Kotlin_mm_switchThreadStateRunnabl
SwitchThreadState(mm::ThreadRegistry::Instance().CurrentThreadData(), ThreadState::kRunnable);
}
MemoryState* kotlin::mm::GetMemoryState() {
MemoryState* kotlin::mm::GetMemoryState() noexcept {
return ToMemoryState(ThreadRegistry::Instance().CurrentThreadDataNode());
}
@@ -41,7 +41,8 @@ std::unique_lock<mm::ThreadRegistry::Mutex> mm::ThreadRegistry::Lock() noexcept
}
ALWAYS_INLINE mm::ThreadData* mm::ThreadRegistry::CurrentThreadData() const noexcept {
return CurrentThreadDataNode()->Get();
auto* threadDataNode = CurrentThreadDataNode();
return threadDataNode ? threadDataNode->Get() : nullptr;
}
mm::ThreadRegistry::ThreadRegistry() = default;