From 999c3c5e76453cd91c87e3f95eaf97f562116525 Mon Sep 17 00:00:00 2001 From: "Pavel V. Talanov" Date: Fri, 14 Jul 2017 19:32:09 +0300 Subject: [PATCH] Rename services related to script dependencies KotlinScriptConfigurationManager -> ScriptDependenciesManager KotlinScriptExternalImportsProvider -> ScriptDependenciesProvider --- ...pl.kt => CliScriptDependenciesProvider.kt} | 8 ++++---- .../cli/jvm/compiler/KotlinCoreEnvironment.kt | 8 ++++---- .../cli/jvm/repl/GenericReplCompiler.kt | 4 ++-- ...vider.kt => ScriptDependenciesProvider.kt} | 8 ++++---- .../idea/caches/resolve/ScriptModuleInfos.kt | 10 +++++----- .../idea/caches/resolve/getModuleInfo.kt | 4 ++-- .../kotlin/idea/util/ProjectRootsUtil.kt | 4 ++-- .../idea/core/script/DependenciesCache.kt | 4 ++-- .../KotlinScriptDependenciesClassFinder.kt | 6 +++--- ...anager.kt => ScriptDependenciesManager.kt} | 20 +++++++++---------- ...assesInScriptDependenciesShortNameCache.kt | 4 ++-- ...riptDependenciesIndexableSetContributor.kt | 4 ++-- .../KotlinScriptResolveScopeProvider.kt | 4 ++-- ...ncySourceNavigationPolicyForJavaClasses.kt | 4 ++-- idea/src/META-INF/plugin.xml | 8 ++++---- .../KotlinStandaloneScriptRunConfiguration.kt | 4 ++-- .../script/AbstractScriptConfigurationTest.kt | 6 +++--- 17 files changed, 55 insertions(+), 55 deletions(-) rename compiler/cli/src/org/jetbrains/kotlin/cli/common/script/{KotlinScriptExternalImportsProviderImpl.kt => CliScriptDependenciesProvider.kt} (90%) rename compiler/frontend/src/org/jetbrains/kotlin/script/{KotlinScriptExternalImportsProvider.kt => ScriptDependenciesProvider.kt} (78%) rename idea/idea-core/src/org/jetbrains/kotlin/idea/core/script/{KotlinScriptConfigurationManager.kt => ScriptDependenciesManager.kt} (85%) diff --git a/compiler/cli/src/org/jetbrains/kotlin/cli/common/script/KotlinScriptExternalImportsProviderImpl.kt b/compiler/cli/src/org/jetbrains/kotlin/cli/common/script/CliScriptDependenciesProvider.kt similarity index 90% rename from compiler/cli/src/org/jetbrains/kotlin/cli/common/script/KotlinScriptExternalImportsProviderImpl.kt rename to compiler/cli/src/org/jetbrains/kotlin/cli/common/script/CliScriptDependenciesProvider.kt index 4cfef1260ac..9a6aa5ac921 100644 --- a/compiler/cli/src/org/jetbrains/kotlin/cli/common/script/KotlinScriptExternalImportsProviderImpl.kt +++ b/compiler/cli/src/org/jetbrains/kotlin/cli/common/script/CliScriptDependenciesProvider.kt @@ -20,7 +20,7 @@ import com.intellij.openapi.diagnostic.Logger import com.intellij.openapi.project.Project import com.intellij.openapi.vfs.VirtualFile import org.jetbrains.kotlin.script.KotlinScriptDefinitionProvider -import org.jetbrains.kotlin.script.KotlinScriptExternalImportsProvider +import org.jetbrains.kotlin.script.ScriptDependenciesProvider import org.jetbrains.kotlin.script.ScriptContentLoader import java.io.File import java.util.concurrent.locks.ReentrantReadWriteLock @@ -28,10 +28,10 @@ import kotlin.concurrent.read import kotlin.concurrent.write import kotlin.script.dependencies.ScriptDependencies -class KotlinScriptExternalImportsProviderImpl( +class CliScriptDependenciesProvider( project: Project, private val scriptDefinitionProvider: KotlinScriptDefinitionProvider -) : KotlinScriptExternalImportsProvider { +) : ScriptDependenciesProvider { private val cacheLock = ReentrantReadWriteLock() private val cache = hashMapOf() @@ -63,4 +63,4 @@ class KotlinScriptExternalImportsProviderImpl( } } -private val log = Logger.getInstance(KotlinScriptExternalImportsProvider::class.java) \ No newline at end of file +private val log = Logger.getInstance(ScriptDependenciesProvider::class.java) \ No newline at end of file diff --git a/compiler/cli/src/org/jetbrains/kotlin/cli/jvm/compiler/KotlinCoreEnvironment.kt b/compiler/cli/src/org/jetbrains/kotlin/cli/jvm/compiler/KotlinCoreEnvironment.kt index 380a4b535d5..0f410194262 100644 --- a/compiler/cli/src/org/jetbrains/kotlin/cli/jvm/compiler/KotlinCoreEnvironment.kt +++ b/compiler/cli/src/org/jetbrains/kotlin/cli/jvm/compiler/KotlinCoreEnvironment.kt @@ -75,7 +75,7 @@ import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity.ERROR import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity.STRONG_WARNING import org.jetbrains.kotlin.cli.common.messages.MessageCollector import org.jetbrains.kotlin.cli.common.script.CliScriptReportSink -import org.jetbrains.kotlin.cli.common.script.KotlinScriptExternalImportsProviderImpl +import org.jetbrains.kotlin.cli.common.script.CliScriptDependenciesProvider import org.jetbrains.kotlin.cli.common.toBooleanLenient import org.jetbrains.kotlin.cli.jvm.JvmRuntimeVersionsConsistencyChecker import org.jetbrains.kotlin.cli.jvm.config.* @@ -106,7 +106,7 @@ import org.jetbrains.kotlin.resolve.jvm.modules.JavaModuleResolver import org.jetbrains.kotlin.resolve.lazy.declarations.CliDeclarationProviderFactoryService import org.jetbrains.kotlin.resolve.lazy.declarations.DeclarationProviderFactoryService import org.jetbrains.kotlin.script.KotlinScriptDefinitionProvider -import org.jetbrains.kotlin.script.KotlinScriptExternalImportsProvider +import org.jetbrains.kotlin.script.ScriptDependenciesProvider import org.jetbrains.kotlin.script.ScriptReportSink import org.jetbrains.kotlin.utils.PathUtil import java.io.File @@ -189,7 +189,7 @@ class KotlinCoreEnvironment private constructor( scriptDefinitionProvider.setScriptDefinitions( configuration.getList(JVMConfigurationKeys.SCRIPT_DEFINITIONS)) - KotlinScriptExternalImportsProvider.getInstance(project).let { importsProvider -> + ScriptDependenciesProvider.getInstance(project).let { importsProvider -> configuration.addJvmClasspathRoots( sourceFiles.mapNotNull(importsProvider::getScriptDependencies) .flatMap { it.classpath } @@ -523,7 +523,7 @@ class KotlinCoreEnvironment private constructor( with (projectEnvironment.project) { val kotlinScriptDefinitionProvider = KotlinScriptDefinitionProvider() registerService(KotlinScriptDefinitionProvider::class.java, kotlinScriptDefinitionProvider) - registerService(KotlinScriptExternalImportsProvider::class.java, KotlinScriptExternalImportsProviderImpl(projectEnvironment.project, kotlinScriptDefinitionProvider)) + registerService(ScriptDependenciesProvider::class.java, CliScriptDependenciesProvider(projectEnvironment.project, kotlinScriptDefinitionProvider)) registerService(KotlinJavaPsiFacade::class.java, KotlinJavaPsiFacade(this)) registerService(KtLightClassForFacade.FacadeStubCache::class.java, KtLightClassForFacade.FacadeStubCache(this)) if (messageCollector != null) { diff --git a/compiler/cli/src/org/jetbrains/kotlin/cli/jvm/repl/GenericReplCompiler.kt b/compiler/cli/src/org/jetbrains/kotlin/cli/jvm/repl/GenericReplCompiler.kt index 035b1870c02..16bf5454ba3 100644 --- a/compiler/cli/src/org/jetbrains/kotlin/cli/jvm/repl/GenericReplCompiler.kt +++ b/compiler/cli/src/org/jetbrains/kotlin/cli/jvm/repl/GenericReplCompiler.kt @@ -33,7 +33,7 @@ import org.jetbrains.kotlin.psi.KtScriptInitializer import org.jetbrains.kotlin.psi.psiUtil.getChildOfType import org.jetbrains.kotlin.renderer.DescriptorRenderer import org.jetbrains.kotlin.script.KotlinScriptDefinition -import org.jetbrains.kotlin.script.KotlinScriptExternalImportsProvider +import org.jetbrains.kotlin.script.ScriptDependenciesProvider import java.io.File import java.util.concurrent.locks.ReentrantReadWriteLock import kotlin.concurrent.write @@ -68,7 +68,7 @@ open class GenericReplCompiler(disposable: Disposable, Pair(compilerState.lastLineState!!.psiFile, compilerState.lastLineState!!.errorHolder) } - val newDependencies = KotlinScriptExternalImportsProvider.getInstance(checker.environment.project).getScriptDependencies(psiFile) + val newDependencies = ScriptDependenciesProvider.getInstance(checker.environment.project).getScriptDependencies(psiFile) var classpathAddendum: List? = null if (compilerState.lastDependencies != newDependencies) { compilerState.lastDependencies = newDependencies diff --git a/compiler/frontend/src/org/jetbrains/kotlin/script/KotlinScriptExternalImportsProvider.kt b/compiler/frontend/src/org/jetbrains/kotlin/script/ScriptDependenciesProvider.kt similarity index 78% rename from compiler/frontend/src/org/jetbrains/kotlin/script/KotlinScriptExternalImportsProvider.kt rename to compiler/frontend/src/org/jetbrains/kotlin/script/ScriptDependenciesProvider.kt index 0ae57bc732e..dbabae2954a 100644 --- a/compiler/frontend/src/org/jetbrains/kotlin/script/KotlinScriptExternalImportsProvider.kt +++ b/compiler/frontend/src/org/jetbrains/kotlin/script/ScriptDependenciesProvider.kt @@ -22,15 +22,15 @@ import com.intellij.openapi.vfs.VirtualFile import com.intellij.psi.PsiFile import kotlin.script.dependencies.ScriptDependencies -interface KotlinScriptExternalImportsProvider { +interface ScriptDependenciesProvider { fun getScriptDependencies(file: VirtualFile): ScriptDependencies? fun getScriptDependencies(file: PsiFile) = getScriptDependencies(file.virtualFile) companion object { - fun getInstance(project: Project): KotlinScriptExternalImportsProvider = - ServiceManager.getService(project, KotlinScriptExternalImportsProvider::class.java) + fun getInstance(project: Project): ScriptDependenciesProvider = + ServiceManager.getService(project, ScriptDependenciesProvider::class.java) } } fun getScriptExternalDependencies(file: VirtualFile, project: Project): ScriptDependencies? = - KotlinScriptExternalImportsProvider.getInstance(project).getScriptDependencies(file) + ScriptDependenciesProvider.getInstance(project).getScriptDependencies(file) diff --git a/idea/idea-analysis/src/org/jetbrains/kotlin/idea/caches/resolve/ScriptModuleInfos.kt b/idea/idea-analysis/src/org/jetbrains/kotlin/idea/caches/resolve/ScriptModuleInfos.kt index 00c54b54327..352973daf5a 100644 --- a/idea/idea-analysis/src/org/jetbrains/kotlin/idea/caches/resolve/ScriptModuleInfos.kt +++ b/idea/idea-analysis/src/org/jetbrains/kotlin/idea/caches/resolve/ScriptModuleInfos.kt @@ -25,7 +25,7 @@ import com.intellij.psi.search.DelegatingGlobalSearchScope import com.intellij.psi.search.GlobalSearchScope import com.intellij.psi.search.NonClasspathDirectoriesScope import com.intellij.util.containers.SLRUCache -import org.jetbrains.kotlin.idea.core.script.KotlinScriptConfigurationManager +import org.jetbrains.kotlin.idea.core.script.ScriptDependenciesManager import org.jetbrains.kotlin.idea.stubindex.KotlinSourceFilterScope import org.jetbrains.kotlin.name.Name import org.jetbrains.kotlin.script.KotlinScriptDefinition @@ -43,7 +43,7 @@ data class ScriptModuleInfo(val project: Project, val scriptFile: VirtualFile, get() = ModuleOrigin.OTHER val externalDependencies: ScriptDependencies? - get() = KotlinScriptConfigurationManager.getInstance(project).getScriptDependencies(scriptFile) + get() = ScriptDependenciesManager.getInstance(project).getScriptDependencies(scriptFile) override val name: Name = Name.special("