[FIR] Make FirNotImplementedOverrideChecker to run only for non-expect classes or in metadata compilation
^KT-64187 Fixed Review: https://jetbrains.team/p/kt/reviews/14807 I also checked that IDE sets metadataCompilation to `true` (Actually, it looks like IDE performs analysis two times with the flag having different values, but whatever, maybe it's even better this way)
This commit is contained in:
+1
-1
@@ -5,7 +5,7 @@ interface Base {
|
||||
fun foo()
|
||||
}
|
||||
|
||||
expect open <!ABSTRACT_MEMBER_NOT_IMPLEMENTED!>class Foo<!> : Base
|
||||
expect open <!ABSTRACT_MEMBER_NOT_IMPLEMENTED{METADATA}!>class Foo<!> : Base
|
||||
|
||||
// MODULE: m2-jvm()()(m1-common)
|
||||
// FILE: jvm.kt
|
||||
|
||||
+15
@@ -0,0 +1,15 @@
|
||||
// MODULE: m1-common
|
||||
// FILE: common.kt
|
||||
|
||||
interface Base {
|
||||
fun foo()
|
||||
}
|
||||
|
||||
expect open class Foo : Base
|
||||
|
||||
// MODULE: m2-jvm()()(m1-common)
|
||||
// FILE: jvm.kt
|
||||
|
||||
actual open class Foo : Base {
|
||||
final override fun <!ACTUAL_WITHOUT_EXPECT!>foo<!>() {}
|
||||
}
|
||||
+1
-1
@@ -3,7 +3,7 @@
|
||||
interface Base {
|
||||
fun foo()
|
||||
}
|
||||
expect open <!ABSTRACT_MEMBER_NOT_IMPLEMENTED!>class Foo<!>() : Base
|
||||
expect open <!ABSTRACT_MEMBER_NOT_IMPLEMENTED{METADATA}!>class Foo<!>() : Base
|
||||
|
||||
|
||||
// MODULE: m2-jvm()()(m1-common)
|
||||
|
||||
+17
@@ -0,0 +1,17 @@
|
||||
// MODULE: m1-common
|
||||
// FILE: common.kt
|
||||
interface Base {
|
||||
fun foo()
|
||||
}
|
||||
expect open class Foo() : Base
|
||||
|
||||
|
||||
// MODULE: m2-jvm()()(m1-common)
|
||||
// FILE: jvm.kt
|
||||
|
||||
// Mismatched scope must be reported here. But it's false negative checker in K1.
|
||||
// For some reason, K1 says that modality of `exect_Foo.foo` is `abstract`.
|
||||
// https://youtrack.jetbrains.com/issue/KT-59739
|
||||
actual open class Foo : Base {
|
||||
override fun <!ACTUAL_WITHOUT_EXPECT!>foo<!>() {}
|
||||
}
|
||||
+2
-2
@@ -6,9 +6,9 @@ interface B {
|
||||
override fun toString(): String
|
||||
}
|
||||
|
||||
expect value <!ABSTRACT_MEMBER_NOT_IMPLEMENTED!>class C<!>(val s: String) : B
|
||||
expect value <!ABSTRACT_MEMBER_NOT_IMPLEMENTED{METADATA}!>class C<!>(val s: String) : B
|
||||
|
||||
expect value <!ABSTRACT_MEMBER_NOT_IMPLEMENTED!>class D<!>(val s: String) : B
|
||||
expect value <!ABSTRACT_MEMBER_NOT_IMPLEMENTED{METADATA}!>class D<!>(val s: String) : B
|
||||
|
||||
// MODULE: m1-jvm()()(m1-common)
|
||||
// FILE: jvm.kt
|
||||
|
||||
+22
@@ -0,0 +1,22 @@
|
||||
// WITH_STDLIB
|
||||
// MODULE: m1-common
|
||||
// FILE: common.kt
|
||||
|
||||
interface B {
|
||||
override fun toString(): String
|
||||
}
|
||||
|
||||
expect value class C(val s: String) : B
|
||||
|
||||
expect value class D(val s: String) : B
|
||||
|
||||
// MODULE: m1-jvm()()(m1-common)
|
||||
// FILE: jvm.kt
|
||||
|
||||
@JvmInline
|
||||
actual value class C(actual val s: String) : B {
|
||||
override fun toString(): String = s
|
||||
}
|
||||
|
||||
@JvmInline
|
||||
actual value class D(actual val s: String) : B
|
||||
+1
-1
@@ -5,7 +5,7 @@ interface Base {
|
||||
fun foo()
|
||||
}
|
||||
|
||||
expect <!ABSTRACT_MEMBER_NOT_IMPLEMENTED!>object Implementation<!> : Base
|
||||
expect <!ABSTRACT_MEMBER_NOT_IMPLEMENTED{METADATA}!>object Implementation<!> : Base
|
||||
|
||||
// MODULE: m1-jvm()()(m1-common)
|
||||
// FILE: jvm.kt
|
||||
|
||||
+17
@@ -0,0 +1,17 @@
|
||||
// MODULE: m1-common
|
||||
// FILE: common.kt
|
||||
|
||||
interface Base {
|
||||
fun foo()
|
||||
}
|
||||
|
||||
expect object Implementation : Base
|
||||
|
||||
// MODULE: m1-jvm()()(m1-common)
|
||||
// FILE: jvm.kt
|
||||
|
||||
abstract class RealImplementation : Base {
|
||||
override fun foo() {}
|
||||
}
|
||||
|
||||
actual object Implementation : RealImplementation(), Base
|
||||
+2
-2
@@ -5,13 +5,13 @@ interface Foo {
|
||||
fun foo()
|
||||
}
|
||||
|
||||
expect <!ABSTRACT_MEMBER_NOT_IMPLEMENTED!>class ImplicitFoo<!> : Foo
|
||||
expect <!ABSTRACT_MEMBER_NOT_IMPLEMENTED{METADATA}!>class ImplicitFoo<!> : Foo
|
||||
|
||||
expect class ExplicitFoo : Foo {
|
||||
override fun foo()
|
||||
}
|
||||
|
||||
expect <!ABSTRACT_MEMBER_NOT_IMPLEMENTED!>class ImplicitFooCheck<!> : Foo
|
||||
expect <!ABSTRACT_MEMBER_NOT_IMPLEMENTED{METADATA}!>class ImplicitFooCheck<!> : Foo
|
||||
|
||||
// MODULE: m2-jvm()()(m1-common)
|
||||
// FILE: jvm.kt
|
||||
|
||||
+27
@@ -0,0 +1,27 @@
|
||||
// MODULE: m1-common
|
||||
// FILE: common.kt
|
||||
|
||||
interface Foo {
|
||||
fun foo()
|
||||
}
|
||||
|
||||
expect class ImplicitFoo : Foo
|
||||
|
||||
expect class ExplicitFoo : Foo {
|
||||
override fun foo()
|
||||
}
|
||||
|
||||
expect class ImplicitFooCheck : Foo
|
||||
|
||||
// MODULE: m2-jvm()()(m1-common)
|
||||
// FILE: jvm.kt
|
||||
|
||||
actual class ImplicitFoo : Foo {
|
||||
override fun foo() {}
|
||||
}
|
||||
|
||||
actual class ExplicitFoo : Foo {
|
||||
actual override fun foo() {}
|
||||
}
|
||||
|
||||
actual <!ABSTRACT_MEMBER_NOT_IMPLEMENTED!>class ImplicitFooCheck<!> : Foo
|
||||
+3
-3
@@ -4,7 +4,7 @@
|
||||
expect abstract class BaseA() {
|
||||
abstract fun foo()
|
||||
}
|
||||
expect open <!ABSTRACT_CLASS_MEMBER_NOT_IMPLEMENTED!>class BaseAImpl<!>() : BaseA
|
||||
expect open <!ABSTRACT_CLASS_MEMBER_NOT_IMPLEMENTED{METADATA}!>class BaseAImpl<!>() : BaseA
|
||||
|
||||
<!ABSTRACT_CLASS_MEMBER_NOT_IMPLEMENTED, ABSTRACT_CLASS_MEMBER_NOT_IMPLEMENTED{METADATA}!>class DerivedA1<!> : BaseAImpl()
|
||||
class DerivedA2 : BaseAImpl() {
|
||||
@@ -16,7 +16,7 @@ class DerivedA2 : BaseAImpl() {
|
||||
expect interface BaseB {
|
||||
fun foo()
|
||||
}
|
||||
expect open <!ABSTRACT_MEMBER_NOT_IMPLEMENTED!>class BaseBImpl<!>() : BaseB
|
||||
expect open <!ABSTRACT_MEMBER_NOT_IMPLEMENTED{METADATA}!>class BaseBImpl<!>() : BaseB
|
||||
|
||||
<!ABSTRACT_MEMBER_NOT_IMPLEMENTED, ABSTRACT_MEMBER_NOT_IMPLEMENTED{METADATA}!>class DerivedB1<!> : BaseBImpl()
|
||||
class DerivedB2 : BaseBImpl() {
|
||||
@@ -58,7 +58,7 @@ sealed class BaseEImpl() : BaseE {
|
||||
expect interface BaseF {
|
||||
fun foo()
|
||||
}
|
||||
expect <!ABSTRACT_MEMBER_NOT_IMPLEMENTED!>class BaseFImpl<!>() : BaseF
|
||||
expect <!ABSTRACT_MEMBER_NOT_IMPLEMENTED{METADATA}!>class BaseFImpl<!>() : BaseF
|
||||
|
||||
|
||||
|
||||
|
||||
+3
-3
@@ -4,7 +4,7 @@
|
||||
expect abstract class BaseA() {
|
||||
abstract fun foo()
|
||||
}
|
||||
expect open <!ABSTRACT_CLASS_MEMBER_NOT_IMPLEMENTED!>class BaseAImpl<!>() : BaseA
|
||||
expect open class BaseAImpl() : BaseA
|
||||
|
||||
<!ABSTRACT_CLASS_MEMBER_NOT_IMPLEMENTED!>class DerivedA1<!> : BaseAImpl()
|
||||
class DerivedA2 : BaseAImpl() {
|
||||
@@ -16,7 +16,7 @@ class DerivedA2 : BaseAImpl() {
|
||||
expect interface BaseB {
|
||||
fun foo()
|
||||
}
|
||||
expect open <!ABSTRACT_MEMBER_NOT_IMPLEMENTED!>class BaseBImpl<!>() : BaseB
|
||||
expect open class BaseBImpl() : BaseB
|
||||
|
||||
<!ABSTRACT_MEMBER_NOT_IMPLEMENTED!>class DerivedB1<!> : BaseBImpl()
|
||||
class DerivedB2 : BaseBImpl() {
|
||||
@@ -58,7 +58,7 @@ sealed class BaseEImpl() : BaseE {
|
||||
expect interface BaseF {
|
||||
fun foo()
|
||||
}
|
||||
expect <!ABSTRACT_MEMBER_NOT_IMPLEMENTED!>class BaseFImpl<!>() : BaseF
|
||||
expect class BaseFImpl() : BaseF
|
||||
|
||||
|
||||
|
||||
|
||||
+1
-1
@@ -5,7 +5,7 @@ expect abstract class Base {
|
||||
abstract fun foo()
|
||||
}
|
||||
|
||||
expect <!ABSTRACT_CLASS_MEMBER_NOT_IMPLEMENTED!>class DerivedImplicit<!> : Base
|
||||
expect <!ABSTRACT_CLASS_MEMBER_NOT_IMPLEMENTED{METADATA}!>class DerivedImplicit<!> : Base
|
||||
|
||||
expect class DerivedExplicit : Base {
|
||||
override fun foo()
|
||||
|
||||
+35
@@ -0,0 +1,35 @@
|
||||
// MODULE: m1-common
|
||||
// FILE: common.kt
|
||||
|
||||
expect abstract class Base {
|
||||
abstract fun foo()
|
||||
}
|
||||
|
||||
expect class DerivedImplicit : Base
|
||||
|
||||
expect class DerivedExplicit : Base {
|
||||
override fun foo()
|
||||
}
|
||||
|
||||
expect class DerivedExplicitCheck : Base {
|
||||
override fun foo()
|
||||
}
|
||||
|
||||
// MODULE: m2-jvm()()(m1-common)
|
||||
// FILE: jvm.kt
|
||||
|
||||
actual abstract class Base {
|
||||
actual abstract fun foo()
|
||||
}
|
||||
|
||||
actual class DerivedImplicit : Base() {
|
||||
override fun foo() {}
|
||||
}
|
||||
|
||||
actual class DerivedExplicit : Base() {
|
||||
actual override fun foo() {}
|
||||
}
|
||||
|
||||
actual class DerivedExplicitCheck : Base() {
|
||||
override fun <!ACTUAL_MISSING!>foo<!>() {}
|
||||
}
|
||||
Reference in New Issue
Block a user