From 98060d28a8f959555498c4f7263a2c3febbeaf51 Mon Sep 17 00:00:00 2001 From: Nikolay Krasko Date: Mon, 23 May 2016 18:17:40 +0300 Subject: [PATCH] Don't request write action for ChangeParameterTypeFix because it's based on refactoring Workaround for exception: Refactorings should not be started inside write action because they start progress inside and any read action from the progress task would cause the deadlock --- .../jetbrains/kotlin/idea/quickfix/ChangeParameterTypeFix.kt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/idea/src/org/jetbrains/kotlin/idea/quickfix/ChangeParameterTypeFix.kt b/idea/src/org/jetbrains/kotlin/idea/quickfix/ChangeParameterTypeFix.kt index 210945a3233..f51756f89e3 100644 --- a/idea/src/org/jetbrains/kotlin/idea/quickfix/ChangeParameterTypeFix.kt +++ b/idea/src/org/jetbrains/kotlin/idea/quickfix/ChangeParameterTypeFix.kt @@ -47,6 +47,8 @@ class ChangeParameterTypeFix(element: KtParameter, type: KotlinType) : KotlinQui this.isPrimaryConstructorParameter = declaration is KtPrimaryConstructor } + override fun startInWriteAction(): Boolean = false + override fun isAvailable(project: Project, editor: Editor?, file: PsiFile): Boolean { return super.isAvailable(project, editor, file) && containingDeclarationName != null }