"Nested lambda has shadowed implicit parameter": show warning on the shadowing 'it' reference

idea/src/org/jetbrains/kotlin/idea/inspections/NestedLambdaShadowedImplicitParameterInspection.kt

@@ -28,12 +28,11 @@ class NestedLambdaShadowedImplicitParameterInspection : AbstractKotlinInspection
             val context = lambda.analyze(BodyResolveMode.PARTIAL)
             val implicitParameter = lambda.functionDescriptor(context)?.valueParameters?.singleOrNull() ?: return
             if (lambda.getParentImplicitParameterLambda(context) == null) return
-            if (lambda.findDescendantOfType<KtNameReferenceExpression> {
+            val implicitParameterReference = lambda.findDescendantOfType<KtNameReferenceExpression> {
-                    it.text == "it" && it.getResolvedCall(context)?.resultingDescriptor == implicitParameter
+                it.text == "it" && it.getResolvedCall(context)?.resultingDescriptor == implicitParameter
-                } == null) return
+            } ?: return
-            val callee = lambda.getStrictParentOfType<KtCallExpression>()?.calleeExpression ?: return
             holder.registerProblem(
-                callee,
+                implicitParameterReference,
                 "Implicit parameter 'it' of enclosing lambda is shadowed",
                 ProblemHighlightType.GENERIC_ERROR_OR_WARNING,
                 AddExplicitParameterNameFix()
@@ -47,7 +46,9 @@ class NestedLambdaShadowedImplicitParameterInspection : AbstractKotlinInspection
         override fun getFamilyName() = name
 
         override fun applyFix(project: Project, descriptor: ProblemDescriptor) {
-            val parentLambda = (descriptor.psiElement as? KtExpression)?.getParentImplicitParameterLambda() ?: return
+            val implicitParameterReference = descriptor.psiElement as? KtNameReferenceExpression ?: return
+            val lambda = implicitParameterReference.getStrictParentOfType<KtLambdaExpression>() ?: return
+            val parentLambda = lambda.getParentImplicitParameterLambda() ?: return
             val parameter = parentLambda.functionLiteral.getOrCreateParameterList().addParameterBefore(
                 KtPsiFactory(project).createLambdaParameterList("it").parameters.first(), null
             )

idea/testData/inspectionsLocal/nestedLambdaShadowedImplicitParameter/explicit.kt

@@ -1,10 +1,12 @@
 // PROBLEM: none
 
 fun foo(f: (String) -> Unit) {}
+fun bar(s: String) {}
 
 fun test() {
     foo {
-        <caret>foo { s ->
+        foo { s ->
+            bar(it<caret>)
         }
     }
 }

idea/testData/inspectionsLocal/nestedLambdaShadowedImplicitParameter/explicitParent.kt

@@ -1,10 +1,12 @@
 // PROBLEM: none
 
 fun foo(f: (String) -> Unit) {}
+fun bar(s: String) {}
 
 fun test() {
     foo { s ->
-        <caret>foo {
+        foo {
+            bar(it<caret>)
         }
     }
 }

idea/testData/inspectionsLocal/nestedLambdaShadowedImplicitParameter/implicit.kt

@@ -3,8 +3,8 @@ fun bar(s: String) {}
 
 fun test() {
     foo {
-        <caret>foo {
+        foo {
-            bar(it)
+            bar(it<caret>)
         }
     }
 }

idea/testData/inspectionsLocal/nestedLambdaShadowedImplicitParameter/implicit2.kt

@@ -4,8 +4,8 @@ fun bar(f: (Int) -> Unit) {}
 fun test() {
     foo {
         val s: String = it
-        <caret>bar {
+        bar {
-            val i: Int = it
+            val i: Int = it<caret>
         }
     }
 }

idea/testData/inspectionsLocal/nestedLambdaShadowedImplicitParameter/implicitGrandParent.kt

@@ -4,8 +4,8 @@ fun bar(s: String) {}
 fun test() {
     foo {
         foo { s ->
-            <caret>foo {
+            foo {
-                bar(it)
+                bar(it<caret>)
             }
         }
     }

idea/testData/inspectionsLocal/nestedLambdaShadowedImplicitParameter/notUseParameter.kt

@@ -1,10 +1,12 @@
 // PROBLEM: none
 
 fun foo(f: (String) -> Unit) {}
+fun bar(s: String) {}
 
 fun test() {
     foo {
-        <caret>foo {
+        foo {
+            bar(""<caret>)
         }
     }
 }

idea/testData/inspectionsLocal/nestedLambdaShadowedImplicitParameter/receiver.kt

@@ -2,10 +2,12 @@
 
 fun foo(f: (String) -> Unit) {}
 fun bar(f: String.() -> Unit) {}
+fun baz(s: String) {}
 
 fun test() {
     foo {
         <caret>bar {
+            baz(it<caret>)
         }
     }
 }

idea/testData/inspectionsLocal/nestedLambdaShadowedImplicitParameter/receiverParent.kt

@@ -2,10 +2,12 @@
 
 fun foo(f: (String) -> Unit) {}
 fun bar(f: String.() -> Unit) {}
+fun baz(s: String) {}
 
 fun test() {
     bar {
-        <caret>foo {
+        foo {
+            baz(it<caret>)
         }
     }
 }