azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Lazy...ResolverWithPhaseChecking: add note about symbol current phase

Browse Source
This commit is contained in:
Mikhail Glukhikh
2022-11-30 12:03:55 +01:00
committed by Space Team
parent 1bb537a3f2
commit 96d697e61b
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/fir/resolve/src/org/jetbrains/kotlin/fir/resolve/transformers/FirCompilerLazyDeclarationResolverWithPhaseChecking.kt
+5
View File
@@ -38,6 +38,11 @@ class FirCompilerLazyDeclarationResolverWithPhaseChecking : FirLazyDeclarationRe
val currentPhase = currentTransformerPhase val currentPhase = currentTransformerPhase
?: error("Current phase is not set, please call ${this::startResolvingPhase.name} before starting transforming the file") ?: error("Current phase is not set, please call ${this::startResolvingPhase.name} before starting transforming the file")
// TODO: symbol current phase can already be requestedPhase or more.
// This case is not a violation of any contract
// However, now we keep more strict invariant here,
// because we don't want to hide some cases when transformers violate phase contract directly
// but due to usage of already resolved stdlib classes we don't see it
if (requestedPhase >= currentPhase) { if (requestedPhase >= currentPhase) {
exceptions += FirLazyResolveContractViolationException( exceptions += FirLazyResolveContractViolationException(
"""`lazyResolveToPhase($requestedPhase)` cannot be called from a transformer with a phase $currentPhase. """`lazyResolveToPhase($requestedPhase)` cannot be called from a transformer with a phase $currentPhase.