azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove brittle ‘contains’ optimization in minus/removeAll/retainAll #KT-45438

Browse Source
This commit is contained in:
Abduqodiri Qurbonzoda
2021-07-12 13:56:33 +03:00
committed by Ilya Gorbunov
parent fbc43cbebe
commit 94b371af5b
10 changed files with 88 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libraries/tools/kotlin-stdlib-gen/src/templates/Generators.kt
+4 -4
View File
@@ -455,7 +455,7 @@ object Generators : TemplateGroupBase() {
body {
"""
if (elements.isEmpty()) return this.toList()
val other = elements.toHashSet()
val other = elements.convertToSetForSetOperation()
return this.filterNot { it in other }
"""
}
@@ -491,7 +491,7 @@ object Generators : TemplateGroupBase() {
if (elements.isEmpty()) return this
return object: Sequence<T> {
override fun iterator(): Iterator<T> {
val other = elements.toHashSet()
val other = elements.convertToSetForSetOperation()
return this@minus.filterNot { it in other }.iterator()
}
}
@@ -513,7 +513,7 @@ object Generators : TemplateGroupBase() {
specialFor(Sets, Sequences) { returns("SELF") }
body {
"""
val other = elements.toHashSet()
val other = elements.convertToSetForSetOperation()
if (other.isEmpty())
return this.toList()
@@ -552,7 +552,7 @@ object Generators : TemplateGroupBase() {
"""
return object: Sequence<T> {
override fun iterator(): Iterator<T> {
val other = elements.toHashSet()
val other = elements.convertToSetForSetOperation()
if (other.isEmpty())
return this@minus.iterator()
else