azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIR] Remove implicit coercion of ifs and whens to Unit

Browse Source 
The rule of thumb is the following:
If the `if` and `when` can be successfully replaced with `while`,
then it is used as a statement, otherwise, it is used as an expression.

#KT-59883
This commit is contained in:
Evgeniy.Zhelenskiy
2024-02-20 03:12:56 +01:00
committed by Space Team
parent 2e66954d01
commit 931f2eab58
16 changed files with 256 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/testData/diagnostics/tests/controlFlowAnalysis/tryCatchFinallyIfs.kt
Vendored
+184
View File
@@ -0,0 +1,184 @@
// FIR_IDENTICAL
// DIAGNOSTICS: -UNUSED_EXPRESSION
fun ifExpr() = try {
if (true) 2
<!INVALID_IF_AS_EXPRESSION!>if<!> (true) 2
} catch (e: Exception) {
if (true) 3
<!INVALID_IF_AS_EXPRESSION!>if<!> (true) 3
} catch (e: Throwable) {
if (true) 4
<!INVALID_IF_AS_EXPRESSION!>if<!> (true) 4
} finally {
if (true) 5
if (true) 5
}
fun ifBlock() = try {
if (true) {
2
}
<!INVALID_IF_AS_EXPRESSION!>if<!> (true) {
2
}
} catch (e: Exception) {
if (true) {
3
}
<!INVALID_IF_AS_EXPRESSION!>if<!> (true) {
3
}
} catch (e: Throwable) {
if (true) {
4
}
<!INVALID_IF_AS_EXPRESSION!>if<!> (true) {
4
}
} finally {
if (true) {
5
}
if (true) {
5
}
}
fun whenExpr() = try {
when {
true -> 2
}
<!NO_ELSE_IN_WHEN!>when<!> {
true -> 2
}
} catch (e: Exception) {
when {
true -> 3
}
<!NO_ELSE_IN_WHEN!>when<!> {
true -> 3
}
} catch (e: Throwable) {
when {
true -> 4
}
<!NO_ELSE_IN_WHEN!>when<!> {
true -> 4
}
} finally {
when {
true -> 5
}
when {
true -> 5
}
}
fun whenBlock() = try {
when {
true -> {
2
}
}
<!NO_ELSE_IN_WHEN!>when<!> {
true -> {
2
}
}
} catch (e: Exception) {
when {
true -> {
3
}
}
<!NO_ELSE_IN_WHEN!>when<!> {
true -> {
3
}
}
} catch (e: Throwable) {
when {
true -> {
4
}
}
<!NO_ELSE_IN_WHEN!>when<!> {
true -> {
4
}
}
} finally {
when {
true -> {
5
}
}
when {
true -> {
5
}
}
}
fun ifExpr2(): Any {
try {
if (true) 2
if (true) 2
} catch (e: Exception) {
if (true) 3
if (true) 3
} catch (e: Throwable) {
if (true) 4
if (true) 4
} finally {
if (true) 5
if (true) 5
}
return try {
if (true) 2
<!INVALID_IF_AS_EXPRESSION!>if<!> (true) 2
} catch (e: Exception) {
if (true) 3
<!INVALID_IF_AS_EXPRESSION!>if<!> (true) 3
} catch (e: Throwable) {
if (true) 4
<!INVALID_IF_AS_EXPRESSION!>if<!> (true) 4
} finally {
if (true) 5
if (true) 5
}
}
fun ifExpr3() {
try {
if (true) 2
if (true) 2
} catch (e: Exception) {
if (true) 3
if (true) 3
} catch (e: Throwable) {
if (true) 4
if (true) 4
} finally {
if (true) 5
if (true) 5
}
try {
if (true) 2
if (true) 2
} catch (e: Exception) {
if (true) 3
if (true) 3
} catch (e: Throwable) {
if (true) 4
if (true) 4
} finally {
if (true) 5
if (true) 5
}
}