Create from Usage: Implement 'Create property as constructor parameter' quick-fix

#KT-8426 Fixed

idea/testData/quickfix/createFromUsage/createVariable/localVariable/qualifiedInFun.kt

@@ -1,6 +1,7 @@
 // "Create local variable 'foo'" "false"
 // ACTION: Create extension property 'foo'
 // ACTION: Create member property 'foo'
+// ACTION: Create property 'foo' as constructor parameter
 // ERROR: Unresolved reference: foo
 
 class A

idea/testData/quickfix/createFromUsage/createVariable/parameter/assignedInFunInClass.kt

@@ -1,4 +1,4 @@
-// "Create parameter 'foo'" "true"
+// "Create property 'foo' as constructor parameter" "true"
 
 class A {
     fun test(n: Int) {

idea/testData/quickfix/createFromUsage/createVariable/parameter/assignedInFunInClass.kt.after

@@ -1,4 +1,4 @@
-// "Create parameter 'foo'" "true"
+// "Create property 'foo' as constructor parameter" "true"
 
 class A(var foo: Int) {
     fun test(n: Int) {

idea/testData/quickfix/createFromUsage/createVariable/parameter/inAccessorInClass.kt

@@ -1,4 +1,4 @@
-// "Create parameter 'foo'" "true"
+// "Create property 'foo' as constructor parameter" "true"
 
 class A {
     val test: Int get() {

idea/testData/quickfix/createFromUsage/createVariable/parameter/inAccessorInClass.kt.after

@@ -1,4 +1,4 @@
-// "Create parameter 'foo'" "true"
+// "Create property 'foo' as constructor parameter" "true"
 
 class A(val foo: Int) {
     val test: Int get() {

idea/testData/quickfix/createFromUsage/createVariable/parameter/inAccessorInGenClass.kt

@@ -1,4 +1,4 @@
-// "Create parameter 'foo'" "true"
+// "Create property 'foo' as constructor parameter" "true"
 
 class A<T> {
     val test: T get() {

idea/testData/quickfix/createFromUsage/createVariable/parameter/inAccessorInGenClass.kt.after

@@ -1,4 +1,4 @@
-// "Create parameter 'foo'" "true"
+// "Create property 'foo' as constructor parameter" "true"
 
 class A<T>(val foo: T) {
     val test: T get() {

idea/testData/quickfix/createFromUsage/createVariable/parameter/inAccessorWithExpressionBodyInClass.kt

@@ -1,4 +1,4 @@
-// "Create parameter 'foo'" "true"
+// "Create property 'foo' as constructor parameter" "true"
 
 class A {
     val test: Int get() = <caret>foo

idea/testData/quickfix/createFromUsage/createVariable/parameter/inAccessorWithExpressionBodyInClass.kt.after

@@ -1,4 +1,4 @@
-// "Create parameter 'foo'" "true"
+// "Create property 'foo' as constructor parameter" "true"
 
 class A(val foo: Int) {
     val test: Int get() = foo

idea/testData/quickfix/createFromUsage/createVariable/parameter/inPropertyInitializerInEnumEntry.kt

@@ -1,4 +1,4 @@
-// "Create parameter 'foo'" "true"
+// "Create property 'foo' as constructor parameter" "true"
 // ERROR: No value passed for parameter foo
 // ERROR: No value passed for parameter foo
 // ERROR: No value passed for parameter foo

idea/testData/quickfix/createFromUsage/createVariable/parameter/inPropertyInitializerInEnumEntry.kt.after

@@ -1,4 +1,4 @@
-// "Create parameter 'foo'" "true"
+// "Create property 'foo' as constructor parameter" "true"
 // ERROR: No value passed for parameter foo
 // ERROR: No value passed for parameter foo
 // ERROR: No value passed for parameter foo

idea/testData/quickfix/createFromUsage/createVariable/parameter/qualifiedInFun.kt

@@ -1,6 +1,7 @@
 // "Create parameter 'foo'" "false"
 // ACTION: Create extension property 'foo'
 // ACTION: Create member property 'foo'
+// ACTION: Create property 'foo' as constructor parameter
 // ERROR: Unresolved reference: foo
 
 class A

idea/testData/quickfix/createFromUsage/createVariable/primaryParameter/localValNoReceiver.kt

@@ -0,0 +1,11 @@
+// "Create property 'foo' as constructor parameter" "false"
+// ACTION: Convert to expression body
+// ACTION: Create parameter 'foo'
+// ACTION: Create local variable 'foo'
+// ERROR: Unresolved reference: foo
+
+fun test() {
+    fun nestedTest(): Int {
+        return <caret>foo
+    }
+}

idea/testData/quickfix/createFromUsage/createVariable/primaryParameter/memberValNoReceiver.kt

@@ -0,0 +1,9 @@
+// "Create property 'foo' as constructor parameter" "true"
+
+class A {
+    class B {
+        fun test(): Int {
+            return <caret>foo
+        }
+    }
+}

idea/testData/quickfix/createFromUsage/createVariable/primaryParameter/memberValNoReceiver.kt.after

@@ -0,0 +1,9 @@
+// "Create property 'foo' as constructor parameter" "true"
+
+class A {
+    class B(val foo: Int) {
+        fun test(): Int {
+            return foo
+        }
+    }
+}

idea/testData/quickfix/createFromUsage/createVariable/primaryParameter/memberVarNoReceiver.kt

@@ -0,0 +1,10 @@
+// "Create property 'foo' as constructor parameter" "true"
+
+class A {
+    class B {
+        fun test(): Int {
+            <caret>foo = 1
+            return foo
+        }
+    }
+}

idea/testData/quickfix/createFromUsage/createVariable/primaryParameter/memberVarNoReceiver.kt.after

@@ -0,0 +1,10 @@
+// "Create property 'foo' as constructor parameter" "true"
+
+class A {
+    class B(var foo: Int) {
+        fun test(): Int {
+            <caret>foo = 1
+            return foo
+        }
+    }
+}

idea/testData/quickfix/createFromUsage/createVariable/primaryParameter/objectMemberValNoReceiver.kt

@@ -0,0 +1,14 @@
+// "Create property 'foo' as constructor parameter" "false"
+// ACTION: Convert to expression body
+// ACTION: Create local variable 'foo'
+// ACTION: Create parameter 'foo'
+// ACTION: Create property 'foo'
+// ERROR: Unresolved reference: foo
+
+class A {
+    object B {
+        fun test(): Int {
+            return <caret>foo
+        }
+    }
+}

idea/testData/quickfix/createFromUsage/createVariable/primaryParameter/staticValOnJavaClass.before.Dependency.java

@@ -0,0 +1,3 @@
+class J {
+
+}

idea/testData/quickfix/createFromUsage/createVariable/primaryParameter/staticValOnJavaClass.before.Main.kt

@@ -0,0 +1,8 @@
+// "Create member property 'foo' as constructor parameter" "false"
+// ACTION: Create member property 'foo'
+// ERROR: Unresolved reference: foo
+
+fun test() {
+    val a: Int = J.<caret>foo
+}
+

idea/testData/quickfix/createFromUsage/createVariable/primaryParameter/thisInClass.kt

@@ -0,0 +1,7 @@
+// "Create property 'foo' as constructor parameter" "true"
+
+class A<T>(val n: T) {
+    fun test(): A<Int> {
+        return this.<caret>foo
+    }
+}

idea/testData/quickfix/createFromUsage/createVariable/primaryParameter/thisInClass.kt.after

@@ -0,0 +1,7 @@
+// "Create property 'foo' as constructor parameter" "true"
+
+class A<T>(val n: T, val foo: A<Int>) {
+    fun test(): A<Int> {
+        return this.foo
+    }
+}

idea/testData/quickfix/createFromUsage/createVariable/primaryParameter/thisInExtension.kt

@@ -0,0 +1,7 @@
+// "Create property 'foo' as constructor parameter" "true"
+
+class A<T>(val n: T)
+
+fun <U> A<U>.test(): A<Int> {
+    return this.<caret>foo
+}

idea/testData/quickfix/createFromUsage/createVariable/primaryParameter/thisInExtension.kt.after

@@ -0,0 +1,7 @@
+// "Create property 'foo' as constructor parameter" "true"
+
+class A<T>(val n: T, val foo: A<Int>)
+
+fun <U> A<U>.test(): A<Int> {
+    return this.<caret>foo
+}

idea/testData/quickfix/createFromUsage/createVariable/primaryParameter/thisInNestedClass1.kt

@@ -0,0 +1,9 @@
+// "Create property 'foo' as constructor parameter" "true"
+
+class A<T>(val n: T) {
+    inner class B<U>(val m: U) {
+        fun test(): A<Int> {
+            return this.<caret>foo
+        }
+    }
+}

idea/testData/quickfix/createFromUsage/createVariable/primaryParameter/thisInNestedClass1.kt.after

@@ -0,0 +1,9 @@
+// "Create property 'foo' as constructor parameter" "true"
+
+class A<T>(val n: T) {
+    inner class B<U>(val m: U, val foo: A<Int>) {
+        fun test(): A<Int> {
+            return this.foo
+        }
+    }
+}

idea/testData/quickfix/createFromUsage/createVariable/primaryParameter/thisInNestedClass2.kt

@@ -0,0 +1,9 @@
+// "Create property 'foo' as constructor parameter" "true"
+
+class A<T>(val n: T) {
+    inner class B<U>(val m: U) {
+        fun test(): A<Int> {
+            return this@A.<caret>foo
+        }
+    }
+}

idea/testData/quickfix/createFromUsage/createVariable/primaryParameter/thisInNestedClass2.kt.after

@@ -0,0 +1,9 @@
+// "Create property 'foo' as constructor parameter" "true"
+
+class A<T>(val n: T, val foo: A<Int>) {
+    inner class B<U>(val m: U) {
+        fun test(): A<Int> {
+            return this@A.foo
+        }
+    }
+}

idea/testData/quickfix/createFromUsage/createVariable/primaryParameter/topLevelValNoReceiver.kt

@@ -0,0 +1,10 @@
+// "Create property 'foo' as constructor parameter" "false"
+// ACTION: Create property 'foo'
+// ACTION: Convert to expression body
+// ACTION: Create local variable 'foo'
+// ACTION: Create parameter 'foo'
+// ERROR: Unresolved reference: foo
+
+fun test(): Int {
+    return <caret>foo
+}

idea/testData/quickfix/createFromUsage/createVariable/primaryParameter/valOnCompanionObject.kt

@@ -0,0 +1,14 @@
+// "Create member property 'foo' as constructor parameter" "false"
+// ACTION: Create member property 'foo'
+// ACTION: Create extension property 'foo'
+// ERROR: Unresolved reference: foo
+
+class A<T>(val n: T) {
+    companion object {
+
+    }
+}
+
+fun test() {
+    val a: Int = A.<caret>foo
+}

idea/testData/quickfix/createFromUsage/createVariable/primaryParameter/valOnJavaType.before.Dependency.java

@@ -0,0 +1,3 @@
+class A {
+
+}

idea/testData/quickfix/createFromUsage/createVariable/primaryParameter/valOnJavaType.before.Main.kt

@@ -0,0 +1,9 @@
+// "Create property 'foo' as constructor parameter" "false"
+// ACTION: Create member property 'foo'
+// ACTION: Convert to expression body
+// ACTION: Create extension property 'foo'
+// ERROR: Unresolved reference: foo
+
+fun test(): String? {
+    return A().<caret>foo
+}

idea/testData/quickfix/createFromUsage/createVariable/primaryParameter/valOnLibType.kt

@@ -0,0 +1,9 @@
+// "Create property 'foo' as constructor parameter" "false"
+// ACTION: Create extension property 'foo'
+// ERROR: Unresolved reference: foo
+
+class A<T>(val n: T)
+
+fun test() {
+    val a: A<Int> = 2.<caret>foo
+}

idea/testData/quickfix/createFromUsage/createVariable/primaryParameter/valOnUserType.kt

@@ -0,0 +1,8 @@
+// "Create property 'foo' as constructor parameter" "true"
+// ERROR: No value passed for parameter foo
+
+class A<T>(val n: T)
+
+fun test() {
+    val a: A<Int> = A(1).<caret>foo
+}

idea/testData/quickfix/createFromUsage/createVariable/primaryParameter/valOnUserType.kt.after

@@ -0,0 +1,8 @@
+// "Create property 'foo' as constructor parameter" "true"
+// ERROR: No value passed for parameter foo
+
+class A<T>(val n: T, val foo: A<Int>)
+
+fun test() {
+    val a: A<Int> = A(1, ).foo
+}

idea/testData/quickfix/createFromUsage/createVariable/primaryParameter/varOnUserType.kt

@@ -0,0 +1,8 @@
+// "Create property 'foo' as constructor parameter" "true"
+// ERROR: No value passed for parameter foo
+
+class A<T>(val n: T)
+
+fun test() {
+    A(1).<caret>foo = "1"
+}

idea/testData/quickfix/createFromUsage/createVariable/primaryParameter/varOnUserType.kt.after

@@ -0,0 +1,8 @@
+// "Create property 'foo' as constructor parameter" "true"
+// ERROR: No value passed for parameter foo
+
+class A<T>(val n: T, var foo: String)
+
+fun test() {
+    A(1, ).foo = "1"
+}