Refactoring: make "replace get or set" an inspection

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/.inspection

@@ -0,0 +1 @@
+org.jetbrains.kotlin.idea.inspections.conventionNameCalls.ReplaceGetOrSetInspection

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/acceptableVararg.kt

@@ -0,0 +1,7 @@
+fun test() {
+    class Test{
+        operator fun get(a: Int, vararg b: Int, c: Int = 0) : Int = 0
+    }
+    val test = Test()
+    test.g<caret>et(1, 3, 4, 5)
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/acceptableVararg.kt.after

@@ -0,0 +1,7 @@
+fun test() {
+    class Test{
+        operator fun get(a: Int, vararg b: Int, c: Int = 0) : Int = 0
+    }
+    val test = Test()
+    test<caret>[1, 3, 4, 5]
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/argumentAndFunction.kt

@@ -0,0 +1,20 @@
+fun test() {
+    class Test{
+        operator fun get(a: Int, b: Int, fn: (i: Int) -> Int) : Int = 0
+    }
+    val test = Test()
+    test.g<caret>et(1, 2) { i ->
+        i
+    }
+}
+
+fun withSuppression() {
+    class Test{
+        operator fun get(a: Int, b: Int, fn: (i: Int) -> Int) : Int = 0
+    }
+
+    val test = Test()
+
+    @Suppress("ReplaceGetOrSet")
+    test.get(1, 2) { i -> i }
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/argumentAndFunction.kt.after

@@ -0,0 +1,20 @@
+fun test() {
+    class Test{
+        operator fun get(a: Int, b: Int, fn: (i: Int) -> Int) : Int = 0
+    }
+    val test = Test()
+    test<caret>[1, 2, { i ->
+        i
+    }]
+}
+
+fun withSuppression() {
+    class Test{
+        operator fun get(a: Int, b: Int, fn: (i: Int) -> Int) : Int = 0
+    }
+
+    val test = Test()
+
+    @Suppress("ReplaceGetOrSet")
+    test.get(1, 2) { i -> i }
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/duplicateArguments.kt

@@ -0,0 +1,10 @@
+// PROBLEM: none
+// ERROR: An argument is already passed for this parameter
+// ERROR: No value passed for parameter 'b'
+fun test() {
+    class Test{
+        operator fun get(a: Int, b: Int) : Int = 0
+    }
+    val test = Test()
+    test.g<caret>et(a=0, a=1)
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/extensionFunction.kt

@@ -0,0 +1,8 @@
+fun test() {
+    class Test()
+
+    operator fun Test.get(i: Int) : Int = 0
+
+    val test = Test()
+    test.g<caret>et(0)
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/extensionFunction.kt.after

@@ -0,0 +1,8 @@
+fun test() {
+    class Test()
+
+    operator fun Test.get(i: Int) : Int = 0
+
+    val test = Test()
+    test<caret>[0]
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/functionalArgument.kt

@@ -0,0 +1,9 @@
+fun test() {
+    class Test{
+        operator fun get(fn: (i: Int) -> Int) : Int = 0
+    }
+    val test = Test()
+    test.g<caret>et() { i ->
+        i
+    }
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/functionalArgument.kt.after

@@ -0,0 +1,9 @@
+fun test() {
+    class Test{
+        operator fun get(fn: (i: Int) -> Int) : Int = 0
+    }
+    val test = Test()
+    test<caret>[{ i ->
+        i
+    }]
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/inspectionData/expected.xml

@@ -0,0 +1,82 @@
+<problems>
+  <problem>
+    <file>singleArgument.kt</file>
+    <line>8</line>
+    <module>light_idea_test_case</module>
+    <entry_point TYPE="file" FQNAME="singleArgument.kt" />
+    <problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Explicit 'get' or 'set' call</problem_class>
+    <description>Call replaceable with indexing operator</description>
+  </problem>
+
+  <problem>
+    <file>multiArgument.kt</file>
+    <line>6</line>
+    <module>light_idea_test_case</module>
+    <entry_point TYPE="file" FQNAME="multiArgument.kt" />
+    <problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Explicit 'get' or 'set' call</problem_class>
+    <description>Call replaceable with indexing operator</description>
+  </problem>
+
+  <problem>
+    <file>functionalArgument.kt</file>
+    <line>6</line>
+    <module>light_idea_test_case</module>
+    <entry_point TYPE="file" FQNAME="functionalArgument.kt" />
+    <problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Explicit 'get' or 'set' call</problem_class>
+    <description>Call replaceable with indexing operator</description>
+  </problem>
+
+  <problem>
+    <file>extensionFunction.kt</file>
+    <line>7</line>
+    <module>light_idea_test_case</module>
+    <entry_point TYPE="file" FQNAME="extensionFunction.kt" />
+    <problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Explicit 'get' or 'set' call</problem_class>
+    <description>Call replaceable with indexing operator</description>
+  </problem>
+
+  <problem>
+    <file>argumentAndFunction.kt</file>
+    <line>6</line>
+    <module>light_idea_test_case</module>
+    <entry_point TYPE="file" FQNAME="argumentAndFunction.kt" />
+    <problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Explicit 'get' or 'set' call</problem_class>
+    <description>Call replaceable with indexing operator</description>
+  </problem>
+
+  <problem>
+    <file>acceptableVararg.kt</file>
+    <line>6</line>
+    <module>light_idea_test_case</module>
+    <entry_point TYPE="file" FQNAME="acceptableVararg.kt" />
+    <problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Explicit 'get' or 'set' call</problem_class>
+    <description>Call replaceable with indexing operator</description>
+  </problem>
+
+  <problem>
+    <file>qualifier.kt</file>
+    <line>8</line>
+    <module>light_idea_test_case</module>
+    <entry_point TYPE="file" FQNAME="qualifier.kt" />
+    <problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Explicit 'get' or 'set' call</problem_class>
+    <description>Call replaceable with indexing operator</description>
+  </problem>
+
+  <problem>
+    <file>set.kt</file>
+    <line>8</line>
+    <module>light_idea_test_case</module>
+    <entry_point TYPE="file" FQNAME="set.kt" />
+    <problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Explicit 'get' or 'set' call</problem_class>
+    <description>Call replaceable with indexing operator</description>
+  </problem>
+
+  <problem>
+    <file>set2.kt</file>
+    <line>9</line>
+    <module>light_idea_test_case</module>
+    <entry_point TYPE="file" FQNAME="set2.kt" />
+    <problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Explicit 'get' or 'set' call</problem_class>
+    <description>Call replaceable with indexing operator</description>
+  </problem>
+</problems>

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/inspectionData/inspections.test

@@ -0,0 +1 @@
+// INSPECTION_CLASS: org.jetbrains.kotlin.idea.inspections.conventionNameCalls.ReplaceGetOrSetInspection

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/invalidArgument.kt

@@ -0,0 +1,9 @@
+// PROBLEM: none
+// ERROR: Cannot find a parameter with this name: c
+fun test() {
+    class Test{
+        operator fun get(a: Int=1, b: Int=2) : Int = 0
+    }
+    val test = Test()
+    test.g<caret>et(c=3)
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/missingDefaultArgument.kt

@@ -0,0 +1,8 @@
+// PROBLEM: none
+fun test() {
+    class Test{
+        operator fun get(a: Int=1, b: Int=2) : Int = 0
+    }
+    val test = Test()
+    test.g<caret>et(b=3)
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/multiArgument.kt

@@ -0,0 +1,7 @@
+fun test() {
+    class Test{
+        operator fun get(a: Int, b: Int) : Int = 0
+    }
+    val test = Test()
+    test.g<caret>et(1, 2)
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/multiArgument.kt.after

@@ -0,0 +1,7 @@
+fun test() {
+    class Test{
+        operator fun get(a: Int, b: Int) : Int = 0
+    }
+    val test = Test()
+    test<caret>[1, 2]
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/noArgument.kt

@@ -0,0 +1,9 @@
+// PROBLEM: none
+// ERROR: 'operator' modifier is inapplicable on this function: must have at least 1 value parameter
+fun test() {
+    class Test{
+        operator fun get() : Int = 0
+    }
+    val test = Test()
+    test.g<caret>et()
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/notOperator.kt

@@ -0,0 +1,10 @@
+// PROBLEM: none
+package p
+
+class C
+
+fun C.get(s: String) = s
+
+fun foo(c: C) {
+    c.<caret>get("x")
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/qualifier.kt

@@ -0,0 +1,9 @@
+class C {
+    companion object {
+        operator fun get(s: String): C = C()
+    }
+}
+
+fun foo() {
+    C.<caret>get("x")
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/qualifier.kt.after

@@ -0,0 +1,9 @@
+class C {
+    companion object {
+        operator fun get(s: String): C = C()
+    }
+}
+
+fun foo() {
+    C<caret>["x"]
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/sanityCheck.kt

@@ -0,0 +1,9 @@
+// PROBLEM: none
+// ERROR: Unresolved reference: got
+fun test() {
+    class Test{
+        operator fun get(i: Int) : Int = 0
+    }
+    val test = Test()
+    test.g<caret>ot(0)
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/set.kt

@@ -0,0 +1,9 @@
+// FIX: Replace 'set' call with indexing operator
+
+class C {
+    operator fun set(s: String, value: Int) {}
+}
+
+fun foo() {
+    C().<caret>set("x", 1)
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/set.kt.after

@@ -0,0 +1,9 @@
+// FIX: Replace 'set' call with indexing operator
+
+class C {
+    operator fun set(s: String, value: Int) {}
+}
+
+fun foo() {
+    C()<caret>["x"] = 1
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/set2.kt

@@ -0,0 +1,11 @@
+// FIX: Replace 'set' call with indexing operator
+
+class C {
+    operator fun set(s: String, p: Int, value: Int): Boolean = true
+}
+
+class D(val c: C) {
+    fun foo() {
+        this.c.<caret>set("x", 2, 1)
+    }
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/set2.kt.after

@@ -0,0 +1,11 @@
+// FIX: Replace 'set' call with indexing operator
+
+class C {
+    operator fun set(s: String, p: Int, value: Int): Boolean = true
+}
+
+class D(val c: C) {
+    fun foo() {
+        this.c<caret>["x", 2] = 1
+    }
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/setValueUsed.kt

@@ -0,0 +1,11 @@
+// PROBLEM: none
+
+class C {
+    operator fun set(s: String, value: Int): Boolean = true
+}
+
+class D(val c: C) {
+    fun foo(): Boolean {
+        return this.c.<caret>set("x", 1)
+    }
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/setWithNoParameters.kt

@@ -0,0 +1,12 @@
+// PROBLEM: none
+// ERROR: 'operator' modifier is inapplicable on this function: must have at least 2 value parameters
+
+class C {
+    operator fun set(){}
+}
+
+class D(val c: C) {
+    fun foo() {
+        this.c.<caret>set()
+    }
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/setWithVararg.kt

@@ -0,0 +1,12 @@
+// PROBLEM: none
+// ERROR: 'operator' modifier is inapplicable on this function: last parameter should not have a default value or be a vararg
+
+class C {
+    operator fun set(s: String, vararg value: Int): Boolean = true
+}
+
+class D(val c: C) {
+    fun foo() {
+        this.c.<caret>set("x", 1, 2)
+    }
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/singleArgument.kt

@@ -0,0 +1,9 @@
+// FIX: Replace 'get' call with indexing operator
+
+fun test() {
+    class Test{
+        operator fun get(i: Int) : Int = 0
+    }
+    val test = Test()
+    test.g<caret>et(0)
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/singleArgument.kt.after

@@ -0,0 +1,9 @@
+// FIX: Replace 'get' call with indexing operator
+
+fun test() {
+    class Test{
+        operator fun get(i: Int) : Int = 0
+    }
+    val test = Test()
+    test<caret>[0]
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/staticMethod.1.java

@@ -0,0 +1,5 @@
+class JavaClass {
+    public static JavaClass get(JavaClass s) {
+        return s;
+    }
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/staticMethod.kt

@@ -0,0 +1,4 @@
+// PROBLEM: none
+fun foo() {
+    JavaClass.<caret>get(JavaClass())
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/super.kt

@@ -0,0 +1,11 @@
+// PROBLEM: none
+
+open class Base {
+    open operator fun get(s: String) = ""
+}
+
+class C : Base() {
+    override fun get(s: String): String {
+        return super.<caret>get(s)
+    }
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/topLevelFun.kt

@@ -0,0 +1,10 @@
+// PROBLEM: none
+// ERROR: 'operator' modifier is inapplicable on this function: must be a member or an extension function
+
+package p
+
+operator fun get(s: String) = s
+
+fun foo() {
+    p.<caret>get("x")
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/unacceptableVararg.kt

@@ -0,0 +1,8 @@
+// PROBLEM: none
+fun test() {
+    class Test{
+        operator fun get(a: Int, vararg b: Int, c: Int = 0) : Int = 0
+    }
+    val test = Test()
+    test.g<caret>et(1, 3, 4, c=5)
+}

idea/testData/inspectionsLocal/conventionNameCalls/replaceGetOrSet/unnamedAndNamed.kt

@@ -0,0 +1,8 @@
+// PROBLEM: none
+fun test() {
+    class Test{
+        operator fun get(a: Int = 0, b: Int = 1, c: Int = 2, d: Int = 3) : Int = 0
+    }
+    val test = Test()
+    test.g<caret>et(1, c=3, b=2)
+}