[FIR IDE] Properly support loop variables in KtFirSymbolProvider

analysis/analysis-api-fir/src/org/jetbrains/kotlin/analysis/api/fir/symbols/KtFirSymbolProvider.kt

@@ -35,12 +35,19 @@ internal class KtFirSymbolProvider(
 ) : KtSymbolProvider(), ValidityTokenOwner {
     private val firSymbolProvider by weakRef(firSymbolProvider)
 
-    override fun getParameterSymbol(psi: KtParameter): KtValueParameterSymbol = withValidityAssertion {
-        if (psi.isFunctionTypeParameter) {
-            error("Creating KtValueParameterSymbol for function type parameter is not possible. Please see the KDoc of getParameterSymbol")
-        }
-        psi.withFirDeclarationOfType<FirValueParameter, KtValueParameterSymbol>(resolveState) {
-            firSymbolBuilder.variableLikeBuilder.buildValueParameterSymbol(it)
+    override fun getParameterSymbol(psi: KtParameter): KtVariableLikeSymbol = withValidityAssertion {
+        when {
+            psi.isFunctionTypeParameter -> error(
+                "Creating KtValueParameterSymbol for function type parameter is not possible. Please see the KDoc of getParameterSymbol"
+            )
+
+            psi.isLoopParameter -> psi.withFirDeclarationOfType<FirProperty, KtLocalVariableSymbol>(resolveState) {
+                firSymbolBuilder.variableLikeBuilder.buildLocalVariableSymbol(it)
+            }
+
+            else -> psi.withFirDeclarationOfType<FirValueParameter, KtValueParameterSymbol>(resolveState) {
+                firSymbolBuilder.variableLikeBuilder.buildValueParameterSymbol(it)
+            }
         }
     }
 

analysis/analysis-api-fir/tests/org/jetbrains/kotlin/analysis/api/fir/symbols/SymbolByPsiTestGenerated.java

@@ -102,6 +102,12 @@ public class SymbolByPsiTestGenerated extends AbstractSymbolByPsiTest {
         runTest("analysis/analysis-api/testData/symbols/symbolByPsi/extensionFunction.kt");
     }
 
+    @Test
+    @TestMetadata("forLoopVariable.kt")
+    public void testForLoopVariable() throws Exception {
+        runTest("analysis/analysis-api/testData/symbols/symbolByPsi/forLoopVariable.kt");
+    }
+
     @Test
     @TestMetadata("function.kt")
     public void testFunction() throws Exception {