azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Gradle][MPP] KMP <-> AGP compatibility check: Weaken warning when AGP is too high

Browse Source 
^KT-53138 Verification Pending
This commit is contained in:
sebastian.sellmair
2022-07-22 13:57:29 +02:00
committed by Space
parent 2143180b40
commit 90a2141f1c
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/plugin/KotlinMultiplatformAndroidGradlePluginCompatibilityHealthCheck.kt
+4 -3
View File
@@ -147,7 +147,6 @@ internal object KotlinMultiplatformAndroidGradlePluginCompatibilityHealthCheck {
val androidGradlePluginVersion = androidGradlePluginVersionParser.parseVersionString(androidGradlePluginVersionString) val androidGradlePluginVersion = androidGradlePluginVersionParser.parseVersionString(androidGradlePluginVersionString)
?: return warningLogger(Messages.failedParsingAndroidGradlePluginVersion(androidGradlePluginVersionString)) ?: return warningLogger(Messages.failedParsingAndroidGradlePluginVersion(androidGradlePluginVersionString))
if (compatibleAndroidGradlePluginVersionRange.isTooLow(androidGradlePluginVersion)) { if (compatibleAndroidGradlePluginVersionRange.isTooLow(androidGradlePluginVersion)) {
warningLogger(Messages.androidGradlePluginVersionTooLow(androidGradlePluginVersionString)) warningLogger(Messages.androidGradlePluginVersionTooLow(androidGradlePluginVersionString))
} }
@@ -168,7 +167,9 @@ internal object KotlinMultiplatformAndroidGradlePluginCompatibilityHealthCheck {
) )
fun androidGradlePluginVersionTooHigh(androidGradlePluginVersionString: String) = createCompatibilityWarningMessage( fun androidGradlePluginVersionTooHigh(androidGradlePluginVersionString: String) = createCompatibilityWarningMessage(
"The applied Android Gradle Plugin version ($androidGradlePluginVersionString) is higher than the maximum supported" "The applied Android Gradle Plugin version ($androidGradlePluginVersionString) " +
"is higher than the maximum known to the Kotlin Gradle Plugin. " +
"Tooling stability in such configuration isn't tested, please report encountered issues to kotl.in/issue"
) )
private fun createCompatibilityWarningMessage(warning: String) = buildString { private fun createCompatibilityWarningMessage(warning: String) = buildString {
@@ -179,7 +180,7 @@ internal object KotlinMultiplatformAndroidGradlePluginCompatibilityHealthCheck {
"${compatibleAndroidGradlePluginVersionRange.minSupportedVersion.minor}" "${compatibleAndroidGradlePluginVersionRange.minSupportedVersion.minor}"
) )
appendLine( appendLine(
"Maximum supported Android Gradle Plugin version: " + "Maximum tested Android Gradle Plugin version: " +
"${compatibleAndroidGradlePluginVersionRange.maxSupportedVersionMajor}." + "${compatibleAndroidGradlePluginVersionRange.maxSupportedVersionMajor}." +
"${compatibleAndroidGradlePluginVersionRange.maxSupportedVersionMinor ?: "*"}" "${compatibleAndroidGradlePluginVersionRange.maxSupportedVersionMinor ?: "*"}"
) )