[Jspecify] Move jspecify test runner under the new tests infrastructure

This commit is contained in:
Victor Petukhov
2021-04-05 17:59:03 +03:00
parent 6f9694174f
commit 8f097b14cc
8 changed files with 182 additions and 339 deletions
@@ -1,173 +0,0 @@
/*
* Copyright 2010-2020 JetBrains s.r.o. and Kotlin Programming Language contributors.
* Use of this source code is governed by the Apache 2.0 license that can be found in the license/LICENSE.txt file.
*/
package org.jetbrains.kotlin.checkers
import com.intellij.openapi.util.io.FileUtil
import org.jetbrains.kotlin.ObsoleteTestInfrastructure
import org.jetbrains.kotlin.checkers.utils.CheckerTestUtil
import org.jetbrains.kotlin.resolve.jvm.diagnostics.ErrorsJvm
import org.jetbrains.kotlin.test.MockLibraryUtilExt
import java.io.File
import java.util.*
import java.util.regex.Pattern
import kotlin.io.path.ExperimentalPathApi
import kotlin.io.path.createTempFile
import kotlin.io.path.writeText
const val JSPECIFY_NULLNESS_MISMATCH_MARK = "jspecify_nullness_mismatch"
const val JSPECIFY_NULLABLE_ANNOTATION = "@Nullable"
const val JSPECIFY_NULLNESS_UNSPECIFIED_ANNOTATION = "@NullnessUnspecified"
@OptIn(ObsoleteTestInfrastructure::class)
abstract class AbstractJspecifyAnnotationsTest : AbstractDiagnosticsTest() {
override fun doMultiFileTest(
wholeFile: File,
files: List<TestFile>
) {
super.doMultiFileTest(
wholeFile,
files,
MockLibraryUtilExt.compileJavaFilesLibraryToJar(FOREIGN_JDK8_ANNOTATIONS_SOURCES_PATH, "foreign-annotations"),
usePsiClassFilesReading = false,
excludeNonTypeUseJetbrainsAnnotations = true
)
}
@OptIn(ExperimentalPathApi::class)
override fun doTest(filePath: String) {
val ktSourceCode = File(filePath).readText()
val javaSourcesFilename = javaSourcesPathRegex.matcher(ktSourceCode).also { it.find() }.group(1)
?: throw Exception("Java sources' path not found")
val javaSourcesFile = File("$JSPECIFY_JAVA_SOURCES_PATH/$javaSourcesFilename")
val mergedSourceCode = buildString {
appendLine("// ORIGINAL_KT_FILE: $filePath")
if (javaSourcesFilename.endsWith(".java")) {
appendLine(makeJavaClassesPublicAndSeparatedByFiles(javaSourcesFile.readText()))
} else {
assert(javaSourcesFile.isDirectory) { "Specified Java sources should be a file with `java` extension or directory" }
for (javaFile in javaSourcesFile.walkTopDown().filter { it.isFile && it.extension == "java" }) {
appendLine("// FILE: ${javaFile.name}")
appendLine(makeJavaClassesPublicAndSeparatedByFiles(javaFile.readText()))
}
}
appendLine("// FILE: main.kt\n$ktSourceCode")
}
super.doTest(createTempFile().apply { writeText(mergedSourceCode) }.toString())
}
private fun makeJavaClassesPublicAndSeparatedByFiles(javaCode: String): String {
val importSectionMatch = importSectionRegex.find(javaCode)
val importSection = if (importSectionMatch != null) "\n${importSectionMatch.groups[1]!!.value}\n" else ""
return javaCode.replace(importSectionRegex, "")
.replace(publicClassOrInterfaceRegex, "$1")
.replace(classOrInterfaceRegex, "public $1")
.replace(classShapeRegex, "\n// FILE: $3.java$importSection$1\npublic $2 $3$4")
}
private fun getJspecifyMarkRegex(jspecifyMark: String) = Regex("""^\s*// $jspecifyMark$""")
private fun checkIfAllJspecifyMarksByDiagnosticsArePresent(
diagnosedRanges: List<DiagnosedRange>,
lineIndexesByRanges: TreeMap<Int, Int>,
textLines: List<String>
) {
for (diagnosticRange in diagnosedRanges) {
val lineIndex = lineIndexesByRanges.floorEntry(diagnosticRange.start).value
for (diagnostic in diagnosticRange.getDiagnostics()) {
val requiredJspecifyMark = diagnosticsToJspecifyMarksMap[diagnostic.name] ?: continue
fun getErrorMessage(lineIndex: Int) =
"Jspecify mark '$requiredJspecifyMark' not found for diagnostic '${diagnostic}' at ${lineIndex + 1} line.\n" +
"It should be located at the previous line as a comment."
assert(lineIndex != 0) { getErrorMessage(0) }
val previousLine = textLines[lineIndex - 1]
assert(getJspecifyMarkRegex(requiredJspecifyMark).matches(previousLine)) { getErrorMessage(lineIndex) }
}
}
}
private fun checkIfAllDiagnosticsByJspecifyMarksArePresent(
diagnosedRanges: List<DiagnosedRange>,
lineIndexesByRanges: TreeMap<Int, Int>,
textLines: List<String>
) {
for ((diagnosticName, jspecifyMark) in diagnosticsToJspecifyMarksMap) {
val diagnosticRanges = diagnosedRanges.filter { diagnostics ->
diagnosticName in diagnostics.getDiagnostics().map { it.name }
}.map { it.start }
val lineIndexesWithJspecifyMarks =
textLines.mapIndexedNotNull { index, it -> getJspecifyMarkRegex(jspecifyMark).find(it)?.let { index } }
for (lineIndex in lineIndexesWithJspecifyMarks) {
val lineStartPosition = lineIndexesByRanges.entries.find { (_, index) -> index == lineIndex + 1 }?.key
val errorMessage = "Diagnostic '$diagnosticName' not found for jspecify mark '$jspecifyMark' at ${lineIndex + 1} line"
assertNotNull(errorMessage, lineStartPosition)
val lineEndPosition = lineStartPosition!! + textLines[lineIndex].length
val isCorrespondingDiagnosticPresent = diagnosticRanges.any { it in lineStartPosition..lineEndPosition }
assertTrue(errorMessage, isCorrespondingDiagnosticPresent)
}
}
}
override fun checkDiagnostics(actualText: String, testDataFile: File) {
val mergedTestFilePath = originalKtFileRegex.matcher(actualText).also { it.find() }.group(1)
?: throw Exception("Path for original kt file in the merged file not found")
val textWithDiagnostics = actualText.substringAfter(MAIN_KT_FILE_DIRECTIVE).removeSuffix("\n")
val diagnosedRanges = mutableListOf<DiagnosedRange>()
val textWithoutDiagnostics = CheckerTestUtil.parseDiagnosedRanges(textWithDiagnostics, diagnosedRanges)
val textLines = textWithoutDiagnostics.lines()
val lineIndexesByRanges = TreeMap<Int, Int>().apply {
textLines.scanIndexed(0) { index, position, line ->
put(position, index)
position + line.length + 1 // + new line symbol
}
}
checkIfAllJspecifyMarksByDiagnosticsArePresent(diagnosedRanges, lineIndexesByRanges, textLines)
checkIfAllDiagnosticsByJspecifyMarksArePresent(diagnosedRanges, lineIndexesByRanges, textLines)
super.checkDiagnostics(textWithDiagnostics, File(mergedTestFilePath))
}
override fun getExpectedDescriptorFile(testDataFile: File, files: List<TestFile>): File {
val originalKtFilePath = originalKtFileRegex.matcher(testDataFile.readText()).also { it.find() }.group(1)
?: throw Exception("Path for original kt file in the merged file isn't found")
return File(FileUtil.getNameWithoutExtension(originalKtFilePath) + ".txt")
}
companion object {
const val JSPECIFY_JAVA_SOURCES_PATH = "compiler/testData/foreignAnnotationsJava8/tests/jspecify/java"
const val MAIN_KT_FILE_DIRECTIVE = "// FILE: main.kt\n"
private val originalKtFileRegex = Pattern.compile("""// ORIGINAL_KT_FILE: (.*?\.kts?)\n""")
private val javaSourcesPathRegex = Pattern.compile("""// JAVA_SOURCES: (.*?(?:\.java)?)\n""")
val diagnosticsToJspecifyMarksMap = mapOf(
ErrorsJvm::NULLABILITY_MISMATCH_BASED_ON_JAVA_ANNOTATIONS.name to JSPECIFY_NULLNESS_MISMATCH_MARK
)
private val importSectionRegex = Regex("""((?:import .*?;\n)+)""")
private val classOrInterfaceRegex = Regex("""(class|interface)""")
private val publicClassOrInterfaceRegex = Regex("""public (class|interface)""")
private val classShapeRegex = Regex("""(\n@NullMarked)?\npublic (class|interface) (\w+)(<[^>]+>)?""")
}
}