From 8e9536f61d118a4c70eaa004f33a1a258cf80be6 Mon Sep 17 00:00:00 2001 From: Yan Zhulanow Date: Tue, 14 Feb 2017 20:51:02 +0300 Subject: [PATCH] Revert "Kapt3: Add generated source files to Java compile task after kapt execution. Filter only .java files." This reverts commit 82c2ce3a336b8d15161ecb6dbad0c269c9966818. --- .../kotlin/gradle/internal/Kapt3KotlinGradleSubplugin.kt | 4 +++- .../kotlin/org/jetbrains/kotlin/gradle/internal/KaptTask.kt | 5 ++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/internal/Kapt3KotlinGradleSubplugin.kt b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/internal/Kapt3KotlinGradleSubplugin.kt index f9e21c8d96b..d4776b66a88 100644 --- a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/internal/Kapt3KotlinGradleSubplugin.kt +++ b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/internal/Kapt3KotlinGradleSubplugin.kt @@ -160,6 +160,8 @@ class Kapt3KotlinGradleSubplugin : KotlinGradleSubplugin { kaptClasspath.forEach { pluginOptions += SubpluginOption("apclasspath", it.absolutePath) } + javaCompile.source(generatedFilesDir) + pluginOptions += SubpluginOption("sources", generatedFilesDir.canonicalPath) pluginOptions += SubpluginOption("classes", getKaptClasssesDir(project, sourceSetName).canonicalPath) @@ -218,7 +220,6 @@ class Kapt3KotlinGradleSubplugin : KotlinGradleSubplugin { val kaptTaskName = kotlinCompile.name.replaceFirst("compile", "kapt") val kaptTask = project.tasks.create(kaptTaskName, KaptTask::class.java) kaptTask.kotlinCompileTask = kotlinCompile - kaptTask.javaCompileTask = javaCompile kotlinToKaptTasksMap[kotlinCompile] = kaptTask project.resolveSubpluginArtifacts(listOf(this@Kapt3KotlinGradleSubplugin)).flatMap { it.value }.forEach { @@ -233,6 +234,7 @@ class Kapt3KotlinGradleSubplugin : KotlinGradleSubplugin { // Add generated source dir as a source root for kotlinCompile and javaCompile kotlinCompile.source(sourcesOutputDir) + javaCompile.source(sourcesOutputDir) variantData?.let { if (AndroidGradleWrapper.isJackEnabled(it)) { AndroidGradleWrapper.addSourceToJack(it, sourcesOutputDir) diff --git a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/internal/KaptTask.kt b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/internal/KaptTask.kt index 22610651d9c..c0bdf5f365d 100644 --- a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/internal/KaptTask.kt +++ b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/internal/KaptTask.kt @@ -15,6 +15,8 @@ import org.jetbrains.kotlin.gradle.tasks.* import org.jetbrains.kotlin.incremental.classpathAsList import org.jetbrains.kotlin.incremental.destinationAsFile import java.io.File +import java.net.URLDecoder +import java.nio.charset.Charset open class KaptTask : AbstractCompile() { private val rawSourceRoots = FilteringSourceRootsContainer({ !it.isInsideDestinationDir() }) @@ -22,7 +24,6 @@ open class KaptTask : AbstractCompile() { internal val pluginOptions = CompilerPluginOptions() internal lateinit var kotlinCompileTask: KotlinCompile - internal lateinit var javaCompileTask: AbstractCompile override fun setSource(sources: Any?) { val filteredSources = rawSourceRoots.set(sources) @@ -74,7 +75,5 @@ open class KaptTask : AbstractCompile() { val compilerRunner = GradleCompilerRunner(project) val exitCode = compilerRunner.runJvmCompiler(sourceRoots.kotlinSourceFiles, sourceRoots.javaSourceRoots, args, environment) throwGradleExceptionIfError(exitCode) - - javaCompileTask.source(destinationDir.walkTopDown().filter { it.extension == "java" }.toList()) } } \ No newline at end of file