Convert ReplaceSingleLineLetIntention to inspection & decrease severity to INFORMATION

#KT-32010 Fixed

idea/testData/inspectionsLocal/replaceSingleLineLet/.inspection

@@ -1 +1 @@
-org.jetbrains.kotlin.idea.intentions.ReplaceSingleLineLetInspection
+org.jetbrains.kotlin.idea.inspections.ReplaceSingleLineLetInspection

idea/testData/inspectionsLocal/replaceSingleLineLet/assignment.kt

@@ -1,4 +1,4 @@
-// IS_APPLICABLE: false
+// PROBLEM: none
 // WITH_RUNTIME
 
 fun withAssign(arg: String?): String {

idea/testData/inspectionsLocal/replaceSingleLineLet/binarySafeCall.kt

@@ -1,4 +1,4 @@
-// IS_APPLICABLE: false
+// PROBLEM: none
 // WITH_RUNTIME
 
 val x = 1

idea/testData/inspectionsLocal/replaceSingleLineLet/callChainWithLineBreak.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// PROBLEM: none
+// HIGHLIGHT: INFORMATION
 
 fun test(list: List<Int>) {
     list.filter { it > 1 }

idea/testData/inspectionsLocal/replaceSingleLineLet/callChainWithLineBreak.kt.after

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+// HIGHLIGHT: INFORMATION
+
+fun test(list: List<Int>) {
+    println(list.filter { it > 1 }
+    .filter { it > 2 })
+}

idea/testData/inspectionsLocal/replaceSingleLineLet/comparisons.kt

@@ -1,4 +1,4 @@
-// IS_APPLICABLE: false
+// PROBLEM: none
 // WITH_RUNTIME
 
 fun isAlphaOrBeta(str: String) = str.let<caret> { it == "Alpha" || it == "Beta" }

idea/testData/inspectionsLocal/replaceSingleLineLet/destructuringDeclaration3.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: false
+// PROBLEM: none
 
 fun test() {
     (1 to 2).let<caret> { (i, j) -> foo(i, 3) }

idea/testData/inspectionsLocal/replaceSingleLineLet/destructuringDeclaration4.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: false
+// PROBLEM: none
 
 fun test(k: Int) {
     (1 to 2).let<caret> { (i, j) -> i + k }

idea/testData/inspectionsLocal/replaceSingleLineLet/destructuringDeclaration5.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: false
+// PROBLEM: none
 
 fun test() {
     (1 to 2).let<caret> { (i, j) -> i.toLong() }

idea/testData/inspectionsLocal/replaceSingleLineLet/dotWithComparison.kt

@@ -1,4 +1,4 @@
-// IS_APPLICABLE: false
+// PROBLEM: none
 // WITH_RUNTIME
 
 fun main(args: Array<String>) {

idea/testData/inspectionsLocal/replaceSingleLineLet/functionCall2.kt

@@ -4,5 +4,5 @@ fun foo(s: String, i: Int) = s.length + i
 
 fun test() {
     val s = ""
-    s.let { foo(it, 1)<caret> }
+    s.let<caret> { foo(it, 1) }
 }

idea/testData/inspectionsLocal/replaceSingleLineLet/functionCall7.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: false
+// PROBLEM: none
 
 fun foo(s: String, i: Int) = s.length + i
 

idea/testData/inspectionsLocal/replaceSingleLineLet/functionCallOnSafeCall.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: false
+// PROBLEM: none
 
 fun foo(s: String, i: Int) = s.length + i
 

idea/testData/inspectionsLocal/replaceSingleLineLet/functionInVariableCall.kt

@@ -1,4 +1,4 @@
-// IS_APPLICABLE: false
+// PROBLEM: none
 // WITH_RUNTIME
 class Foo(val bar: () -> Int)
 

idea/testData/inspectionsLocal/replaceSingleLineLet/in.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: true
+
 
 fun foo(list: List<Int>) {
     list.filter { it.let<caret> { it in 1000..3000 } }

idea/testData/inspectionsLocal/replaceSingleLineLet/in.kt.after

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: true
+
 
 fun foo(list: List<Int>) {
     list.filter { it in 1000..3000 }

idea/testData/inspectionsLocal/replaceSingleLineLet/inWithMultipleParam.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: false
+// PROBLEM: none
 
 fun foo(list: List<Int>) {
     list.filter { it.let<caret> { value -> value in value..3000 } }

idea/testData/inspectionsLocal/replaceSingleLineLet/inWithRange.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: true
+
 
 fun foo(list: List<Int>) {
     list.filter { it.let<caret> { it in IntRange(1, 10) } }

idea/testData/inspectionsLocal/replaceSingleLineLet/inWithRange.kt.after

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: true
+
 
 fun foo(list: List<Int>) {
     list.filter { it in IntRange(1, 10) }

idea/testData/inspectionsLocal/replaceSingleLineLet/inWithRangeMultipleParam.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: false
+// PROBLEM: none
 
 fun foo(list: List<Int>) {
     list.filter { it.let<caret> { it in IntRange(it - 1, 10) } }

idea/testData/inspectionsLocal/replaceSingleLineLet/invokeCall4.kt

@@ -1,4 +1,4 @@
-// IS_APPLICABLE: false
+// PROBLEM: none
 // WITH_RUNTIME
 class A {
     operator fun invoke(a: A, i: Int) {}

idea/testData/inspectionsLocal/replaceSingleLineLet/invokeCall5.kt

@@ -1,4 +1,4 @@
-// IS_APPLICABLE: false
+// PROBLEM: none
 // WITH_RUNTIME
 class A {
     operator fun invoke() {}

idea/testData/inspectionsLocal/replaceSingleLineLet/lambdaWithBinaryExpression.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: false
+// PROBLEM: none
 
 fun baz(foo: String) {
     foo.let<caret> { it.indexOfLast { c -> c == it[0] } + 1 }

idea/testData/inspectionsLocal/replaceSingleLineLet/lambdaWithBinaryExpression2.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: false
+// PROBLEM: none
 
 fun baz(foo: String) {
     foo.let<caret> { it.length + "".indexOfLast { c -> c == it[0] } }

idea/testData/inspectionsLocal/replaceSingleLineLet/let.kt

@@ -1,9 +1,9 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: true
+
 
 fun foo() {
     val foo: String? = null
-    foo?.let {
-        it.length<caret>
+    foo?.let<caret> {
+        it.length
     }
 }

idea/testData/inspectionsLocal/replaceSingleLineLet/let.kt.after

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: true
+
 
 fun foo() {
     val foo: String? = null

idea/testData/inspectionsLocal/replaceSingleLineLet/letMultipleLines.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: false
+// PROBLEM: none
 
 fun foo() {
     val foo: String? = null

idea/testData/inspectionsLocal/replaceSingleLineLet/letNoSafeCall.kt

@@ -0,0 +1,9 @@
+// WITH_RUNTIME
+
+
+fun foo() {
+    val foo: String = ""
+    foo.let<caret> {
+        it.length
+    }
+}

idea/testData/inspectionsLocal/replaceSingleLineLet/letNoSafeCall.kt.after

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: true
+
 
 fun foo() {
     val foo: String = ""

idea/testData/inspectionsLocal/replaceSingleLineLet/letNotUseParameterReceiver.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: false
+// PROBLEM: none
 
 fun foo() {
     val foo: String? = null

idea/testData/inspectionsLocal/replaceSingleLineLet/letNotUseReceiver.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: false
+// PROBLEM: none
 
 fun foo() {
     val foo: String? = null

idea/testData/inspectionsLocal/replaceSingleLineLet/letUseIt.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: false
+// PROBLEM: none
 
 fun foo() {
     val foo: String? = null

idea/testData/inspectionsLocal/replaceSingleLineLet/letUseItAsParamWithBinaryExpression.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: false
+// PROBLEM: none
 
 fun foo() {
     "".let<caret> { it.length + "".indexOf(it) }

idea/testData/inspectionsLocal/replaceSingleLineLet/letUseItWithBinaryExpression.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: false
+// PROBLEM: none
 
 fun foo() {
     "".let<caret> { it.length + it.length }

idea/testData/inspectionsLocal/replaceSingleLineLet/letUseItWithBinaryExpression2.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: false
+// PROBLEM: none
 
 fun foo() {
     "".let<caret> { it.substring(0, 1) + it }

idea/testData/inspectionsLocal/replaceSingleLineLet/letUseItWithMultipleMethodCall1.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: false
+// PROBLEM: none
 
 fun foo() {
     val foo: String? = null

idea/testData/inspectionsLocal/replaceSingleLineLet/letUseItWithMultipleMethodCall2.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: false
+// PROBLEM: none
 
 fun foo() {
     val foo: String? = null

idea/testData/inspectionsLocal/replaceSingleLineLet/letUseItWithMultipleMethodCall3.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: false
+// PROBLEM: none
 
 fun foo() {
     val foo: String? = null

idea/testData/inspectionsLocal/replaceSingleLineLet/letUseParameter.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: false
+// PROBLEM: none
 
 fun foo() {
     val foo: String? = null

idea/testData/inspectionsLocal/replaceSingleLineLet/letWithBinaryExpression.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: true
+
 
 fun foo() {
     "".let<caret> { it.length + 1 }

idea/testData/inspectionsLocal/replaceSingleLineLet/letWithBinaryExpression.kt.after

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: true
+
 
 fun foo() {
     "".length + 1

idea/testData/inspectionsLocal/replaceSingleLineLet/letWithMethodCall.kt

@@ -1,9 +1,9 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: true
+
 
 fun foo() {
     val foo: String? = null
-    foo?.let {
-        it.to("")<caret>
+    foo?.let<caret> {
+        it.to("")
     }
 }

idea/testData/inspectionsLocal/replaceSingleLineLet/letWithMethodCall.kt.after

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: true
+
 
 fun foo() {
     val foo: String? = null

idea/testData/inspectionsLocal/replaceSingleLineLet/letWithMultipleMethodCall.kt

@@ -0,0 +1,9 @@
+// WITH_RUNTIME
+
+
+fun foo() {
+    val foo: String? = null
+    foo?.let<caret> {
+        it.hashCode().hashCode()
+    }
+}

idea/testData/inspectionsLocal/replaceSingleLineLet/letWithMultipleMethodCall.kt.after

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: true
+
 
 fun foo() {
     val foo: String? = null

idea/testData/inspectionsLocal/replaceSingleLineLet/letWithParameter.kt

@@ -1,10 +1,10 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: true
+
 
 fun foo() {
     val foo: String? = null
-    foo?.let {
+    foo?.let<caret> {
         text ->
-        text.length<caret>
+        text.length
     }
 }

idea/testData/inspectionsLocal/replaceSingleLineLet/letWithParameter.kt.after

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: true
+
 
 fun foo() {
     val foo: String? = null

idea/testData/inspectionsLocal/replaceSingleLineLet/letWithSimpleBinaryExpression.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: true
+
 
 fun foo() {
     "".let<caret> { it + 1 }

idea/testData/inspectionsLocal/replaceSingleLineLet/letWithSimpleBinaryExpression.kt.after

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: true
+
 
 fun foo() {
     "" + 1

idea/testData/inspectionsLocal/replaceSingleLineLet/letWithThisBinaryExpression.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: true
+
 
 fun Int.foo() {
     let<caret> { it.dec() + 1 }

idea/testData/inspectionsLocal/replaceSingleLineLet/letWithThisBinaryExpression.kt.after

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: true
+
 
 fun Int.foo() {
     dec() + 1

idea/testData/inspectionsLocal/replaceSingleLineLet/letWithThisShortBinaryExpression.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: true
+
 
 fun Int.foo() {
     let<caret> { it + 1 }

idea/testData/inspectionsLocal/replaceSingleLineLet/letWithThisShortBinaryExpression.kt.after

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: true
+
 
 fun Int.foo() {
     this + 1

idea/testData/inspectionsLocal/replaceSingleLineLet/longCallChain.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// PROBLEM: none
+// HIGHLIGHT: INFORMATION
 
 fun test(list: List<Int>) {
     list.filter { it > 1 }.filter { it > 2 }.filter { it > 3 }.let<caret> { println(it) }

idea/testData/inspectionsLocal/replaceSingleLineLet/longCallChain.kt.after

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+// HIGHLIGHT: INFORMATION
+
+fun test(list: List<Int>) {
+    println(list.filter { it > 1 }.filter { it > 2 }.filter { it > 3 })
+}

idea/testData/inspectionsLocal/replaceSingleLineLet/multipleReceiver.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: false
+// PROBLEM: none
 
 fun baz(foo: String) {
     foo.let<caret> { it.substringAfterLast(it.capitalize()) }

idea/testData/inspectionsLocal/replaceSingleLineLet/multipleReceiver2.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: false
+// PROBLEM: none
 
 fun baz(foo: String) {
     foo.let<caret> { it.substringAfterLast("".equals(it).toString()) }

idea/testData/inspectionsLocal/replaceSingleLineLet/multipleReceiver3.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: false
+// PROBLEM: none
 
 fun baz(foo: String) {
     foo.let<caret> { it.substring(0, it.length) }

idea/testData/inspectionsLocal/replaceSingleLineLet/multipleUsages.kt

@@ -1,4 +1,4 @@
-// IS_APPLICABLE: false
+// PROBLEM: none
 // WITH_RUNTIME
 
 fun foo(s: String) {

idea/testData/inspectionsLocal/replaceSingleLineLet/plusNullable.kt

@@ -1,4 +1,4 @@
-// IS_APPLICABLE: false
+// PROBLEM: none
 // WITH_RUNTIME
 
 fun plusNullable(arg: String?) = arg?.let<caret> { it + "#" } ?: ""

idea/testData/inspectionsLocal/replaceSingleLineLet/receiverWithLambda.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: false
+// PROBLEM: none
 
 fun baz(foo: String) {
     foo.let<caret> { it.indexOfLast { c -> c == it[0] } }

idea/testData/inspectionsLocal/replaceSingleLineLet/receiverWithLambda2.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: false
+// PROBLEM: none
 // This should be reported. However, in order to avoid too complicate logic, the intention ignore this case.
 
 import java.util.*

idea/testData/inspectionsLocal/replaceSingleLineLet/sameLets.kt

@@ -1,10 +1,10 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: true
+
 
 fun foo() {
     val foo: String? = null
-    foo?.toString()?.let {
-        it.to("")<caret>
+    foo?.toString()?.let<caret> {
+        it.to("")
     }?.let {
         it.to("")
     }

idea/testData/inspectionsLocal/replaceSingleLineLet/sameLets.kt.after

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: true
+
 
 fun foo() {
     val foo: String? = null

idea/testData/inspectionsLocal/replaceSingleLineLet/smartCastInBody.kt

@@ -1,4 +1,4 @@
-// IS_APPLICABLE: false
+// PROBLEM: none
 // WITH_RUNTIME
 
 interface A

idea/testData/inspectionsLocal/replaceSingleLineLet/this.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: true
+
 
 fun Int.foo(): Int {
     return <caret>let { it.hashCode().hashCode() }

idea/testData/inspectionsLocal/replaceSingleLineLet/this.kt.after

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: true
+
 
 fun Int.foo(): Int {
     return hashCode().hashCode()

idea/testData/inspectionsLocal/replaceSingleLineLet/thisShort.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: true
+
 
 fun Int.foo(): Int {
     return <caret>let { it.hashCode() }

idea/testData/inspectionsLocal/replaceSingleLineLet/thisShort.kt.after

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IS_APPLICABLE: true
+
 
 fun Int.foo(): Int {
     return hashCode()

idea/testData/inspectionsLocal/replaceSingleLineLet/typeChecks.kt

@@ -1,4 +1,4 @@
-// IS_APPLICABLE: false
+// PROBLEM: none
 // WITH_RUNTIME
 
 interface Base

idea/testData/intentions/replaceSingleLineLetIntention/.intention

@@ -1 +0,0 @@
-org.jetbrains.kotlin.idea.intentions.ReplaceSingleLineLetIntention

idea/testData/intentions/replaceSingleLineLetIntention/letNoSafeCall.kt

@@ -1,9 +0,0 @@
-// WITH_RUNTIME
-// IS_APPLICABLE: true
-
-fun foo() {
-    val foo: String = ""
-    foo.let {
-        it.length<caret>
-    }
-}

idea/testData/intentions/replaceSingleLineLetIntention/letWithMultipleMethodCall.kt

@@ -1,9 +0,0 @@
-// WITH_RUNTIME
-// IS_APPLICABLE: true
-
-fun foo() {
-    val foo: String? = null
-    foo?.let {
-        it.hashCode().hashCode()<caret>
-    }
-}