diff --git a/idea/src/org/jetbrains/jet/plugin/highlighter/FunctionsHighlightingVisitor.java b/idea/src/org/jetbrains/jet/plugin/highlighter/FunctionsHighlightingVisitor.java index d58bc0a6654..560cf52bdfb 100644 --- a/idea/src/org/jetbrains/jet/plugin/highlighter/FunctionsHighlightingVisitor.java +++ b/idea/src/org/jetbrains/jet/plugin/highlighter/FunctionsHighlightingVisitor.java @@ -74,14 +74,12 @@ public class FunctionsHighlightingVisitor extends AfterAnalysisHighlightingVisit } else if (calleeDescriptor instanceof FunctionDescriptor && !(calleeDescriptor instanceof VariableAsFunctionDescriptor)) { FunctionDescriptor fun = (FunctionDescriptor)calleeDescriptor; - if (fun.getReceiverParameter() != ReceiverDescriptor.NO_RECEIVER) { - JetPsiChecker.highlightName(holder, callee, JetHighlightingColors.EXTENSION_FUNCTION_CALL); - } - else if (fun.getContainingDeclaration() instanceof NamespaceDescriptor) { + JetPsiChecker.highlightName(holder, callee, JetHighlightingColors.FUNCTION_CALL); + if (fun.getContainingDeclaration() instanceof NamespaceDescriptor) { JetPsiChecker.highlightName(holder, callee, JetHighlightingColors.NAMESPACE_FUNCTION_CALL); } - else { - JetPsiChecker.highlightName(holder, callee, JetHighlightingColors.FUNCTION_CALL); + if (fun.getReceiverParameter() != ReceiverDescriptor.NO_RECEIVER) { + JetPsiChecker.highlightName(holder, callee, JetHighlightingColors.EXTENSION_FUNCTION_CALL); } } } diff --git a/idea/src/org/jetbrains/jet/plugin/highlighter/JetColorSettingsPage.java b/idea/src/org/jetbrains/jet/plugin/highlighter/JetColorSettingsPage.java index 4c5377c8288..965dde39577 100644 --- a/idea/src/org/jetbrains/jet/plugin/highlighter/JetColorSettingsPage.java +++ b/idea/src/org/jetbrains/jet/plugin/highlighter/JetColorSettingsPage.java @@ -58,15 +58,15 @@ public class JetColorSettingsPage implements ColorSettingsPage { "[Deprecated]\n" + "public class MyClass<out T : Iterable<T>>(var prop1 : Int) {\n" + " fun foo(nullable : String?, r : Runnable, f : () -> Int) {\n" + - " println(\"length is ${nullable?.length} \\e\")\n" + + " println(\"length is ${nullable?.length} \\e\")\n" + " val ints = java.util.ArrayList(2)\n" + " ints[0] = 102 + f()\n" + " val myFun = { -> \"\" }\n" + " var ref = ints.size()\n" + - " if (!ints.empty) {\n" + - " ints.forEach @lit {\n" + + " if (!ints.empty) {\n" + + " ints.forEach @lit {\n" + " if (it == null) return @lit\n" + - " println(it + ref)\n" + + " println(it + ref)\n" + " }\n" + " }\n" + " }\n" + diff --git a/idea/src/org/jetbrains/jet/plugin/highlighter/JetHighlightingColors.java b/idea/src/org/jetbrains/jet/plugin/highlighter/JetHighlightingColors.java index 2d6b968c18c..383e8184a8c 100644 --- a/idea/src/org/jetbrains/jet/plugin/highlighter/JetHighlightingColors.java +++ b/idea/src/org/jetbrains/jet/plugin/highlighter/JetHighlightingColors.java @@ -203,7 +203,7 @@ public class JetHighlightingColors { public static final TextAttributesKey EXTENSION_PROPERTY = TextAttributesKey.createTextAttributesKey( "KOTLIN_EXTENSION_PROPERTY", - CodeInsightColors.STATIC_FIELD_ATTRIBUTES.getDefaultAttributes() + new TextAttributes() ); public static final TextAttributesKey FUNCTION_LITERAL_DEFAULT_PARAMETER = TextAttributesKey.createTextAttributesKey( @@ -228,7 +228,7 @@ public class JetHighlightingColors { public static final TextAttributesKey EXTENSION_FUNCTION_CALL = TextAttributesKey.createTextAttributesKey( "KOTLIN_EXTENSION_FUNCTION_CALL", - CodeInsightColors.STATIC_METHOD_ATTRIBUTES.getDefaultAttributes() + new TextAttributes() ); public static final TextAttributesKey CONSTRUCTOR_CALL = TextAttributesKey.createTextAttributesKey( diff --git a/idea/src/org/jetbrains/jet/plugin/highlighter/PropertiesHighlightingVisitor.java b/idea/src/org/jetbrains/jet/plugin/highlighter/PropertiesHighlightingVisitor.java index 68eaf87d112..6cc186ce37f 100644 --- a/idea/src/org/jetbrains/jet/plugin/highlighter/PropertiesHighlightingVisitor.java +++ b/idea/src/org/jetbrains/jet/plugin/highlighter/PropertiesHighlightingVisitor.java @@ -82,14 +82,12 @@ class PropertiesHighlightingVisitor extends AfterAnalysisHighlightingVisitor { @NotNull PropertyDescriptor descriptor, boolean withBackingField) { boolean namespace = descriptor.getContainingDeclaration() instanceof NamespaceDescriptor; + JetPsiChecker.highlightName(holder, elementToHighlight, + namespace ? JetHighlightingColors.NAMESPACE_PROPERTY : JetHighlightingColors.INSTANCE_PROPERTY + ); if (descriptor.getReceiverParameter() != ReceiverDescriptor.NO_RECEIVER) { JetPsiChecker.highlightName(holder, elementToHighlight, JetHighlightingColors.EXTENSION_PROPERTY); } - else { - JetPsiChecker.highlightName(holder, elementToHighlight, - namespace ? JetHighlightingColors.NAMESPACE_PROPERTY : JetHighlightingColors.INSTANCE_PROPERTY - ); - } if (withBackingField) { holder.createInfoAnnotation( elementToHighlight, diff --git a/idea/testData/highlighter/Functions.kt b/idea/testData/highlighter/Functions.kt index 51b9c1f0d31..26f8a22aeaa 100644 --- a/idea/testData/highlighter/Functions.kt +++ b/idea/testData/highlighter/Functions.kt @@ -10,8 +10,8 @@ fun Int.ext() { open class Container { open fun member() { - global() - 5.ext() + global() + 5.ext() member() } } diff --git a/idea/testData/highlighter/Variables.kt b/idea/testData/highlighter/Variables.kt index 2c19abed3bb..a5bb879c89c 100644 --- a/idea/testData/highlighter/Variables.kt +++ b/idea/testData/highlighter/Variables.kt @@ -1,13 +1,13 @@ var x = 5 -val Int.sq : Int +val Int.sq : Int get() { return this * this } val y : Int = 1 get() { - return 5.sq + $y + x + return 5.sq + $y + x } class Foo(val a : Int, b : String) { diff --git a/idea/testData/highlighter/VariablesAsFunctions.kt b/idea/testData/highlighter/VariablesAsFunctions.kt index e2905b06e3d..f6d3b731ac3 100644 --- a/idea/testData/highlighter/VariablesAsFunctions.kt +++ b/idea/testData/highlighter/VariablesAsFunctions.kt @@ -1,6 +1,6 @@ var global : () -> Unit = {} -val Int.ext : () -> Unit +val Int.ext : () -> Unit get() { return {} }