azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[LL FIR] do not allocate lambda for the ValueWithPostCompute.guard

Browse Source 
to reduce a memory consumption for a little

ValueWithPostCompute are created very often
This commit is contained in:
Ilya Kirillov
2022-12-13 14:48:23 +01:00
committed by Space Team
parent 2bb3b41348
commit 8b88315a69
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
analysis/low-level-api-fir/src/org/jetbrains/kotlin/analysis/low/level/api/fir/caches/ValueWithPostCompute.kt
+3 -2
View File
@@ -27,7 +27,7 @@ internal class ValueWithPostCompute<KEY, VALUE, DATA>(
private var _calculate: ((KEY) -> Pair<VALUE, DATA>)? = calculate private var _calculate: ((KEY) -> Pair<VALUE, DATA>)? = calculate
private var _postCompute: ((KEY, VALUE, DATA) -> Unit)? = postCompute private var _postCompute: ((KEY, VALUE, DATA) -> Unit)? = postCompute
private var lock: ReentrantLock? = ReentrantLock() private var lock: ReentrantLock? = ReentrantLock()
private var guard: ThreadLocal<Boolean>? = ThreadLocal.withInitial { false } private var guard: ThreadLocal<Boolean>? = ThreadLocal()
/** /**
* can be in one of the following three states: * can be in one of the following three states:
@@ -43,7 +43,8 @@ internal class ValueWithPostCompute<KEY, VALUE, DATA>(
private var value: Any? = ValueIsNotComputed private var value: Any? = ValueIsNotComputed
private inline fun <T> recursiveGuarded(body: () -> T): T { private inline fun <T> recursiveGuarded(body: () -> T): T {
check(!guard!!.get()) { val currentGuardValue = guard!!.get()
check(currentGuardValue == null || !currentGuardValue) {
"Should not be called recursively" "Should not be called recursively"
} }
guard!!.set(true) guard!!.set(true)