[FIR] Fix resolution of objects in presence of low-priority candidates

For CallKind.VariableAccess, the condition when to *skip* resolution of
objects was previously collector.isSuccess. This wasn't strict enough
because collector.isSuccess could be true when the best found candidate
has an applicability like RESOLVED_WITH_LOW_PRIORITY (e.g. from dynamic
scope or annotated with @LowPriorityInOverloadResolution). In these
cases, we do want to resolve objects. To fix this, the condition is
changed to collector.shouldStopResolve which is stricter.

#KT-57960 Fixed

compiler/testData/diagnostics/testsWithJsStdLib/dynamicTypes/kt57960.fir.txt

@@ -0,0 +1,52 @@
+FILE: kt57960.kt
+    public final class Bar : R|kotlin/Any| {
+        public constructor(): R|Bar| {
+            super<R|kotlin/Any|>()
+        }
+
+        public final var toDOM: R|((Baz) -> kotlin/Any)?| = Null(null)
+            public get(): R|((Baz) -> kotlin/Any)?|
+            public set(value: R|((Baz) -> kotlin/Any)?|): R|kotlin/Unit|
+
+    }
+    public final class Baz : R|kotlin/Any| {
+        public constructor(): R|Baz| {
+            super<R|kotlin/Any|>()
+        }
+
+        public final var text: R|kotlin/String| = String()
+            public get(): R|kotlin/String|
+            public set(value: R|kotlin/String|): R|kotlin/Unit|
+
+    }
+    public final object Foo : R|kotlin/Any| {
+        private constructor(): R|Foo| {
+            super<R|kotlin/Any|>()
+        }
+
+        public final fun create2(toDOM: R|((Baz) -> kotlin/Any)?| = Null(null)): R|Bar| {
+            ^create2 R|/jso|<R|Bar|>(<L> = jso@fun R|Bar|.<anonymous>(): R|kotlin/Unit| <inline=Inline, kind=UNKNOWN>  {
+                R|<local>/toDOM|?.{ $subj$.R|kotlin/let|<R|(Baz) -> kotlin/Any|, R|kotlin/Unit|>(<L> = let@fun <anonymous>(it: R|(Baz) -> kotlin/Any|): R|kotlin/Unit| <inline=Inline, kind=EXACTLY_ONCE>  {
+                    this@R|special/anonymous|.R|/Bar.toDOM| = R|<local>/it|
+                }
+                ) }
+            }
+            )
+        }
+
+    }
+    private final fun buildSchemaNodes1(): R|kotlin/Unit| {
+        R|/jso|<R|dynamic|>(<L> = jso@fun R|dynamic|.<anonymous>(): R|kotlin/Unit| <inline=Inline, kind=UNKNOWN>  {
+            Q|Foo|.R|/Foo.create2|(toDOM = create2@fun <anonymous>(domNode: R|Baz|): R|kotlin/Any| <inline=NoInline>  {
+                ^ R|<local>/domNode|.R|/Baz.text|
+            }
+            )
+        }
+        )
+    }
+    public final fun <T : R|kotlin/Any|> jso(): R|T| {
+        ^jso R|kotlin/js/js|(String(({})))
+    }
+    public final inline fun <T : R|kotlin/Any|> jso(block: R|T.() -> kotlin/Unit|): R|T| {
+        ^jso R|/jso|<R|T|>().R|kotlin/apply|<R|T|>(R|<local>/block|)
+    }

compiler/testData/diagnostics/testsWithJsStdLib/dynamicTypes/kt57960.kt

@@ -0,0 +1,34 @@
+// FIR_IDENTICAL
+// FIR_DUMP
+// ISSUE: KT-57960
+
+class Bar {
+    var toDOM: ((Baz) -> Any)? = null
+}
+
+class Baz {
+    var text: String = ""
+}
+
+object Foo {
+    fun create2(
+        toDOM: ((Baz) -> Any)? = null,
+    ) = jso<Bar> {
+        toDOM?.let { this.toDOM = it }
+    }
+}
+
+private fun buildSchemaNodes1() {
+    jso<dynamic> {
+        Foo.create2(toDOM = { domNode -> domNode.text })
+    }
+}
+
+
+fun <T : Any> jso(): T =
+    js("({})")
+
+inline fun <T : Any> jso(
+    block: T.() -> Unit,
+): T =
+    jso<T>().apply(block)

compiler/testData/diagnostics/testsWithJsStdLib/dynamicTypes/objectAccessInLambdaWithDynamicReceiver.fir.txt

@@ -0,0 +1,27 @@
+FILE: objectAccessInLambdaWithDynamicReceiver.kt
+    public final fun jso(block: R|dynamic.() -> kotlin/Unit|): R|dynamic| {
+        ^jso R|kotlin/js/js|(String(({}))).R|<dynamic>/apply|(vararg(R|<local>/block|))
+    }
+    public final class G : R|kotlin/Any| {
+        public constructor(): R|G| {
+            super<R|kotlin/Any|>()
+        }
+
+        public final companion object Companion : R|kotlin/Any| {
+            private constructor(): R|G.Companion| {
+                super<R|kotlin/Any|>()
+            }
+
+            public final val foo: R|kotlin/String| = String(string)
+                public get(): R|kotlin/String|
+
+        }
+
+    }
+    public final fun test(): R|kotlin/Unit| {
+        R|/jso|(<L> = jso@fun R|dynamic|.<anonymous>(): R|kotlin/Unit| <inline=NoInline>  {
+            R|/G.G|()
+            Q|G|.R|/G.Companion.foo|
+        }
+        )
+    }

compiler/testData/diagnostics/testsWithJsStdLib/dynamicTypes/objectAccessInLambdaWithDynamicReceiver.kt

@@ -0,0 +1,17 @@
+// FIR_IDENTICAL
+// FIR_DUMP
+
+fun jso(block: dynamic.() -> Unit): dynamic = js("({})").apply(block)
+
+class G {
+    companion object {
+        val foo = "string"
+    }
+}
+
+fun test() {
+    jso {
+        <!DEBUG_INFO_EXPRESSION_TYPE("G")!>G()<!>
+        <!DEBUG_INFO_EXPRESSION_TYPE("kotlin.String")!>G.foo<!>
+    }
+}