From 89f7053437474c7953af0506b489834d13b99d92 Mon Sep 17 00:00:00 2001 From: Yahor Berdnikau Date: Wed, 28 Jun 2023 17:43:51 +0200 Subject: [PATCH] [Gradle] Add comment why nagFreeCompilerArgsModification message is not shown Gradle 8.0 suppresses such messages produced by `kotlin-dsl` plugin ^KT-59587 Fixed --- .../kotlin/org/jetbrains/kotlin/gradle/CompilerOptionsIT.kt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/CompilerOptionsIT.kt b/libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/CompilerOptionsIT.kt index 6ad870f5daf..0f009095b8f 100644 --- a/libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/CompilerOptionsIT.kt +++ b/libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/CompilerOptionsIT.kt @@ -24,7 +24,9 @@ internal class CompilerOptionsIT : KGPBaseTest() { @JvmGradlePluginTests @GradleTestVersions( minVersion = TestVersions.Gradle.G_7_3, - maxVersion = TestVersions.Gradle.G_7_6 // TODO(Dmitrii Krasnov): we don't use TestVersions.Gradle.G_8_0, because there is some problem in printing warn message + // In Gradle 8.0 there is logic to filter logger messages that contain compiler options configured by `kotlin-dsl` plugin + // https://github.com/gradle/gradle/blob/master/subprojects/kotlin-dsl-plugins/src/main/kotlin/org/gradle/kotlin/dsl/plugins/dsl/KotlinDslCompilerPlugins.kt#L70-L73 + maxVersion = TestVersions.Gradle.G_7_6, ) @GradleTest internal fun compatibleWithKotlinDsl(gradleVersion: GradleVersion) {