Add inspections for implicit and explicit 'this' #KT-4580 Fixed

idea/testData/inspectionsLocal/explicitThis/.inspection

@@ -0,0 +1 @@
+org.jetbrains.kotlin.idea.inspections.ExplicitThisInspection

idea/testData/inspectionsLocal/explicitThis/differentReceiverInstance.kt

@@ -0,0 +1,12 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+class Foo {
+    val s = ""
+
+    fun test() {
+        Foo().apply {
+            <caret>this@Foo.s
+        }
+    }
+}

idea/testData/inspectionsLocal/explicitThis/differentReceiverInstanceExtension.kt

@@ -0,0 +1,12 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+class Foo {
+    fun test() {
+        Foo().apply {
+            <caret>this@Foo.s()
+        }
+    }
+}
+
+fun Foo.s() {}

idea/testData/inspectionsLocal/explicitThis/differentReceiverType.kt

@@ -0,0 +1,16 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+class Foo {
+    val s = ""
+
+    fun test() {
+        Bar().apply {
+            <caret>this@Foo.s
+        }
+    }
+}
+
+class Bar {
+    val s = ""
+}

idea/testData/inspectionsLocal/explicitThis/differentReceiverTypeExtension.kt

@@ -0,0 +1,16 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+class Foo {
+    fun test() {
+        Bar().apply {
+            <caret>this@Foo.s()
+        }
+    }
+}
+
+class Bar
+
+
+fun Foo.s() {}
+fun Bar.s() {}

idea/testData/inspectionsLocal/explicitThis/extension.kt

@@ -0,0 +1,7 @@
+class Foo {
+    fun test() {
+        <caret>this.s()
+    }
+}
+
+fun Foo.s() = ""

idea/testData/inspectionsLocal/explicitThis/extension.kt.after

@@ -0,0 +1,7 @@
+class Foo {
+    fun test() {
+        <caret>s()
+    }
+}
+
+fun Foo.s() = ""

idea/testData/inspectionsLocal/explicitThis/function.kt

@@ -0,0 +1,7 @@
+class Foo {
+    fun s() = ""
+
+    fun test() {
+        <caret>this.s()
+    }
+}

idea/testData/inspectionsLocal/explicitThis/function.kt.after

@@ -0,0 +1,7 @@
+class Foo {
+    fun s() = ""
+
+    fun test() {
+        <caret>s()
+    }
+}

idea/testData/inspectionsLocal/explicitThis/multipleReceivers.kt

@@ -0,0 +1,11 @@
+// WITH_RUNTIME
+
+class Foo {
+    val s = ""
+
+    fun test() {
+        "".apply {
+            <caret>this@Foo.s
+        }
+    }
+}

idea/testData/inspectionsLocal/explicitThis/multipleReceivers.kt.after

@@ -0,0 +1,11 @@
+// WITH_RUNTIME
+
+class Foo {
+    val s = ""
+
+    fun test() {
+        "".apply {
+            <caret>s
+        }
+    }
+}

idea/testData/inspectionsLocal/explicitThis/multipleReceiversExtension.kt

@@ -0,0 +1,11 @@
+// WITH_RUNTIME
+
+class Foo {
+    fun test() {
+        "".apply {
+            <caret>this@Foo.s()
+        }
+    }
+}
+
+fun Foo.s() = ""

idea/testData/inspectionsLocal/explicitThis/multipleReceiversExtension.kt.after

@@ -0,0 +1,11 @@
+// WITH_RUNTIME
+
+class Foo {
+    fun test() {
+        "".apply {
+            <caret>s()
+        }
+    }
+}
+
+fun Foo.s() = ""

idea/testData/inspectionsLocal/explicitThis/nestedReceivers.kt

@@ -0,0 +1,18 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+class Foo {
+    val s = ""
+
+    fun test() {
+        Bar().apply {
+            "".run {
+                <caret>this@apply.s
+            }
+        }
+    }
+}
+
+class Bar {
+    val s = ""
+}

idea/testData/inspectionsLocal/explicitThis/nestedReceiversDifferentParameters.kt

@@ -0,0 +1,17 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+class Foo {
+    fun s(a: String) {}
+
+    fun test() {
+        Bar().apply {
+            <caret>this@Foo.s("")
+        }
+    }
+}
+
+class Bar {
+    fun s() {}
+}
+

idea/testData/inspectionsLocal/explicitThis/nestedReceiversExtension.kt

@@ -0,0 +1,17 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+class Foo {
+    fun test() {
+        Bar().apply {
+            "".run {
+                <caret>this@apply.s()
+            }
+        }
+    }
+}
+
+class Bar
+
+fun Foo.s() {}
+fun Bar.s() {}

idea/testData/inspectionsLocal/explicitThis/nestedReceiversExtensionDifferentParameters.kt

@@ -0,0 +1,15 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+class Foo {
+    fun test() {
+        Bar().apply {
+            <caret>this@Foo.s("")
+        }
+    }
+}
+
+class Bar
+
+fun Foo.s(a: String) {}
+fun Bar.s() {}

idea/testData/inspectionsLocal/explicitThis/property.kt

@@ -0,0 +1,7 @@
+class Foo {
+    val s = ""
+
+    fun test() {
+        <caret>this.s
+    }
+}

idea/testData/inspectionsLocal/explicitThis/property.kt.after

@@ -0,0 +1,7 @@
+class Foo {
+    val s = ""
+
+    fun test() {
+        <caret>s
+    }
+}

idea/testData/inspectionsLocal/explicitThis/variableWithSameName.kt

@@ -0,0 +1,11 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+class Foo {
+    var s = ""
+
+    fun test() {
+        val s = ""
+        <caret>this.s = s
+    }
+}