diff --git a/idea/src/org/jetbrains/kotlin/idea/refactoring/KotlinRefactoringSettings.kt b/idea/src/org/jetbrains/kotlin/idea/refactoring/KotlinRefactoringSettings.kt index 3214d13e862..66aa25ce33b 100644 --- a/idea/src/org/jetbrains/kotlin/idea/refactoring/KotlinRefactoringSettings.kt +++ b/idea/src/org/jetbrains/kotlin/idea/refactoring/KotlinRefactoringSettings.kt @@ -20,6 +20,7 @@ import com.intellij.openapi.components.PersistentStateComponent import com.intellij.openapi.components.ServiceManager import com.intellij.openapi.components.State import com.intellij.openapi.components.Storage +import com.intellij.refactoring.JavaRefactoringSettings import com.intellij.util.xmlb.XmlSerializerUtil @State(name = "KotlinRefactoringSettings", storages = arrayOf(Storage("kotlinRefactoring.xml"))) @@ -27,6 +28,36 @@ class KotlinRefactoringSettings : PersistentStateComponent(JavaRefactoringSettings.getInstance().PULL_UP_MEMBERS_JAVADOC)) + DocCommentPolicy(KotlinRefactoringSettings.instance.PULL_UP_MEMBERS_JAVADOC)) } } } \ No newline at end of file diff --git a/idea/src/org/jetbrains/kotlin/idea/refactoring/pushDown/KotlinPushDownDialog.kt b/idea/src/org/jetbrains/kotlin/idea/refactoring/pushDown/KotlinPushDownDialog.kt index b1007fd6aa3..baf7c584b1a 100644 --- a/idea/src/org/jetbrains/kotlin/idea/refactoring/pushDown/KotlinPushDownDialog.kt +++ b/idea/src/org/jetbrains/kotlin/idea/refactoring/pushDown/KotlinPushDownDialog.kt @@ -18,7 +18,7 @@ package org.jetbrains.kotlin.idea.refactoring.pushDown import com.intellij.openapi.project.Project import com.intellij.psi.PsiNamedElement -import com.intellij.refactoring.JavaRefactoringSettings +import org.jetbrains.kotlin.idea.refactoring.KotlinRefactoringSettings import com.intellij.refactoring.RefactoringBundle import com.intellij.refactoring.classMembers.* import com.intellij.refactoring.ui.RefactoringDialog @@ -106,7 +106,7 @@ class KotlinPushDownDialog( override fun doAction() { if (!isOKActionEnabled) return - JavaRefactoringSettings.getInstance().PUSH_DOWN_PREVIEW_USAGES = isPreviewUsages + KotlinRefactoringSettings.instance.PUSH_DOWN_PREVIEW_USAGES = isPreviewUsages invokeRefactoring(KotlinPushDownProcessor(project, sourceClass, selectedMemberInfos)) } diff --git a/idea/src/org/jetbrains/kotlin/idea/refactoring/rename/AutomaticInheritorRenamer.kt b/idea/src/org/jetbrains/kotlin/idea/refactoring/rename/AutomaticInheritorRenamer.kt index b11d0065ec9..33ceffaabda 100644 --- a/idea/src/org/jetbrains/kotlin/idea/refactoring/rename/AutomaticInheritorRenamer.kt +++ b/idea/src/org/jetbrains/kotlin/idea/refactoring/rename/AutomaticInheritorRenamer.kt @@ -19,7 +19,7 @@ package org.jetbrains.kotlin.idea.refactoring.rename import com.intellij.psi.PsiElement import com.intellij.psi.PsiNamedElement import com.intellij.psi.search.searches.ClassInheritorsSearch -import com.intellij.refactoring.JavaRefactoringSettings +import org.jetbrains.kotlin.idea.refactoring.KotlinRefactoringSettings import com.intellij.refactoring.RefactoringBundle import com.intellij.refactoring.rename.naming.AutomaticRenamer import com.intellij.refactoring.rename.naming.AutomaticRenamerFactory @@ -49,8 +49,10 @@ class AutomaticInheritorRenamer(klass: KtClass, newName: String): AutomaticRenam class AutomaticInheritorRenamerFactory : AutomaticRenamerFactory { override fun isApplicable(element: PsiElement) = element is KtClass override fun getOptionName() = RefactoringBundle.message("rename.inheritors") - override fun isEnabled() = JavaRefactoringSettings.getInstance().isToRenameInheritors - override fun setEnabled(enabled: Boolean) = JavaRefactoringSettings.getInstance().setRenameInheritors(enabled) + override fun isEnabled() = KotlinRefactoringSettings.instance.renameInheritors + override fun setEnabled(enabled: Boolean) { + KotlinRefactoringSettings.instance.renameInheritors = enabled + } override fun createRenamer(element: PsiElement, newName: String, usages: Collection): AutomaticRenamer { return AutomaticInheritorRenamer(element as KtClass, newName) diff --git a/idea/src/org/jetbrains/kotlin/idea/refactoring/rename/AutomaticOverloadsRenamer.kt b/idea/src/org/jetbrains/kotlin/idea/refactoring/rename/AutomaticOverloadsRenamer.kt index 8f07afe957a..9ceec4310d2 100644 --- a/idea/src/org/jetbrains/kotlin/idea/refactoring/rename/AutomaticOverloadsRenamer.kt +++ b/idea/src/org/jetbrains/kotlin/idea/refactoring/rename/AutomaticOverloadsRenamer.kt @@ -18,7 +18,7 @@ package org.jetbrains.kotlin.idea.refactoring.rename import com.intellij.openapi.util.Key import com.intellij.psi.PsiElement -import com.intellij.refactoring.JavaRefactoringSettings +import org.jetbrains.kotlin.idea.refactoring.KotlinRefactoringSettings import com.intellij.refactoring.RefactoringBundle import com.intellij.refactoring.rename.naming.AutomaticRenamer import com.intellij.refactoring.rename.naming.AutomaticRenamerFactory @@ -88,10 +88,10 @@ class AutomaticOverloadsRenamerFactory : AutomaticRenamerFactory { override fun getOptionName() = RefactoringBundle.message("rename.overloads") - override fun isEnabled() = JavaRefactoringSettings.getInstance().isRenameOverloads + override fun isEnabled() = KotlinRefactoringSettings.instance.renameOverloads override fun setEnabled(enabled: Boolean) { - JavaRefactoringSettings.getInstance().isRenameOverloads = enabled + KotlinRefactoringSettings.instance.renameOverloads = enabled } override fun createRenamer(element: PsiElement, newName: String, usages: Collection) diff --git a/idea/src/org/jetbrains/kotlin/idea/refactoring/rename/AutomaticParameterRenamer.kt b/idea/src/org/jetbrains/kotlin/idea/refactoring/rename/AutomaticParameterRenamer.kt index 23a0bee5419..5ef2f363248 100644 --- a/idea/src/org/jetbrains/kotlin/idea/refactoring/rename/AutomaticParameterRenamer.kt +++ b/idea/src/org/jetbrains/kotlin/idea/refactoring/rename/AutomaticParameterRenamer.kt @@ -19,7 +19,7 @@ package org.jetbrains.kotlin.idea.refactoring.rename import com.intellij.psi.PsiElement import com.intellij.psi.PsiMethod import com.intellij.psi.PsiNamedElement -import com.intellij.refactoring.JavaRefactoringSettings +import org.jetbrains.kotlin.idea.refactoring.KotlinRefactoringSettings import com.intellij.refactoring.RefactoringBundle import com.intellij.refactoring.rename.naming.AutomaticRenamer import com.intellij.refactoring.rename.naming.AutomaticRenamerFactory @@ -69,10 +69,10 @@ class AutomaticParameterRenamerFactory : AutomaticRenamerFactory { override fun getOptionName() = RefactoringBundle.message("rename.parameters.hierarchy")!! - override fun isEnabled() = JavaRefactoringSettings.getInstance().isRenameParameterInHierarchy + override fun isEnabled() = KotlinRefactoringSettings.instance.renameParameterInHierarchy override fun setEnabled(enabled: Boolean) { - JavaRefactoringSettings.getInstance().isRenameParameterInHierarchy = enabled + KotlinRefactoringSettings.instance.renameParameterInHierarchy = enabled } override fun createRenamer(element: PsiElement, newName: String, usages: Collection): AutomaticRenamer { diff --git a/idea/src/org/jetbrains/kotlin/idea/refactoring/rename/AutomaticVariableRenamer.kt b/idea/src/org/jetbrains/kotlin/idea/refactoring/rename/AutomaticVariableRenamer.kt index f10a41ae330..4f0ab670e17 100644 --- a/idea/src/org/jetbrains/kotlin/idea/refactoring/rename/AutomaticVariableRenamer.kt +++ b/idea/src/org/jetbrains/kotlin/idea/refactoring/rename/AutomaticVariableRenamer.kt @@ -24,7 +24,7 @@ import com.intellij.psi.PsiNamedElement import com.intellij.psi.PsiVariable import com.intellij.psi.codeStyle.JavaCodeStyleManager import com.intellij.psi.util.PsiTreeUtil -import com.intellij.refactoring.JavaRefactoringSettings +import org.jetbrains.kotlin.idea.refactoring.KotlinRefactoringSettings import com.intellij.refactoring.RefactoringBundle import com.intellij.refactoring.rename.naming.AutomaticRenamer import com.intellij.refactoring.rename.naming.AutomaticRenamerFactory @@ -145,8 +145,10 @@ open class AutomaticVariableRenamerFactory: AutomaticRenamerFactory { override fun createRenamer(element: PsiElement, newName: String, usages: Collection) = AutomaticVariableRenamer(element as PsiNamedElement, newName, usages) - override fun isEnabled() = JavaRefactoringSettings.getInstance().isToRenameVariables - override fun setEnabled(enabled: Boolean) = JavaRefactoringSettings.getInstance().setRenameVariables(enabled) + override fun isEnabled() = KotlinRefactoringSettings.instance.renameVariables + override fun setEnabled(enabled: Boolean) { + KotlinRefactoringSettings.instance.renameVariables = enabled + } override fun getOptionName() = RefactoringBundle.message("rename.variables") } @@ -164,8 +166,10 @@ class AutomaticVariableInJavaRenamerFactory: AutomaticRenamerFactory { // Using java variable renamer for java usages com.intellij.refactoring.rename.naming.AutomaticVariableRenamer((element as KtClass).toLightClass()!!, newName, usages) - override fun isEnabled() = JavaRefactoringSettings.getInstance().isToRenameVariables - override fun setEnabled(enabled: Boolean) = JavaRefactoringSettings.getInstance().setRenameVariables(enabled) + override fun isEnabled() = KotlinRefactoringSettings.instance.renameVariables + override fun setEnabled(enabled: Boolean) { + KotlinRefactoringSettings.instance.renameVariables = enabled + } override fun getOptionName() = null } \ No newline at end of file diff --git a/idea/src/org/jetbrains/kotlin/idea/refactoring/rename/RenameKotlinClassifierProcessor.kt b/idea/src/org/jetbrains/kotlin/idea/refactoring/rename/RenameKotlinClassifierProcessor.kt index 056ee8ca675..5d6b0de7388 100644 --- a/idea/src/org/jetbrains/kotlin/idea/refactoring/rename/RenameKotlinClassifierProcessor.kt +++ b/idea/src/org/jetbrains/kotlin/idea/refactoring/rename/RenameKotlinClassifierProcessor.kt @@ -19,7 +19,7 @@ package org.jetbrains.kotlin.idea.refactoring.rename import com.intellij.openapi.editor.Editor import com.intellij.psi.PsiElement import com.intellij.psi.PsiReference -import com.intellij.refactoring.JavaRefactoringSettings +import org.jetbrains.kotlin.idea.refactoring.KotlinRefactoringSettings import com.intellij.refactoring.listeners.RefactoringElementListener import com.intellij.usageView.UsageInfo import org.jetbrains.kotlin.asJava.classes.KtLightClass @@ -40,16 +40,16 @@ class RenameKotlinClassifierProcessor : RenameKotlinPsiProcessor() { return element is KtClassOrObject || element is KtLightClass || element is KtConstructor<*> || element is KtTypeAlias } - override fun isToSearchInComments(psiElement: PsiElement) = JavaRefactoringSettings.getInstance().RENAME_SEARCH_IN_COMMENTS_FOR_CLASS + override fun isToSearchInComments(psiElement: PsiElement) = KotlinRefactoringSettings.instance.RENAME_SEARCH_IN_COMMENTS_FOR_CLASS override fun setToSearchInComments(element: PsiElement, enabled: Boolean) { - JavaRefactoringSettings.getInstance().RENAME_SEARCH_IN_COMMENTS_FOR_CLASS = enabled + KotlinRefactoringSettings.instance.RENAME_SEARCH_IN_COMMENTS_FOR_CLASS = enabled } - override fun isToSearchForTextOccurrences(element: PsiElement) = JavaRefactoringSettings.getInstance().RENAME_SEARCH_FOR_TEXT_FOR_CLASS + override fun isToSearchForTextOccurrences(element: PsiElement) = KotlinRefactoringSettings.instance.RENAME_SEARCH_FOR_TEXT_FOR_CLASS override fun setToSearchForTextOccurrences(element: PsiElement, enabled: Boolean) { - JavaRefactoringSettings.getInstance().RENAME_SEARCH_FOR_TEXT_FOR_CLASS = enabled + KotlinRefactoringSettings.instance.RENAME_SEARCH_FOR_TEXT_FOR_CLASS = enabled } override fun substituteElementToRename(element: PsiElement, editor: Editor?) = getClassOrObject(element) diff --git a/idea/src/org/jetbrains/kotlin/idea/refactoring/rename/RenameKotlinFunctionProcessor.kt b/idea/src/org/jetbrains/kotlin/idea/refactoring/rename/RenameKotlinFunctionProcessor.kt index 1a885e9a7ed..b3bd2040c8b 100644 --- a/idea/src/org/jetbrains/kotlin/idea/refactoring/rename/RenameKotlinFunctionProcessor.kt +++ b/idea/src/org/jetbrains/kotlin/idea/refactoring/rename/RenameKotlinFunctionProcessor.kt @@ -21,7 +21,7 @@ import com.intellij.openapi.project.Project import com.intellij.openapi.util.Pass import com.intellij.psi.* import com.intellij.psi.search.SearchScope -import com.intellij.refactoring.JavaRefactoringSettings +import org.jetbrains.kotlin.idea.refactoring.KotlinRefactoringSettings import com.intellij.refactoring.listeners.RefactoringElementListener import com.intellij.refactoring.rename.RenameDialog import com.intellij.refactoring.rename.RenameJavaMethodProcessor @@ -61,16 +61,16 @@ class RenameKotlinFunctionProcessor : RenameKotlinPsiProcessor() { return element is KtNamedFunction || (element is KtLightMethod && element.kotlinOrigin is KtNamedFunction) || element is FunctionWithSupersWrapper } - override fun isToSearchInComments(psiElement: PsiElement) = JavaRefactoringSettings.getInstance().RENAME_SEARCH_IN_COMMENTS_FOR_METHOD + override fun isToSearchInComments(psiElement: PsiElement) = KotlinRefactoringSettings.instance.RENAME_SEARCH_IN_COMMENTS_FOR_METHOD override fun setToSearchInComments(element: PsiElement, enabled: Boolean) { - JavaRefactoringSettings.getInstance().RENAME_SEARCH_IN_COMMENTS_FOR_METHOD = enabled + KotlinRefactoringSettings.instance.RENAME_SEARCH_IN_COMMENTS_FOR_METHOD = enabled } - override fun isToSearchForTextOccurrences(element: PsiElement) = JavaRefactoringSettings.getInstance().RENAME_SEARCH_FOR_TEXT_FOR_METHOD + override fun isToSearchForTextOccurrences(element: PsiElement) = KotlinRefactoringSettings.instance.RENAME_SEARCH_FOR_TEXT_FOR_METHOD override fun setToSearchForTextOccurrences(element: PsiElement, enabled: Boolean) { - JavaRefactoringSettings.getInstance().RENAME_SEARCH_FOR_TEXT_FOR_METHOD = enabled + KotlinRefactoringSettings.instance.RENAME_SEARCH_FOR_TEXT_FOR_METHOD = enabled } private fun getJvmName(element: PsiElement): String? { diff --git a/idea/src/org/jetbrains/kotlin/idea/refactoring/rename/RenameKotlinParameterProcessor.kt b/idea/src/org/jetbrains/kotlin/idea/refactoring/rename/RenameKotlinParameterProcessor.kt index 258a24b945c..e622c79842d 100644 --- a/idea/src/org/jetbrains/kotlin/idea/refactoring/rename/RenameKotlinParameterProcessor.kt +++ b/idea/src/org/jetbrains/kotlin/idea/refactoring/rename/RenameKotlinParameterProcessor.kt @@ -17,7 +17,7 @@ package org.jetbrains.kotlin.idea.refactoring.rename import com.intellij.psi.PsiElement -import com.intellij.refactoring.JavaRefactoringSettings +import org.jetbrains.kotlin.idea.refactoring.KotlinRefactoringSettings import com.intellij.refactoring.listeners.RefactoringElementListener import com.intellij.usageView.UsageInfo import org.jetbrains.kotlin.asJava.namedUnwrappedElement @@ -29,10 +29,10 @@ import org.jetbrains.kotlin.utils.SmartList class RenameKotlinParameterProcessor : RenameKotlinPsiProcessor() { override fun canProcessElement(element: PsiElement) = element is KtParameter && element.ownerFunction is KtFunction - override fun isToSearchInComments(psiElement: PsiElement) = JavaRefactoringSettings.getInstance().RENAME_SEARCH_IN_COMMENTS_FOR_VARIABLE + override fun isToSearchInComments(psiElement: PsiElement) = KotlinRefactoringSettings.instance.RENAME_SEARCH_IN_COMMENTS_FOR_VARIABLE override fun setToSearchInComments(element: PsiElement, enabled: Boolean) { - JavaRefactoringSettings.getInstance().RENAME_SEARCH_IN_COMMENTS_FOR_VARIABLE = enabled + KotlinRefactoringSettings.instance.RENAME_SEARCH_IN_COMMENTS_FOR_VARIABLE = enabled } override fun findCollisions( diff --git a/idea/src/org/jetbrains/kotlin/idea/refactoring/rename/RenameKotlinPropertyProcessor.kt b/idea/src/org/jetbrains/kotlin/idea/refactoring/rename/RenameKotlinPropertyProcessor.kt index d3490978a19..0cc7b4b146f 100644 --- a/idea/src/org/jetbrains/kotlin/idea/refactoring/rename/RenameKotlinPropertyProcessor.kt +++ b/idea/src/org/jetbrains/kotlin/idea/refactoring/rename/RenameKotlinPropertyProcessor.kt @@ -25,7 +25,7 @@ import com.intellij.psi.* import com.intellij.psi.search.SearchScope import com.intellij.psi.search.searches.DirectClassInheritorsSearch import com.intellij.psi.search.searches.OverridingMethodsSearch -import com.intellij.refactoring.JavaRefactoringSettings +import org.jetbrains.kotlin.idea.refactoring.KotlinRefactoringSettings import com.intellij.refactoring.listeners.RefactoringElementListener import com.intellij.refactoring.rename.RenameProcessor import com.intellij.refactoring.util.MoveRenameUsageInfo @@ -78,16 +78,16 @@ class RenameKotlinPropertyProcessor : RenameKotlinPsiProcessor() { return namedUnwrappedElement is KtProperty || (namedUnwrappedElement is KtParameter && namedUnwrappedElement.hasValOrVar()) } - override fun isToSearchInComments(psiElement: PsiElement) = JavaRefactoringSettings.getInstance().RENAME_SEARCH_IN_COMMENTS_FOR_FIELD + override fun isToSearchInComments(psiElement: PsiElement) = KotlinRefactoringSettings.instance.RENAME_SEARCH_IN_COMMENTS_FOR_FIELD override fun setToSearchInComments(element: PsiElement, enabled: Boolean) { - JavaRefactoringSettings.getInstance().RENAME_SEARCH_IN_COMMENTS_FOR_FIELD = enabled + KotlinRefactoringSettings.instance.RENAME_SEARCH_IN_COMMENTS_FOR_FIELD = enabled } - override fun isToSearchForTextOccurrences(element: PsiElement) = JavaRefactoringSettings.getInstance().RENAME_SEARCH_FOR_TEXT_FOR_FIELD + override fun isToSearchForTextOccurrences(element: PsiElement) = KotlinRefactoringSettings.instance.RENAME_SEARCH_FOR_TEXT_FOR_FIELD override fun setToSearchForTextOccurrences(element: PsiElement, enabled: Boolean) { - JavaRefactoringSettings.getInstance().RENAME_SEARCH_FOR_TEXT_FOR_FIELD = enabled + KotlinRefactoringSettings.instance.RENAME_SEARCH_FOR_TEXT_FOR_FIELD = enabled } private fun getJvmNames(element: PsiElement): Pair {