azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIR] Check is for impossibility

Browse Source 
^KT-58203 Fixed
^KT-62646
This commit is contained in:
Nikolay Lunyak
2024-02-29 15:39:33 +02:00
committed by Space Team
parent 92d8da621e
commit 88ff93df7f
42 changed files with 110 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/testData/diagnostics/tests/when/When.fir.kt
Vendored
+1 -1
View File
@@ -18,7 +18,7 @@ fun foo() : Int {
val s = ""
val x = 1
when (x) {
is String -> 1
<!USELESS_IS_CHECK!>is String<!> -> 1
<!USELESS_IS_CHECK!>!is Int<!> -> 1
<!USELESS_IS_CHECK!>is Any?<!> -> 1
<!USELESS_IS_CHECK!>is Any<!> -> 1
compiler/testData/diagnostics/tests/when/deprecatedSyntaxInConditionsNoSubject.fir.kt
Vendored
+2 -2
View File
@@ -39,8 +39,8 @@ fun testWithSubject_ok(x: Boolean, y: Boolean?, any: Any, z: Boolean) {
y ?: x -> {}
x in x -> {}
x !in x -> {}
x is String -> {}
x !is String -> {}
<!USELESS_IS_CHECK!>x is String<!> -> {}
<!USELESS_IS_CHECK!>x !is String<!> -> {}
x < x -> {}
x > x -> {}
x <= x -> {}
compiler/testData/diagnostics/tests/when/deprecatedSyntaxInConditions_after.fir.kt
Vendored
+8 -8
View File
@@ -57,8 +57,8 @@ fun testWithSubject_bad_1(x: A) {
when (x) {
<!CONFUSING_BRANCH_CONDITION_ERROR!>x in x<!> -> {}
<!CONFUSING_BRANCH_CONDITION_ERROR!>x !in x<!> -> {}
<!CONFUSING_BRANCH_CONDITION_ERROR!>x is String<!> -> {}
<!CONFUSING_BRANCH_CONDITION_ERROR!>x !is String<!> -> {}
<!CONFUSING_BRANCH_CONDITION_ERROR, USELESS_IS_CHECK!>x is String<!> -> {}
<!CONFUSING_BRANCH_CONDITION_ERROR, USELESS_IS_CHECK!>x !is String<!> -> {}
<!CONFUSING_BRANCH_CONDITION_ERROR!>x < x<!> -> {}
<!CONFUSING_BRANCH_CONDITION_ERROR!>x > x<!> -> {}
<!CONFUSING_BRANCH_CONDITION_ERROR!>x <= x<!> -> {}
@@ -72,8 +72,8 @@ fun testWithSubject_bad_1(x: A) {
when (x) {
(x in x) -> {}
(x !in x) -> {}
(x is String) -> {}
(x !is String) -> {}
(<!USELESS_IS_CHECK!>x is String<!>) -> {}
(<!USELESS_IS_CHECK!>x !is String<!>) -> {}
(x < x) -> {}
(x > x) -> {}
(x <= x) -> {}
@@ -161,8 +161,8 @@ fun testWithRange_bad_1(x: A) {
when (x) {
in <!CONFUSING_BRANCH_CONDITION_ERROR!>x in x<!> -> {}
in <!CONFUSING_BRANCH_CONDITION_ERROR!>x !in x<!> -> {}
in <!CONFUSING_BRANCH_CONDITION_ERROR!>x is String<!> -> {}
in <!CONFUSING_BRANCH_CONDITION_ERROR!>x !is String<!> -> {}
in <!CONFUSING_BRANCH_CONDITION_ERROR, USELESS_IS_CHECK!>x is String<!> -> {}
in <!CONFUSING_BRANCH_CONDITION_ERROR, USELESS_IS_CHECK!>x !is String<!> -> {}
in <!CONFUSING_BRANCH_CONDITION_ERROR!>x < x<!> -> {}
in <!CONFUSING_BRANCH_CONDITION_ERROR!>x > x<!> -> {}
in <!CONFUSING_BRANCH_CONDITION_ERROR!>x <= x<!> -> {}
@@ -176,8 +176,8 @@ fun testWithRange_bad_1(x: A) {
when (x) {
in (x in x) -> {}
in (x !in x) -> {}
in (x is String) -> {}
in (x !is String) -> {}
in (<!USELESS_IS_CHECK!>x is String<!>) -> {}
in (<!USELESS_IS_CHECK!>x !is String<!>) -> {}
in (x < x) -> {}
in (x > x) -> {}
in (x <= x) -> {}
compiler/testData/diagnostics/tests/when/deprecatedSyntaxInConditions_before.fir.kt
Vendored
+8 -8
View File
@@ -57,8 +57,8 @@ fun testWithSubject_bad_1(x: A) {
when (x) {
<!CONFUSING_BRANCH_CONDITION_WARNING!>x in x<!> -> {}
<!CONFUSING_BRANCH_CONDITION_WARNING!>x !in x<!> -> {}
<!CONFUSING_BRANCH_CONDITION_WARNING!>x is String<!> -> {}
<!CONFUSING_BRANCH_CONDITION_WARNING!>x !is String<!> -> {}
<!CONFUSING_BRANCH_CONDITION_WARNING, USELESS_IS_CHECK!>x is String<!> -> {}
<!CONFUSING_BRANCH_CONDITION_WARNING, USELESS_IS_CHECK!>x !is String<!> -> {}
<!CONFUSING_BRANCH_CONDITION_WARNING!>x < x<!> -> {}
<!CONFUSING_BRANCH_CONDITION_WARNING!>x > x<!> -> {}
<!CONFUSING_BRANCH_CONDITION_WARNING!>x <= x<!> -> {}
@@ -72,8 +72,8 @@ fun testWithSubject_bad_1(x: A) {
when (x) {
(x in x) -> {}
(x !in x) -> {}
(x is String) -> {}
(x !is String) -> {}
(<!USELESS_IS_CHECK!>x is String<!>) -> {}
(<!USELESS_IS_CHECK!>x !is String<!>) -> {}
(x < x) -> {}
(x > x) -> {}
(x <= x) -> {}
@@ -161,8 +161,8 @@ fun testWithRange_bad_1(x: A) {
when (x) {
in <!CONFUSING_BRANCH_CONDITION_WARNING!>x in x<!> -> {}
in <!CONFUSING_BRANCH_CONDITION_WARNING!>x !in x<!> -> {}
in <!CONFUSING_BRANCH_CONDITION_WARNING!>x is String<!> -> {}
in <!CONFUSING_BRANCH_CONDITION_WARNING!>x !is String<!> -> {}
in <!CONFUSING_BRANCH_CONDITION_WARNING, USELESS_IS_CHECK!>x is String<!> -> {}
in <!CONFUSING_BRANCH_CONDITION_WARNING, USELESS_IS_CHECK!>x !is String<!> -> {}
in <!CONFUSING_BRANCH_CONDITION_WARNING!>x < x<!> -> {}
in <!CONFUSING_BRANCH_CONDITION_WARNING!>x > x<!> -> {}
in <!CONFUSING_BRANCH_CONDITION_WARNING!>x <= x<!> -> {}
@@ -176,8 +176,8 @@ fun testWithRange_bad_1(x: A) {
when (x) {
in (x in x) -> {}
in (x !in x) -> {}
in (x is String) -> {}
in (x !is String) -> {}
in (<!USELESS_IS_CHECK!>x is String<!>) -> {}
in (<!USELESS_IS_CHECK!>x !is String<!>) -> {}
in (x < x) -> {}
in (x > x) -> {}
in (x <= x) -> {}
compiler/testData/diagnostics/tests/when/intersectionExhaustivenessComplex.fir.kt
Vendored
+12 -12
View File
@@ -14,29 +14,29 @@ fun foo(a: A) {
if (a !is B) return
when (a) {
is A.A1 -> ""
is A.A2 -> "v"
<!USELESS_IS_CHECK!>is A.A1<!> -> ""
<!USELESS_IS_CHECK!>is A.A2<!> -> "v"
}.length
when (a) {
is A.A1 -> ""
is A.A2 -> "v"
<!USELESS_IS_CHECK!>is A.A1<!> -> ""
<!USELESS_IS_CHECK!>is A.A2<!> -> "v"
}.length // OK
when (a) {
is A.A1 -> ""
is A.A2 -> "v"
is B.B1 -> "..." // should be warning: unreachable code
<!USELESS_IS_CHECK!>is A.A1<!> -> ""
<!USELESS_IS_CHECK!>is A.A2<!> -> "v"
<!USELESS_IS_CHECK!>is B.B1<!> -> "..." // should be warning: unreachable code
}.length // OK
when (a) {
is A.A1 -> ""
is B.B1 -> "..."
is A.A2 -> "v"
<!USELESS_IS_CHECK!>is A.A1<!> -> ""
<!USELESS_IS_CHECK!>is B.B1<!> -> "..."
<!USELESS_IS_CHECK!>is A.A2<!> -> "v"
}.length // OK
<!NO_ELSE_IN_WHEN!>when<!> (a) {
is A.A1 -> ""
is B.B1 -> "..."
<!USELESS_IS_CHECK!>is A.A1<!> -> ""
<!USELESS_IS_CHECK!>is B.B1<!> -> "..."
}.length
}
compiler/testData/diagnostics/tests/when/intersectionExhaustivenessSimple.kt
Vendored
+1 -1
View File
@@ -1,5 +1,5 @@
// SKIP_TXT
// FIR_IDENTICAL
// SKIP_TXT
// !CHECK_TYPE
sealed class KtClassifierSymbol
compiler/testData/diagnostics/tests/when/withSubjectVariable/unsupportedVariableDeclarationsInWhenSubject.fir.kt
Vendored
+1 -1
View File
@@ -12,7 +12,7 @@ fun testSimpleValInWhenSubject() {
fun testValWithoutInitializerWhenSubject() {
when (<!ILLEGAL_DECLARATION_IN_WHEN_SUBJECT!>val y: Any<!>) {
<!EXPECTED_CONDITION!>is String<!> -> <!UNINITIALIZED_VARIABLE!>y<!>.<!UNRESOLVED_REFERENCE!>length<!>
<!EXPECTED_CONDITION, USELESS_IS_CHECK!>is String<!> -> <!UNINITIALIZED_VARIABLE!>y<!>.<!UNRESOLVED_REFERENCE!>length<!>
}
}