Drop MetadataComparisonTest & drop build-tools -> util-klib dependency

Review: https://jetbrains.team/p/kt/reviews/8360

MetadataComparisonTest was the only one in build-tools module who
depended on util-klib, that's why we can drop build-tools -> util-klib
dependency

MetadataComparisonTest is no longer needed, that's why we can drop it.

The dependency drop is a one step forward in dropping
`kotlin.srcDir("../compiler/util-klib/src")` line in
`buildSrc/build.gradle.kts`. Adding source roots in `buildSrc` is hacky
and can lead to frustrations (e.g. KT-55874). That's why it's desirable
to drop buildSrc -> util-klib hacky dependency.

Unfortunatelly, I couldn't drop buildSrc -> util-klib dependency,
because:
1. buildSrc depends on kotlin-native/shared/src/library/kotlin +
   buildSrc depends on kotlin-native/tools/kotlin-native-gradle-plugin +
   maybe smth else
2. kotlin-native/shared/src/library/kotlin depends on util-klib +
   kotlin-native/tools/kotlin-native-gradle-plugin depends on util-klib +
   maybe smth else
This commit is contained in:
Nikita Bobko
2023-01-13 09:34:55 +01:00
committed by Space Team
parent 07525fef51
commit 887547c445
10 changed files with 9 additions and 646 deletions
@@ -200,7 +200,6 @@ task sanity {
dependsOn(tasksOf(FrameworkTest) { task ->
!UtilsKt.isDependsOnPlatformLibs(task)
})
dependsOn(tasksOf(MetadataComparisonTest))
// Add regular gradle test tasks
dependsOn(tasksOf(Test))
dependsOn(tasksOf(CoverageTest))
@@ -6129,18 +6128,6 @@ if (UtilsKt.getTestTargetSupportsCodeCoverage(project)) {
}
}
tasks.register("metadata_compare_typedefs", MetadataComparisonTest) {
UtilsKt.dependsOnDist(it)
enabled = (project.testTarget != 'wasm32')
defFile = "interop/basics/typedefs.def"
}
tasks.register("metadata_compare_unable_to_import", MetadataComparisonTest) {
UtilsKt.dependsOnDist(it)
enabled = (project.testTarget != 'wasm32')
defFile = "interop/basics/unable_to_import.def"
}
standaloneTest("local_ea_arraysfieldwrite") {
disabled = (cacheTesting != null) // Cache is not compatible with -opt.
useGoldenData = true