diff --git a/idea/src/org/jetbrains/jet/plugin/refactoring/extractFunction/extractableAnalysisUtil.kt b/idea/src/org/jetbrains/jet/plugin/refactoring/extractFunction/extractableAnalysisUtil.kt index 58ceff42c40..a0f5c187caf 100644 --- a/idea/src/org/jetbrains/jet/plugin/refactoring/extractFunction/extractableAnalysisUtil.kt +++ b/idea/src/org/jetbrains/jet/plugin/refactoring/extractFunction/extractableAnalysisUtil.kt @@ -731,7 +731,8 @@ fun ExtractionData.performAnalysis(): AnalysisResult { ) controlFlowMessage?.let { messages.add(it) } - controlFlow.outputValueBoxer.returnType.processTypeIfExtractable(paramsInfo.typeParameters, paramsInfo.nonDenotableTypes) + val returnType = controlFlow.outputValueBoxer.returnType + returnType.processTypeIfExtractable(paramsInfo.typeParameters, paramsInfo.nonDenotableTypes) if (paramsInfo.nonDenotableTypes.isNotEmpty()) { val typeStr = paramsInfo.nonDenotableTypes.map {it.renderForMessage()}.sort() @@ -751,10 +752,9 @@ fun ExtractionData.performAnalysis(): AnalysisResult { if (targetSibling is JetClassInitializer) targetSibling.getParent() else targetSibling, JetNameValidatorImpl.Target.FUNCTIONS_AND_CLASSES ) - val functionName = JetNameSuggester.suggestNames( - controlFlow.outputValueBoxer.returnType, - functionNameValidator, DEFAULT_FUNCTION_NAME - ).first() + val functionName = if (returnType.isDefault()) "" else { + JetNameSuggester.suggestNames(returnType, functionNameValidator, DEFAULT_FUNCTION_NAME).first() + } controlFlow.jumpOutputValue?.elementToInsertAfterCall?.accept( object : JetTreeVisitorVoid() { diff --git a/idea/src/org/jetbrains/jet/plugin/refactoring/extractFunction/extractorUtil.kt b/idea/src/org/jetbrains/jet/plugin/refactoring/extractFunction/extractorUtil.kt index ac3125dcccc..ce59eaa328d 100644 --- a/idea/src/org/jetbrains/jet/plugin/refactoring/extractFunction/extractorUtil.kt +++ b/idea/src/org/jetbrains/jet/plugin/refactoring/extractFunction/extractorUtil.kt @@ -81,7 +81,7 @@ fun ExtractableCodeDescriptor.getDeclarationText( receiverParameter?.let { builder.receiver(descriptorRenderer.renderType(it.parameterType)) } - builder.name(name) + builder.name(if (name != "") name else DEFAULT_FUNCTION_NAME) parameters.forEach { parameter -> builder.param(parameter.name, descriptorRenderer.renderType(parameter.parameterType)) diff --git a/idea/testData/refactoring/extractFunction/basic/extensionFunForArray.kt.after b/idea/testData/refactoring/extractFunction/basic/extensionFunForArray.kt.after index d177cd87ec8..7a981f7aa96 100644 --- a/idea/testData/refactoring/extractFunction/basic/extensionFunForArray.kt.after +++ b/idea/testData/refactoring/extractFunction/basic/extensionFunForArray.kt.after @@ -2,9 +2,9 @@ // PARAM_DESCRIPTOR: internal fun kotlin.Array.test(): kotlin.Unit defined in root package // SIBLING: fun Array.test() { - unit() + __dummyTestFun__() } -private fun Array.unit() { +private fun Array.__dummyTestFun__() { this.isEmpty() -} +} \ No newline at end of file diff --git a/idea/testData/refactoring/extractFunction/controlFlow/conditionalJumps/unconditionalBreakWithIf.kt.after b/idea/testData/refactoring/extractFunction/controlFlow/conditionalJumps/unconditionalBreakWithIf.kt.after index 889ad19b5a8..5d50aba876e 100644 --- a/idea/testData/refactoring/extractFunction/controlFlow/conditionalJumps/unconditionalBreakWithIf.kt.after +++ b/idea/testData/refactoring/extractFunction/controlFlow/conditionalJumps/unconditionalBreakWithIf.kt.after @@ -6,13 +6,13 @@ fun foo(a: Int): Int { val b: Int = 1 for (n in 1..a) { - unit(a, b) + __dummyTestFun__(a, b) break } return 1 } -private fun unit(a: Int, b: Int) { +private fun __dummyTestFun__(a: Int, b: Int) { if (a + b > 0) return println(a - b) return diff --git a/idea/testData/refactoring/extractFunction/controlFlow/conditionalJumps/unconditionalBreakWithIfElse.kt.after b/idea/testData/refactoring/extractFunction/controlFlow/conditionalJumps/unconditionalBreakWithIfElse.kt.after index c1e276317f6..58051b9dc61 100644 --- a/idea/testData/refactoring/extractFunction/controlFlow/conditionalJumps/unconditionalBreakWithIfElse.kt.after +++ b/idea/testData/refactoring/extractFunction/controlFlow/conditionalJumps/unconditionalBreakWithIfElse.kt.after @@ -6,13 +6,13 @@ fun foo(a: Int): Int { val b: Int = 1 for (n in 1..a) { - unit(a, b) + __dummyTestFun__(a, b) break } return 1 } -private fun unit(a: Int, b: Int) { +private fun __dummyTestFun__(a: Int, b: Int) { if (a + b > 0) return else { println(a - b) diff --git a/idea/testData/refactoring/extractFunction/controlFlow/conditionalJumps/unconditionalBreakWithWhen.kt.after b/idea/testData/refactoring/extractFunction/controlFlow/conditionalJumps/unconditionalBreakWithWhen.kt.after index 0c6ea3af527..6733aaf952a 100644 --- a/idea/testData/refactoring/extractFunction/controlFlow/conditionalJumps/unconditionalBreakWithWhen.kt.after +++ b/idea/testData/refactoring/extractFunction/controlFlow/conditionalJumps/unconditionalBreakWithWhen.kt.after @@ -6,13 +6,13 @@ fun foo(a: Int): Int { val b: Int = 1 for (n in 1..a) { - unit(a, b) + __dummyTestFun__(a, b) break } return 1 } -private fun unit(a: Int, b: Int) { +private fun __dummyTestFun__(a: Int, b: Int) { when { a + b > 0 -> return a - b > 0 -> return diff --git a/idea/testData/refactoring/extractFunction/controlFlow/default/defaultCF.kt.after b/idea/testData/refactoring/extractFunction/controlFlow/default/defaultCF.kt.after index dbdcceae1e7..dbc8cc35cc8 100644 --- a/idea/testData/refactoring/extractFunction/controlFlow/default/defaultCF.kt.after +++ b/idea/testData/refactoring/extractFunction/controlFlow/default/defaultCF.kt.after @@ -7,10 +7,10 @@ fun foo(a: Int) { val b: Int = 1 - unit(a, b) + __dummyTestFun__(a, b) } -private fun unit(a: Int, b: Int) { +private fun __dummyTestFun__(a: Int, b: Int) { if (a > 0) { println(a) } diff --git a/idea/testData/refactoring/extractFunction/controlFlow/default/defaultCFWithExtraVars.kt.after b/idea/testData/refactoring/extractFunction/controlFlow/default/defaultCFWithExtraVars.kt.after index 512205af878..c25d97b76d5 100644 --- a/idea/testData/refactoring/extractFunction/controlFlow/default/defaultCFWithExtraVars.kt.after +++ b/idea/testData/refactoring/extractFunction/controlFlow/default/defaultCFWithExtraVars.kt.after @@ -8,13 +8,13 @@ fun foo(a: Int) { val b: Int = 1 val c: Int - unit(a, b) + __dummyTestFun__(a, b) c = 1 println(c) } -private fun unit(a: Int, b: Int) { +private fun __dummyTestFun__(a: Int, b: Int) { if (a > 0) { println(a) } diff --git a/idea/testData/refactoring/extractFunction/controlFlow/default/defaultCFWithJumps.kt.after b/idea/testData/refactoring/extractFunction/controlFlow/default/defaultCFWithJumps.kt.after index cae5d7bf1ef..b6978c31d84 100644 --- a/idea/testData/refactoring/extractFunction/controlFlow/default/defaultCFWithJumps.kt.after +++ b/idea/testData/refactoring/extractFunction/controlFlow/default/defaultCFWithJumps.kt.after @@ -4,10 +4,10 @@ fun foo(a: Int) { val b: Int = 1 - unit(a) + __dummyTestFun__(a) } -private fun unit(a: Int) { +private fun __dummyTestFun__(a: Int) { var t = a while (t > 0) { if (t == 2) continue diff --git a/idea/testData/refactoring/extractFunction/controlFlow/default/ignoredReturnValueWithIf.kt.after b/idea/testData/refactoring/extractFunction/controlFlow/default/ignoredReturnValueWithIf.kt.after index a0b534e7e34..e68e8efbdb2 100644 --- a/idea/testData/refactoring/extractFunction/controlFlow/default/ignoredReturnValueWithIf.kt.after +++ b/idea/testData/refactoring/extractFunction/controlFlow/default/ignoredReturnValueWithIf.kt.after @@ -11,11 +11,11 @@ fun bar(a: Int): Int { fun foo(a: Int) { val b: Int = 1 - unit(a, b) + __dummyTestFun__(a, b) } -private fun unit(a: Int, b: Int) { +private fun __dummyTestFun__(a: Int, b: Int) { if (a > 0) { bar(a) } else { diff --git a/idea/testData/refactoring/extractFunction/controlFlow/default/ignoredReturnValueWithIfNoBlocks.kt.after b/idea/testData/refactoring/extractFunction/controlFlow/default/ignoredReturnValueWithIfNoBlocks.kt.after index b3dc70346ff..c796f5bd08a 100644 --- a/idea/testData/refactoring/extractFunction/controlFlow/default/ignoredReturnValueWithIfNoBlocks.kt.after +++ b/idea/testData/refactoring/extractFunction/controlFlow/default/ignoredReturnValueWithIfNoBlocks.kt.after @@ -11,9 +11,9 @@ fun bar(a: Int): Int { fun foo(a: Int) { val b: Int = 1 - unit(a, b) + __dummyTestFun__(a, b) } -private fun unit(a: Int, b: Int) { +private fun __dummyTestFun__(a: Int, b: Int) { if (a > 0) bar(a) else b } diff --git a/idea/testData/refactoring/extractFunction/controlFlow/default/ignoredReturnValueWithWhen.kt.after b/idea/testData/refactoring/extractFunction/controlFlow/default/ignoredReturnValueWithWhen.kt.after index c0817f59244..43f4427ae55 100644 --- a/idea/testData/refactoring/extractFunction/controlFlow/default/ignoredReturnValueWithWhen.kt.after +++ b/idea/testData/refactoring/extractFunction/controlFlow/default/ignoredReturnValueWithWhen.kt.after @@ -11,11 +11,11 @@ fun bar(a: Int): Int { fun foo(a: Int) { val b: Int = 1 - unit(a, b) + __dummyTestFun__(a, b) } -private fun unit(a: Int, b: Int) { +private fun __dummyTestFun__(a: Int, b: Int) { when { a > 0 -> { bar(a) diff --git a/idea/testData/refactoring/extractFunction/controlFlow/default/ignoredReturnValueWithWhenNoBlocks.kt.after b/idea/testData/refactoring/extractFunction/controlFlow/default/ignoredReturnValueWithWhenNoBlocks.kt.after index 443ae9f4de7..7f235f6f272 100644 --- a/idea/testData/refactoring/extractFunction/controlFlow/default/ignoredReturnValueWithWhenNoBlocks.kt.after +++ b/idea/testData/refactoring/extractFunction/controlFlow/default/ignoredReturnValueWithWhenNoBlocks.kt.after @@ -11,11 +11,11 @@ fun bar(a: Int): Int { fun foo(a: Int) { val b: Int = 1 - unit(a, b) + __dummyTestFun__(a, b) } -private fun unit(a: Int, b: Int) { +private fun __dummyTestFun__(a: Int, b: Int) { when { a > 0 -> bar(a) else -> b diff --git a/idea/testData/refactoring/extractFunction/controlFlow/outputValues/valuesUsedInLambdaOnly.kt.after b/idea/testData/refactoring/extractFunction/controlFlow/outputValues/valuesUsedInLambdaOnly.kt.after index 9d2c3bacb17..733cd18e33a 100644 --- a/idea/testData/refactoring/extractFunction/controlFlow/outputValues/valuesUsedInLambdaOnly.kt.after +++ b/idea/testData/refactoring/extractFunction/controlFlow/outputValues/valuesUsedInLambdaOnly.kt.after @@ -2,10 +2,10 @@ class T(val n: Int) // SIBLING: fun foo() { - unit() + __dummyTestFun__() } -private fun unit() { +private fun __dummyTestFun__() { bar { t -> val k = 1 t.n + k + 1 diff --git a/idea/testData/refactoring/extractFunction/controlFlow/outputValues/valuesUsedInNestedBlock.kt.after b/idea/testData/refactoring/extractFunction/controlFlow/outputValues/valuesUsedInNestedBlock.kt.after index 504372865a5..8c9a493acfd 100644 --- a/idea/testData/refactoring/extractFunction/controlFlow/outputValues/valuesUsedInNestedBlock.kt.after +++ b/idea/testData/refactoring/extractFunction/controlFlow/outputValues/valuesUsedInNestedBlock.kt.after @@ -2,10 +2,10 @@ class T(val n: Int) // SIBLING: fun foo() { - unit() + __dummyTestFun__() } -private fun unit() { +private fun __dummyTestFun__() { if (true) { val k = 1 T().n + k + 1 diff --git a/idea/testData/refactoring/extractFunction/duplicates/defaultCF.kt.after b/idea/testData/refactoring/extractFunction/duplicates/defaultCF.kt.after index b7e3c2ba065..8e2ba6097ac 100644 --- a/idea/testData/refactoring/extractFunction/duplicates/defaultCF.kt.after +++ b/idea/testData/refactoring/extractFunction/duplicates/defaultCF.kt.after @@ -5,17 +5,17 @@ // SIBLING: fun foo(a: Int, b: Int) { - unit(a, b) + __dummyTestFun__(a, b) } fun bar() { val x = 1 val y = 2 - unit(x, y) + __dummyTestFun__(x, y) } -private fun unit(a: Int, b: Int) { +private fun __dummyTestFun__(a: Int, b: Int) { println("a = $a") println("b = $b") println(a + b * a) diff --git a/idea/testData/refactoring/extractFunction/initializers/properties/nestedInMultiDeclaration.kt.after b/idea/testData/refactoring/extractFunction/initializers/properties/nestedInMultiDeclaration.kt.after index afefca832d0..f01da303afc 100644 --- a/idea/testData/refactoring/extractFunction/initializers/properties/nestedInMultiDeclaration.kt.after +++ b/idea/testData/refactoring/extractFunction/initializers/properties/nestedInMultiDeclaration.kt.after @@ -3,13 +3,13 @@ fun foo() { val (a, b) = if (true) { - unit() + __dummyTestFun__() 1 to 2 } else { 2 to 3 } } -private fun unit() { +private fun __dummyTestFun__() { 1 + 1 } \ No newline at end of file diff --git a/idea/testData/refactoring/extractFunction/parameters/candidateTypes/liftAnonymousToSupertype1.kt.after b/idea/testData/refactoring/extractFunction/parameters/candidateTypes/liftAnonymousToSupertype1.kt.after index 8f05fd89c8b..dbd6495178e 100644 --- a/idea/testData/refactoring/extractFunction/parameters/candidateTypes/liftAnonymousToSupertype1.kt.after +++ b/idea/testData/refactoring/extractFunction/parameters/candidateTypes/liftAnonymousToSupertype1.kt.after @@ -5,10 +5,10 @@ // SIBLING: val x = object { fun test() { - unit() + __dummyTestFun__() } } -private fun Any.unit() { +private fun Any.__dummyTestFun__() { println(this) } \ No newline at end of file diff --git a/idea/testData/refactoring/extractFunction/parameters/candidateTypes/liftAnonymousToSupertype2.kt.after b/idea/testData/refactoring/extractFunction/parameters/candidateTypes/liftAnonymousToSupertype2.kt.after index dbb6c7133f5..083b30f0d88 100644 --- a/idea/testData/refactoring/extractFunction/parameters/candidateTypes/liftAnonymousToSupertype2.kt.after +++ b/idea/testData/refactoring/extractFunction/parameters/candidateTypes/liftAnonymousToSupertype2.kt.after @@ -13,9 +13,9 @@ fun foo(a: A) { // SIBLING: fun test() { val x = object: A() { } - unit(x) + __dummyTestFun__(x) } -private fun unit(x: A) { +private fun __dummyTestFun__(x: A) { foo(x) } \ No newline at end of file diff --git a/idea/testData/refactoring/extractFunction/parameters/candidateTypes/nonNullableTypes.kt.after b/idea/testData/refactoring/extractFunction/parameters/candidateTypes/nonNullableTypes.kt.after index 15b0019ac81..8237fd1982d 100644 --- a/idea/testData/refactoring/extractFunction/parameters/candidateTypes/nonNullableTypes.kt.after +++ b/idea/testData/refactoring/extractFunction/parameters/candidateTypes/nonNullableTypes.kt.after @@ -11,10 +11,10 @@ class X { // SIBLING: fun foo(s: String?, x: X) { when { - s != null -> unit(s, x) + s != null -> __dummyTestFun__(s, x) } } -private fun unit(s: String, x: X) { +private fun __dummyTestFun__(s: String, x: X) { x.add(s) } \ No newline at end of file diff --git a/idea/testData/refactoring/extractFunction/parameters/candidateTypes/nullableTypes.kt.after b/idea/testData/refactoring/extractFunction/parameters/candidateTypes/nullableTypes.kt.after index fa7602cd4fa..f89cf64be31 100644 --- a/idea/testData/refactoring/extractFunction/parameters/candidateTypes/nullableTypes.kt.after +++ b/idea/testData/refactoring/extractFunction/parameters/candidateTypes/nullableTypes.kt.after @@ -11,10 +11,10 @@ class X { // SIBLING: fun foo(s: String?, x: X) { when { - s != null -> unit(s, x) + s != null -> __dummyTestFun__(s, x) } } -private fun unit(s: String?, x: X) { +private fun __dummyTestFun__(s: String?, x: X) { x.add(s) } \ No newline at end of file diff --git a/idea/testData/refactoring/extractFunction/parameters/candidateTypes/typeHierarchy1.kt.after b/idea/testData/refactoring/extractFunction/parameters/candidateTypes/typeHierarchy1.kt.after index 2218fb879aa..b9fb11952dc 100644 --- a/idea/testData/refactoring/extractFunction/parameters/candidateTypes/typeHierarchy1.kt.after +++ b/idea/testData/refactoring/extractFunction/parameters/candidateTypes/typeHierarchy1.kt.after @@ -30,11 +30,11 @@ class C: AImpl(), B { // SIBLING: fun foo(c: C) { - unit(c) + __dummyTestFun__(c) c.doB() c.doC() } -private fun unit(c: C) { +private fun __dummyTestFun__(c: C) { c.doA() } \ No newline at end of file diff --git a/idea/testData/refactoring/extractFunction/parameters/candidateTypes/typeHierarchy2.kt.after b/idea/testData/refactoring/extractFunction/parameters/candidateTypes/typeHierarchy2.kt.after index 92ab1f15b70..965680aa0e9 100644 --- a/idea/testData/refactoring/extractFunction/parameters/candidateTypes/typeHierarchy2.kt.after +++ b/idea/testData/refactoring/extractFunction/parameters/candidateTypes/typeHierarchy2.kt.after @@ -31,10 +31,10 @@ class C: AImpl(), B { // SIBLING: fun foo(c: C) { c.doA() - unit(c) + __dummyTestFun__(c) c.doC() } -private fun unit(c: C) { +private fun __dummyTestFun__(c: C) { c.doB() } \ No newline at end of file diff --git a/idea/testData/refactoring/extractFunction/parameters/candidateTypes/typeHierarchy3.kt.after b/idea/testData/refactoring/extractFunction/parameters/candidateTypes/typeHierarchy3.kt.after index 261440e3ab1..1aa8b3d30dc 100644 --- a/idea/testData/refactoring/extractFunction/parameters/candidateTypes/typeHierarchy3.kt.after +++ b/idea/testData/refactoring/extractFunction/parameters/candidateTypes/typeHierarchy3.kt.after @@ -32,9 +32,9 @@ class C: AImpl(), B { fun foo(c: C) { c.doA() c.doB() - unit(c) + __dummyTestFun__(c) } -private fun unit(c: C) { +private fun __dummyTestFun__(c: C) { c.doC() } \ No newline at end of file diff --git a/idea/testData/refactoring/extractFunction/parameters/candidateTypes/typeHierarchy4.kt.after b/idea/testData/refactoring/extractFunction/parameters/candidateTypes/typeHierarchy4.kt.after index d68fceb28bd..4306a33fadb 100644 --- a/idea/testData/refactoring/extractFunction/parameters/candidateTypes/typeHierarchy4.kt.after +++ b/idea/testData/refactoring/extractFunction/parameters/candidateTypes/typeHierarchy4.kt.after @@ -30,11 +30,11 @@ class C: AImpl(), B { // SIBLING: fun foo(c: C) { - unit(c) + __dummyTestFun__(c) c.doC() } -private fun unit(c: C) { +private fun __dummyTestFun__(c: C) { c.doA() c.doB() } \ No newline at end of file diff --git a/idea/testData/refactoring/extractFunction/parameters/misc/multiDeclaration.kt.after b/idea/testData/refactoring/extractFunction/parameters/misc/multiDeclaration.kt.after index 6fafc150a50..d280c602528 100644 --- a/idea/testData/refactoring/extractFunction/parameters/misc/multiDeclaration.kt.after +++ b/idea/testData/refactoring/extractFunction/parameters/misc/multiDeclaration.kt.after @@ -3,10 +3,10 @@ // SIBLING: fun main(args: Array) { val (a, b) = Data(1, 2) - unit(a) + __dummyTestFun__(a) } -private fun unit(a: Int) { +private fun __dummyTestFun__(a: Int) { a } diff --git a/idea/testData/refactoring/extractFunction/parameters/misc/qualifiedAnnotation.kt.after b/idea/testData/refactoring/extractFunction/parameters/misc/qualifiedAnnotation.kt.after index 0e86ee905d0..2fb76bc2192 100644 --- a/idea/testData/refactoring/extractFunction/parameters/misc/qualifiedAnnotation.kt.after +++ b/idea/testData/refactoring/extractFunction/parameters/misc/qualifiedAnnotation.kt.after @@ -1,13 +1,13 @@ // SIBLING: class MyClass { fun test() { - unit() + __dummyTestFun__() } public annotation class P } -private fun unit() { +private fun __dummyTestFun__() { [MyClass.P] val t: Int = 1 t } \ No newline at end of file diff --git a/idea/testData/refactoring/extractFunction/parameters/misc/qualifiedClassObject.kt.after b/idea/testData/refactoring/extractFunction/parameters/misc/qualifiedClassObject.kt.after index 7606de1536a..3df31d608c4 100644 --- a/idea/testData/refactoring/extractFunction/parameters/misc/qualifiedClassObject.kt.after +++ b/idea/testData/refactoring/extractFunction/parameters/misc/qualifiedClassObject.kt.after @@ -1,7 +1,7 @@ // SIBLING: class MyClass { fun test() { - unit() + __dummyTestFun__() } public class P { @@ -12,7 +12,7 @@ class MyClass { } } -private fun unit() { +private fun __dummyTestFun__() { MyClass.P.foo() MyClass.P.a } \ No newline at end of file diff --git a/idea/testData/refactoring/extractFunction/parameters/misc/qualifiedEnum.kt.after b/idea/testData/refactoring/extractFunction/parameters/misc/qualifiedEnum.kt.after index 37a102224a7..4c2fd2d01a7 100644 --- a/idea/testData/refactoring/extractFunction/parameters/misc/qualifiedEnum.kt.after +++ b/idea/testData/refactoring/extractFunction/parameters/misc/qualifiedEnum.kt.after @@ -1,7 +1,7 @@ // SIBLING: class MyClass { fun test() { - unit() + __dummyTestFun__() } enum class P { @@ -12,7 +12,7 @@ class MyClass { } } -private fun unit() { +private fun __dummyTestFun__() { MyClass.P.A.foo() MyClass.P.A.a } \ No newline at end of file diff --git a/idea/testData/refactoring/extractFunction/parameters/misc/qualifiedObject.kt.after b/idea/testData/refactoring/extractFunction/parameters/misc/qualifiedObject.kt.after index a436ceca5d7..a8dacbd27d5 100644 --- a/idea/testData/refactoring/extractFunction/parameters/misc/qualifiedObject.kt.after +++ b/idea/testData/refactoring/extractFunction/parameters/misc/qualifiedObject.kt.after @@ -1,7 +1,7 @@ // SIBLING: class MyClass { fun test() { - unit() + __dummyTestFun__() } object P { @@ -10,7 +10,7 @@ class MyClass { } } -private fun unit() { +private fun __dummyTestFun__() { MyClass.P.foo() MyClass.P.a } \ No newline at end of file diff --git a/idea/testData/refactoring/extractFunction/parameters/misc/qualifiedPackage.kt.after b/idea/testData/refactoring/extractFunction/parameters/misc/qualifiedPackage.kt.after index 10bc51bf7cb..a2d05f9eb33 100644 --- a/idea/testData/refactoring/extractFunction/parameters/misc/qualifiedPackage.kt.after +++ b/idea/testData/refactoring/extractFunction/parameters/misc/qualifiedPackage.kt.after @@ -6,11 +6,11 @@ fun foo() = 1 // SIBLING: class MyClass { fun test() { - unit() + __dummyTestFun__() } } -private fun unit() { +private fun __dummyTestFun__() { foo() a } \ No newline at end of file diff --git a/idea/testData/refactoring/extractFunction/parameters/misc/qualifiedTypeArg.kt.after b/idea/testData/refactoring/extractFunction/parameters/misc/qualifiedTypeArg.kt.after index ad14a712a1e..753fce59893 100644 --- a/idea/testData/refactoring/extractFunction/parameters/misc/qualifiedTypeArg.kt.after +++ b/idea/testData/refactoring/extractFunction/parameters/misc/qualifiedTypeArg.kt.after @@ -1,7 +1,7 @@ // SIBLING: class MyClass { fun test() { - unit() + __dummyTestFun__() } public class P { @@ -11,6 +11,6 @@ class MyClass { } } -private fun unit() { +private fun __dummyTestFun__() { val t: MyClass.P? = null } \ No newline at end of file diff --git a/idea/testData/refactoring/extractFunction/parameters/misc/qualifiedTypeInValueArg.kt.after b/idea/testData/refactoring/extractFunction/parameters/misc/qualifiedTypeInValueArg.kt.after index dcfb19979b8..386d65b7e2a 100644 --- a/idea/testData/refactoring/extractFunction/parameters/misc/qualifiedTypeInValueArg.kt.after +++ b/idea/testData/refactoring/extractFunction/parameters/misc/qualifiedTypeInValueArg.kt.after @@ -1,7 +1,7 @@ // SIBLING: class MyClass { fun test() { - unit() + __dummyTestFun__() } public class P { @@ -15,7 +15,7 @@ class MyClass { } } -private fun unit() { +private fun __dummyTestFun__() { val a: Any = MyClass.P.Q() val t = MyClass.P.R(a as MyClass.P.Q) } \ No newline at end of file diff --git a/idea/testData/refactoring/extractFunction/parameters/misc/qualifiedTypeRef.kt.after b/idea/testData/refactoring/extractFunction/parameters/misc/qualifiedTypeRef.kt.after index 39821265341..edf2e290233 100644 --- a/idea/testData/refactoring/extractFunction/parameters/misc/qualifiedTypeRef.kt.after +++ b/idea/testData/refactoring/extractFunction/parameters/misc/qualifiedTypeRef.kt.after @@ -1,7 +1,7 @@ // SIBLING: class MyClass { fun test() { - unit() + __dummyTestFun__() } public class P { @@ -11,7 +11,7 @@ class MyClass { } } -private fun unit() { +private fun __dummyTestFun__() { val t: MyClass.P.Q = MyClass.P.Q() t } \ No newline at end of file diff --git a/idea/testData/refactoring/extractFunction/parameters/misc/thisInObject.kt.after b/idea/testData/refactoring/extractFunction/parameters/misc/thisInObject.kt.after index f3ad7b8a0c8..dbec223dd11 100644 --- a/idea/testData/refactoring/extractFunction/parameters/misc/thisInObject.kt.after +++ b/idea/testData/refactoring/extractFunction/parameters/misc/thisInObject.kt.after @@ -4,10 +4,10 @@ package p object O { val a = 1 fun test() { - unit() + __dummyTestFun__() } } -private fun unit() { +private fun __dummyTestFun__() { O.a } \ No newline at end of file diff --git a/idea/testData/refactoring/extractFunction/parameters/misc/typeRef.kt.after b/idea/testData/refactoring/extractFunction/parameters/misc/typeRef.kt.after index e851008526e..3a6fcf4dce6 100644 --- a/idea/testData/refactoring/extractFunction/parameters/misc/typeRef.kt.after +++ b/idea/testData/refactoring/extractFunction/parameters/misc/typeRef.kt.after @@ -1,13 +1,13 @@ // SIBLING: class MyClass { fun test() { - unit() + __dummyTestFun__() } public class P } -private fun unit() { +private fun __dummyTestFun__() { val t: MyClass.P = MyClass.P() t } \ No newline at end of file diff --git a/idea/testData/refactoring/extractFunction/parameters/misc/variableAsFunction.kt.after b/idea/testData/refactoring/extractFunction/parameters/misc/variableAsFunction.kt.after index 83d5d8c066c..f41c5458e53 100644 --- a/idea/testData/refactoring/extractFunction/parameters/misc/variableAsFunction.kt.after +++ b/idea/testData/refactoring/extractFunction/parameters/misc/variableAsFunction.kt.after @@ -6,9 +6,9 @@ class A { // SIBLING: fun testProp() { val foo = A() - unit(foo) + __dummyTestFun__(foo) } -private fun unit(foo: A) { +private fun __dummyTestFun__(foo: A) { foo() } \ No newline at end of file diff --git a/idea/tests/org/jetbrains/jet/plugin/refactoring/introduce/introduceVariable/AbstractJetExtractionTest.kt b/idea/tests/org/jetbrains/jet/plugin/refactoring/introduce/introduceVariable/AbstractJetExtractionTest.kt index 1d4f8bd5143..47f8ae7a788 100644 --- a/idea/tests/org/jetbrains/jet/plugin/refactoring/introduce/introduceVariable/AbstractJetExtractionTest.kt +++ b/idea/tests/org/jetbrains/jet/plugin/refactoring/introduce/introduceVariable/AbstractJetExtractionTest.kt @@ -125,7 +125,7 @@ public abstract class AbstractJetExtractionTest() : JetLightCodeInsightFixtureTe assertEquals(expectedDescriptors, actualDescriptors, "Expected descriptors mismatch.") assertEquals(expectedTypes, actualTypes, "Expected types mismatch.") - return descriptor + return if (descriptor.name == "") descriptor.copy(name = "__dummyTestFun__") else descriptor } } ).doInvoke(editor, file, elements, explicitPreviousSibling ?: previousSibling)