JS: fix absence of temporary variable in secondary constructors. See KT-16377

js/js.translator/src/org/jetbrains/kotlin/js/translate/declaration/ClassTranslator.kt

@@ -217,13 +217,14 @@ class ClassTranslator private constructor(
         val constructorInitializer = context.getFunctionObject(constructorDescriptor)
         constructorInitializer.name = context.getInnerNameForDescriptor(constructorDescriptor)
         context.addDeclarationStatement(constructorInitializer.makeStmt())
+
+        context = context.contextWithScope(constructorInitializer)
         context.translateAndAliasParameters(constructorDescriptor, constructorInitializer.parameters)
                 .translateFunction(constructor, constructorInitializer)
 
         // Translate super/this call
         val superCallGenerators = mutableListOf<(MutableList<JsStatement>) -> Unit>()
         val referenceToClass = context.getInnerReference(classDescriptor)
-        context = context.contextWithScope(constructorInitializer)
 
         superCallGenerators += { it += FunctionBodyTranslator.setDefaultValueForArguments(constructorDescriptor, context) }
 

js/js.translator/testData/box/expression/evaluationOrder/secondaryConstructorTemporaryVars.kt

@@ -0,0 +1,22 @@
+// HAS_NO_CAPTURED_VARS: function=A_init except=Kotlin;A
+
+class A() {
+    var y: String? = null
+    var z: Any? = null
+
+    constructor(x: Any) : this() {
+        y = if (x == "foo") "!!!" else { z = x; ">>>" }
+    }
+}
+
+fun box(): String {
+    val a = A("foo")
+    if (a.y != "!!!") return "fail1: ${a.y}"
+    if (a.z != null) return "fail2: ${a.z}"
+
+    val b = A(23)
+    if (b.y != ">>>") return "fail3: ${b.y}"
+    if (b.z != 23) return "fail4: ${b.z}"
+
+    return "OK"
+}