diff --git a/jps/jps-plugin/src/org/jetbrains/kotlin/jps/build/KotlinBuilder.kt b/jps/jps-plugin/src/org/jetbrains/kotlin/jps/build/KotlinBuilder.kt index e7d99df6db9..5aceafc6d9e 100644 --- a/jps/jps-plugin/src/org/jetbrains/kotlin/jps/build/KotlinBuilder.kt +++ b/jps/jps-plugin/src/org/jetbrains/kotlin/jps/build/KotlinBuilder.kt @@ -87,6 +87,7 @@ public class KotlinBuilder : ModuleLevelBuilder(BuilderCategory.SOURCE_PROCESSOR override fun getCompilableFileExtensions() = arrayListOf("kt") override fun buildStarted(context: CompileContext) { + LOG.debug("==========================================") LOG.info("is Kotlin incremental compilation enabled: ${IncrementalCompilation.isEnabled()}") val historyLabel = context.getBuilderParameter("history label") @@ -101,6 +102,7 @@ public class KotlinBuilder : ModuleLevelBuilder(BuilderCategory.SOURCE_PROCESSOR dirtyFilesHolder: DirtyFilesHolder, outputConsumer: ModuleLevelBuilder.OutputConsumer ): ModuleLevelBuilder.ExitCode { + LOG.debug("------------------------------------------") val messageCollector = MessageCollectorAdapter(context) try { @@ -213,7 +215,9 @@ public class KotlinBuilder : ModuleLevelBuilder(BuilderCategory.SOURCE_PROCESSOR copyJsLibraryFilesIfNeeded(chunk, project) } - if (!IncrementalCompilation.isEnabled()) return OK + if (!IncrementalCompilation.isEnabled()) { + return OK + } val caches = filesToCompile.keySet().map { incrementalCaches[it]!! } val marker = ChangesProcessor(context, chunk, allCompiledFiles, caches) diff --git a/jps/jps-plugin/testData/incremental/multiModule/constantValueChanged/build.log b/jps/jps-plugin/testData/incremental/multiModule/constantValueChanged/build.log index 1b7e8ed2b89..0a36e429697 100644 --- a/jps/jps-plugin/testData/incremental/multiModule/constantValueChanged/build.log +++ b/jps/jps-plugin/testData/incremental/multiModule/constantValueChanged/build.log @@ -7,8 +7,16 @@ Compiling files: module1/src/module1_const.kt End of files Cleaning output files: +out/production/module1/META-INF/module1.kotlin_module +out/production/module1/test/Module1_constKt.class +out/production/module1/test/TestPackage.class +End of files +Compiling files: +module1/src/module1_const.kt +End of files +Cleaning output files: out/production/module2/usage/Usage.class End of files Compiling files: module2/src/module2_usage.kt -End of files \ No newline at end of file +End of files diff --git a/jps/jps-plugin/testData/incremental/multiModule/constantValueChanged/module1_const.kt b/jps/jps-plugin/testData/incremental/multiModule/constantValueChanged/module1_const.kt index e79d6d05129..3b7db43d11b 100644 --- a/jps/jps-plugin/testData/incremental/multiModule/constantValueChanged/module1_const.kt +++ b/jps/jps-plugin/testData/incremental/multiModule/constantValueChanged/module1_const.kt @@ -1,3 +1,3 @@ package test -public val CONST: String = "BF" +public const val CONST: String = "BF" diff --git a/jps/jps-plugin/testData/incremental/multiModule/constantValueChanged/module1_const.kt.new b/jps/jps-plugin/testData/incremental/multiModule/constantValueChanged/module1_const.kt.new index d6250846ebf..06509478371 100644 --- a/jps/jps-plugin/testData/incremental/multiModule/constantValueChanged/module1_const.kt.new +++ b/jps/jps-plugin/testData/incremental/multiModule/constantValueChanged/module1_const.kt.new @@ -1,3 +1,3 @@ package test -public val CONST: String = "Ae" +public const val CONST: String = "Ae" diff --git a/jps/jps-plugin/testData/incremental/pureKotlin/allConstants/build.log b/jps/jps-plugin/testData/incremental/pureKotlin/allConstants/build.log index 95a68077542..d7f5b678069 100644 --- a/jps/jps-plugin/testData/incremental/pureKotlin/allConstants/build.log +++ b/jps/jps-plugin/testData/incremental/pureKotlin/allConstants/build.log @@ -17,8 +17,12 @@ Compiling files: src/const.kt End of files Cleaning output files: +out/production/module/META-INF/module.kotlin_module +out/production/module/test/ConstKt.class +out/production/module/test/TestPackage.class out/production/module/test/Usage.class End of files Compiling files: +src/const.kt src/usage.kt -End of files \ No newline at end of file +End of files diff --git a/jps/jps-plugin/testData/incremental/pureKotlin/allConstants/const.kt b/jps/jps-plugin/testData/incremental/pureKotlin/allConstants/const.kt index d0d300c1312..73047748dac 100644 --- a/jps/jps-plugin/testData/incremental/pureKotlin/allConstants/const.kt +++ b/jps/jps-plugin/testData/incremental/pureKotlin/allConstants/const.kt @@ -1,12 +1,12 @@ package test -val b: Byte = 100 -val s: Short = 20000 -val i: Int = 2000000 -val l: Long = 2000000000000L -val f: Float = 3.14f -val d: Double = 3.14 -val bb: Boolean = true -val c: Char = '\u03c0' // pi symbol +const val b: Byte = 100 +const val s: Short = 20000 +const val i: Int = 2000000 +const val l: Long = 2000000000000L +const val f: Float = 3.14f +const val d: Double = 3.14 +const val bb: Boolean = true +const val c: Char = '\u03c0' // pi symbol -val str: String = ":)" +const val str: String = ":)" diff --git a/jps/jps-plugin/testData/incremental/pureKotlin/allConstants/const.kt.new.1 b/jps/jps-plugin/testData/incremental/pureKotlin/allConstants/const.kt.new.1 index 26796869ddc..9fe38e75928 100644 --- a/jps/jps-plugin/testData/incremental/pureKotlin/allConstants/const.kt.new.1 +++ b/jps/jps-plugin/testData/incremental/pureKotlin/allConstants/const.kt.new.1 @@ -1,12 +1,12 @@ package test -val b: Byte = 50 + 50 -val s: Short = 10000 + 10000 -val i: Int = 1000000 + 1000000 -val l: Long = 1000000000000L + 1000000000000L -val f: Float = 0.0f + 3.14f -val d: Double = 0.0 + 3.14 -val bb: Boolean = !false -val c: Char = '\u03c0' // pi symbol +const val b: Byte = 50 + 50 +const val s: Short = 10000 + 10000 +const val i: Int = 1000000 + 1000000 +const val l: Long = 1000000000000L + 1000000000000L +const val f: Float = 0.0f + 3.14f +const val d: Double = 0.0 + 3.14 +const val bb: Boolean = !false +const val c: Char = '\u03c0' // pi symbol -val str: String = ":)" +const val str: String = ":)" diff --git a/jps/jps-plugin/testData/incremental/pureKotlin/allConstants/const.kt.new.2 b/jps/jps-plugin/testData/incremental/pureKotlin/allConstants/const.kt.new.2 index 668b4009dce..d0df4060261 100644 --- a/jps/jps-plugin/testData/incremental/pureKotlin/allConstants/const.kt.new.2 +++ b/jps/jps-plugin/testData/incremental/pureKotlin/allConstants/const.kt.new.2 @@ -1,12 +1,12 @@ package test -val b: Byte = 0 -val s: Short = 0 -val i: Int = 0 -val l: Long = 0 -val f: Float = 0.0f -val d: Double = 0.0 -val bb: Boolean = false -val c: Char = 'x' +const val b: Byte = 0 +const val s: Short = 0 +const val i: Int = 0 +const val l: Long = 0 +const val f: Float = 0.0f +const val d: Double = 0.0 +const val bb: Boolean = false +const val c: Char = 'x' -val str: String = ":(" +const val str: String = ":(" diff --git a/jps/jps-plugin/testData/incremental/pureKotlin/classObjectConstantChanged/const.kt b/jps/jps-plugin/testData/incremental/pureKotlin/classObjectConstantChanged/const.kt index 4680ae2c26f..cd3256a7612 100644 --- a/jps/jps-plugin/testData/incremental/pureKotlin/classObjectConstantChanged/const.kt +++ b/jps/jps-plugin/testData/incremental/pureKotlin/classObjectConstantChanged/const.kt @@ -3,6 +3,6 @@ package test class Klass { companion object { // Old and new constant values are different, but their hashes are the same - val CONST = "BF" + const val CONST = "BF" } } diff --git a/jps/jps-plugin/testData/incremental/pureKotlin/classObjectConstantChanged/const.kt.new b/jps/jps-plugin/testData/incremental/pureKotlin/classObjectConstantChanged/const.kt.new index e9ccf1ab8db..49b604cd74f 100644 --- a/jps/jps-plugin/testData/incremental/pureKotlin/classObjectConstantChanged/const.kt.new +++ b/jps/jps-plugin/testData/incremental/pureKotlin/classObjectConstantChanged/const.kt.new @@ -3,6 +3,6 @@ package test class Klass { companion object { // Old and new constant values are different, but their hashes are the same - val CONST = "Ae" + const val CONST = "Ae" } } diff --git a/jps/jps-plugin/testData/incremental/pureKotlin/constantsUnchanged/const.kt b/jps/jps-plugin/testData/incremental/pureKotlin/constantsUnchanged/const.kt index 40bbe8de705..8bdd5ae5b5d 100644 --- a/jps/jps-plugin/testData/incremental/pureKotlin/constantsUnchanged/const.kt +++ b/jps/jps-plugin/testData/incremental/pureKotlin/constantsUnchanged/const.kt @@ -1,9 +1,9 @@ package test -val CONST = "foo" +const val CONST = "foo" class Klass { companion object { - val CONST = "bar" + const val CONST = "bar" } } diff --git a/jps/jps-plugin/testData/incremental/pureKotlin/constantsUnchanged/const.kt.new b/jps/jps-plugin/testData/incremental/pureKotlin/constantsUnchanged/const.kt.new index 40bbe8de705..8bdd5ae5b5d 100644 --- a/jps/jps-plugin/testData/incremental/pureKotlin/constantsUnchanged/const.kt.new +++ b/jps/jps-plugin/testData/incremental/pureKotlin/constantsUnchanged/const.kt.new @@ -1,9 +1,9 @@ package test -val CONST = "foo" +const val CONST = "foo" class Klass { companion object { - val CONST = "bar" + const val CONST = "bar" } } diff --git a/jps/jps-plugin/testData/incremental/pureKotlin/fileWithConstantRemoved/const.kt b/jps/jps-plugin/testData/incremental/pureKotlin/fileWithConstantRemoved/const.kt index 1572968f89f..c2cc75a6691 100644 --- a/jps/jps-plugin/testData/incremental/pureKotlin/fileWithConstantRemoved/const.kt +++ b/jps/jps-plugin/testData/incremental/pureKotlin/fileWithConstantRemoved/const.kt @@ -1,3 +1,3 @@ package test -val CONST = "foo" +const val CONST = "foo" diff --git a/jps/jps-plugin/testData/incremental/pureKotlin/objectConstantChanged/const.kt b/jps/jps-plugin/testData/incremental/pureKotlin/objectConstantChanged/const.kt index 13a01eb1ac1..18ba78875d7 100644 --- a/jps/jps-plugin/testData/incremental/pureKotlin/objectConstantChanged/const.kt +++ b/jps/jps-plugin/testData/incremental/pureKotlin/objectConstantChanged/const.kt @@ -1,5 +1,5 @@ package test object Object { - val CONST = "old" + const val CONST = "old" } diff --git a/jps/jps-plugin/testData/incremental/pureKotlin/objectConstantChanged/const.kt.new b/jps/jps-plugin/testData/incremental/pureKotlin/objectConstantChanged/const.kt.new index d604ca1244f..3c94cbcc28b 100644 --- a/jps/jps-plugin/testData/incremental/pureKotlin/objectConstantChanged/const.kt.new +++ b/jps/jps-plugin/testData/incremental/pureKotlin/objectConstantChanged/const.kt.new @@ -1,5 +1,5 @@ package test object Object { - val CONST = "new" + const val CONST = "new" } diff --git a/jps/jps-plugin/testData/incremental/pureKotlin/packageConstantChanged/build.log b/jps/jps-plugin/testData/incremental/pureKotlin/packageConstantChanged/build.log index ff943c45dd4..3e12fb327e1 100644 --- a/jps/jps-plugin/testData/incremental/pureKotlin/packageConstantChanged/build.log +++ b/jps/jps-plugin/testData/incremental/pureKotlin/packageConstantChanged/build.log @@ -7,8 +7,12 @@ Compiling files: src/const.kt End of files Cleaning output files: +out/production/module/META-INF/module.kotlin_module +out/production/module/test/ConstKt.class +out/production/module/test/TestPackage.class out/production/module/test/Usage.class End of files Compiling files: +src/const.kt src/usage.kt -End of files \ No newline at end of file +End of files diff --git a/jps/jps-plugin/testData/incremental/pureKotlin/packageConstantChanged/const.kt b/jps/jps-plugin/testData/incremental/pureKotlin/packageConstantChanged/const.kt index 62b4a2d0b23..cbc9ae86717 100644 --- a/jps/jps-plugin/testData/incremental/pureKotlin/packageConstantChanged/const.kt +++ b/jps/jps-plugin/testData/incremental/pureKotlin/packageConstantChanged/const.kt @@ -1,4 +1,4 @@ package test // Old and new constant values are different, but their hashes are the same -val CONST = "BF" +const val CONST = "BF" diff --git a/jps/jps-plugin/testData/incremental/pureKotlin/packageConstantChanged/const.kt.new b/jps/jps-plugin/testData/incremental/pureKotlin/packageConstantChanged/const.kt.new index bf471bbe0da..5d4d205f5a1 100644 --- a/jps/jps-plugin/testData/incremental/pureKotlin/packageConstantChanged/const.kt.new +++ b/jps/jps-plugin/testData/incremental/pureKotlin/packageConstantChanged/const.kt.new @@ -1,4 +1,4 @@ package test // Old and new constant values are different, but their hashes are the same -val CONST = "Ae" +const val CONST = "Ae" diff --git a/jps/jps-plugin/testData/incremental/pureKotlin/privateConstantsChanged/const.kt b/jps/jps-plugin/testData/incremental/pureKotlin/privateConstantsChanged/const.kt index 7f64be02734..9ab04e28aff 100644 --- a/jps/jps-plugin/testData/incremental/pureKotlin/privateConstantsChanged/const.kt +++ b/jps/jps-plugin/testData/incremental/pureKotlin/privateConstantsChanged/const.kt @@ -1,11 +1,11 @@ package test -val CONST = "foo" +const val CONST = "foo" class Klass { companion object { private val CHANGED = "old" - public val UNCHANGED = 100 + const public val UNCHANGED = 100 } } diff --git a/jps/jps-plugin/testData/incremental/pureKotlin/privateConstantsChanged/const.kt.new b/jps/jps-plugin/testData/incremental/pureKotlin/privateConstantsChanged/const.kt.new index 569acca03d0..83f620f0760 100644 --- a/jps/jps-plugin/testData/incremental/pureKotlin/privateConstantsChanged/const.kt.new +++ b/jps/jps-plugin/testData/incremental/pureKotlin/privateConstantsChanged/const.kt.new @@ -1,11 +1,11 @@ package test -val CONST = "foo" +const val CONST = "foo" class Klass { companion object { private val CHANGED = "new" - public val UNCHANGED = 100 + const public val UNCHANGED = 100 } }