KT-6834 Optimize Imports: do not modify file if import list had not change
#KT-6834 Fixed
This commit is contained in:
@@ -151,7 +151,8 @@ public class KotlinImportOptimizer() : ImportOptimizer {
|
|||||||
|
|
||||||
val sortedImportsToGenerate = importsToGenerate.sortBy(importInsertHelper.importSortComparator)
|
val sortedImportsToGenerate = importsToGenerate.sortBy(importInsertHelper.importSortComparator)
|
||||||
|
|
||||||
//TODO: do not touch file if everything is already correct?
|
// check if no changes to imports required
|
||||||
|
if (oldImports.size() == sortedImportsToGenerate.size() && oldImports.map { it.getImportPath() } == sortedImportsToGenerate) return
|
||||||
|
|
||||||
ApplicationManager.getApplication()!!.runWriteAction(Runnable {
|
ApplicationManager.getApplication()!!.runWriteAction(Runnable {
|
||||||
val importList = file.getImportList()!!
|
val importList = file.getImportList()!!
|
||||||
|
|||||||
@@ -0,0 +1,5 @@
|
|||||||
|
import java.util.ArrayList
|
||||||
|
// some comment
|
||||||
|
import java.util.HashSet
|
||||||
|
|
||||||
|
val v: HashSet<ArrayList<String>>
|
||||||
@@ -0,0 +1,5 @@
|
|||||||
|
import java.util.ArrayList
|
||||||
|
// some comment
|
||||||
|
import java.util.HashSet
|
||||||
|
|
||||||
|
val v: HashSet<ArrayList<String>>
|
||||||
@@ -81,6 +81,12 @@ public class OptimizeImportsTestGenerated extends AbstractOptimizeImportsTest {
|
|||||||
doTest(fileName);
|
doTest(fileName);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@TestMetadata("DoNotTouchIfNoChanges.kt")
|
||||||
|
public void testDoNotTouchIfNoChanges() throws Exception {
|
||||||
|
String fileName = JetTestUtils.navigationMetadata("idea/testData/editor/optimizeImports/DoNotTouchIfNoChanges.kt");
|
||||||
|
doTest(fileName);
|
||||||
|
}
|
||||||
|
|
||||||
@TestMetadata("DuplicatedImports.kt")
|
@TestMetadata("DuplicatedImports.kt")
|
||||||
public void testDuplicatedImports() throws Exception {
|
public void testDuplicatedImports() throws Exception {
|
||||||
String fileName = JetTestUtils.navigationMetadata("idea/testData/editor/optimizeImports/DuplicatedImports.kt");
|
String fileName = JetTestUtils.navigationMetadata("idea/testData/editor/optimizeImports/DuplicatedImports.kt");
|
||||||
|
|||||||
Reference in New Issue
Block a user