diff --git a/libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/BaseGradleIT.kt b/libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/BaseGradleIT.kt index 3ed8a1e226e..f472fb0ee85 100644 --- a/libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/BaseGradleIT.kt +++ b/libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/BaseGradleIT.kt @@ -153,13 +153,15 @@ abstract class BaseGradleIT { return wrapper } - fun mightUpdateSettingsScript(wrapperVersion: String, settingsScript: File) { + fun maybeUpdateSettingsScript(wrapperVersion: String, settingsScript: File) { // enableFeaturePreview("GRADLE_METADATA") is no longer needed when building with Gradle 5.4 or above - if (GradleVersion.version(wrapperVersion) > GradleVersion.version("5.3")) { + if (GradleVersion.version(wrapperVersion) >= GradleVersion.version("5.4")) { settingsScript.apply { if(exists()) { modify { it.replace("enableFeaturePreview('GRADLE_METADATA')", "//") + } + modify { it.replace("enableFeaturePreview(\"GRADLE_METADATA\")", "//") } } @@ -336,8 +338,6 @@ abstract class BaseGradleIT { val env = createEnvironmentVariablesMap(options) val wrapperDir = prepareWrapper(wrapperVersion, env) - mightUpdateSettingsScript(wrapperVersion, gradleSettingsScript()) - val cmd = createBuildCommand(wrapperDir, params, options) println("<=== Test build: ${this.projectName} $cmd ===>") @@ -346,6 +346,8 @@ abstract class BaseGradleIT { setupWorkingDir() } + maybeUpdateSettingsScript(wrapperVersion, gradleSettingsScript()) + val result = runProcess(cmd, projectDir, env, options) try { CompiledProject(this, result.output, result.exitCode).check() diff --git a/libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/ConfigurationCacheForAndroidIT.kt b/libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/ConfigurationCacheForAndroidIT.kt index f65b3335427..59344b3df39 100644 --- a/libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/ConfigurationCacheForAndroidIT.kt +++ b/libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/ConfigurationCacheForAndroidIT.kt @@ -19,8 +19,7 @@ class ConfigurationCacheForAndroidIT : AbstractConfigurationCacheIT() { androidHome = KotlinTestUtils.findAndroidSdk(), androidGradlePluginVersion = androidGradlePluginVersion, configurationCache = true, - configurationCacheProblems = ConfigurationCacheProblems.FAIL, - warningMode = WarningMode.Summary + configurationCacheProblems = ConfigurationCacheProblems.FAIL ) @Test @@ -39,7 +38,10 @@ class ConfigurationCacheForAndroidIT : AbstractConfigurationCacheIT() { @Test fun testKotlinAndroidProjectTests() = with(Project("AndroidIncrementalMultiModule")) { applyAndroid40Alpha4KotlinVersionWorkaround() - testConfigurationCacheOf(":app:compileDebugAndroidTestKotlin", ":app:compileDebugUnitTestKotlin") + testConfigurationCacheOf( + ":app:compileDebugAndroidTestKotlin", ":app:compileDebugUnitTestKotlin", + buildOptions = defaultBuildOptions().copy(warningMode = WarningMode.Summary) + ) } /** diff --git a/libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/ConfigurationCacheIT.kt b/libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/ConfigurationCacheIT.kt index 3bb76c5ec5a..fa18ab1ffd5 100644 --- a/libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/ConfigurationCacheIT.kt +++ b/libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/ConfigurationCacheIT.kt @@ -93,7 +93,7 @@ abstract class AbstractConfigurationCacheIT : BaseGradleIT() { checkInstantExecutionSucceeded() } - build("clean") { + build("clean", options = buildOptions) { assertSuccessful() } diff --git a/libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/KotlinGradlePluginIT.kt b/libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/KotlinGradlePluginIT.kt index 50b93b37d12..4494ee65b35 100644 --- a/libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/KotlinGradlePluginIT.kt +++ b/libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/KotlinGradlePluginIT.kt @@ -36,10 +36,6 @@ import kotlin.test.assertTrue class KotlinGradleIT : BaseGradleIT() { - override fun defaultBuildOptions(): BuildOptions { - return super.defaultBuildOptions().copy(warningMode = WarningMode.Summary) - } - @Test fun testCrossCompile() { val project = Project("kotlinJavaProject") @@ -395,7 +391,7 @@ class KotlinGradleIT : BaseGradleIT() { """.trimIndent() } - project.build("build", "install") { + project.build("build", "install", options = defaultBuildOptions().copy(warningMode = WarningMode.Summary)) { assertSuccessful() assertTasksExecuted(":compileKotlin", ":compileTestKotlin") val pomLines = File(project.projectDir, "build/poms/pom-default.xml").readLines() @@ -934,7 +930,7 @@ class KotlinGradleIT : BaseGradleIT() { setupWorkingDir() gradleBuildScript().modify(::transformBuildScriptWithPluginsDsl) - build("publish", "check", "runBenchmark") { + build("publish", "check", "runBenchmark", options = defaultBuildOptions().copy(warningMode = WarningMode.Summary)) { assertSuccessful() assertTasksExecuted(":compileKotlin", ":compileTestKotlin", ":compileBenchmarkKotlin", ":test", ":runBenchmark") diff --git a/libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/util/testResolveAllConfigurations.kt b/libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/util/testResolveAllConfigurations.kt index 35e9314189c..00a0becad39 100644 --- a/libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/util/testResolveAllConfigurations.kt +++ b/libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/util/testResolveAllConfigurations.kt @@ -5,6 +5,7 @@ package org.jetbrains.kotlin.gradle.util +import org.gradle.api.logging.configuration.WarningMode import org.jetbrains.kotlin.gradle.BaseGradleIT import kotlin.test.assertTrue @@ -31,7 +32,7 @@ fun BaseGradleIT.Project.testResolveAllConfigurations( } } - build(RESOLVE_ALL_CONFIGURATIONS_TASK_NAME) { + build(RESOLVE_ALL_CONFIGURATIONS_TASK_NAME, options = defaultBuildOptions().copy(warningMode = WarningMode.Summary)) { assertSuccessful() assertTasksExecuted(":${subproject?.let { "$it:" }.orEmpty()}$RESOLVE_ALL_CONFIGURATIONS_TASK_NAME") val unresolvedConfigurations = unresolvedConfigurationRegex.findAll(output).map { it.groupValues[1] }.toList() diff --git a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/plugin/KotlinMultiplatformPlugin.kt b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/plugin/KotlinMultiplatformPlugin.kt index 4bd2232a4da..6e0f78dce99 100644 --- a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/plugin/KotlinMultiplatformPlugin.kt +++ b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/plugin/KotlinMultiplatformPlugin.kt @@ -55,7 +55,7 @@ const val IMPLEMENT_DEPRECATION_WARNING = "The '$IMPLEMENT_CONFIG_NAME' configur open class KotlinPlatformImplementationPluginBase(platformName: String) : KotlinPlatformPluginBase(platformName) { private val commonProjects = arrayListOf() - protected open fun configurationsForCommonModuleDependency(project: Project): List = + private fun configurationsForCommonModuleDependency(project: Project): List = listOf(project.configurations.getByName("api")) override fun apply(project: Project) {