diff --git a/idea/idea-core/src/org/jetbrains/kotlin/idea/core/script/ScriptDefinitionsManager.kt b/idea/idea-core/src/org/jetbrains/kotlin/idea/core/script/ScriptDefinitionsManager.kt index 5fae42a5533..9c5e107347f 100644 --- a/idea/idea-core/src/org/jetbrains/kotlin/idea/core/script/ScriptDefinitionsManager.kt +++ b/idea/idea-core/src/org/jetbrains/kotlin/idea/core/script/ScriptDefinitionsManager.kt @@ -58,7 +58,7 @@ import kotlin.script.experimental.host.ScriptingHostConfiguration import kotlin.script.experimental.host.configurationDependencies import kotlin.script.experimental.host.createCompilationConfigurationFromTemplate import kotlin.script.experimental.jvm.JvmDependency -import kotlin.script.experimental.jvm.defaultJvmScriptingEnvironment +import kotlin.script.experimental.jvm.defaultJvmScriptingHostConfiguration import kotlin.script.experimental.location.ScriptExpectedLocation import kotlin.script.templates.standard.ScriptTemplateWithArgs @@ -210,7 +210,7 @@ fun loadDefinitionsFromTemplates( ) } template.annotations.firstIsInstanceOrNull() != null -> { - val hostConfiguration = ScriptingHostConfiguration(defaultJvmScriptingEnvironment) { + val hostConfiguration = ScriptingHostConfiguration(defaultJvmScriptingHostConfiguration) { configurationDependencies(JvmDependency(classpath)) } KotlinScriptDefinitionAdapterFromNewAPI( diff --git a/libraries/scripting/common/src/kotlin/script/experimental/api/scriptEvaluation.kt b/libraries/scripting/common/src/kotlin/script/experimental/api/scriptEvaluation.kt index d0e6c4c254b..7ba2c03fe38 100644 --- a/libraries/scripting/common/src/kotlin/script/experimental/api/scriptEvaluation.kt +++ b/libraries/scripting/common/src/kotlin/script/experimental/api/scriptEvaluation.kt @@ -11,17 +11,17 @@ import kotlin.script.experimental.util.PropertiesCollection interface ScriptEvaluationConfigurationKeys -class ScriptEvaluationConfiguration(baseEvaluationEnvironments: Iterable, body: Builder.() -> Unit) : - PropertiesCollection(Builder(baseEvaluationEnvironments).apply(body).data) { +class ScriptEvaluationConfiguration(baseEvaluationConfigurations: Iterable, body: Builder.() -> Unit) : + PropertiesCollection(Builder(baseEvaluationConfigurations).apply(body).data) { constructor(body: Builder.() -> Unit = {}) : this(emptyList(), body) constructor( vararg baseConfigurations: ScriptEvaluationConfiguration, body: Builder.() -> Unit = {} ) : this(baseConfigurations.asIterable(), body) - class Builder internal constructor(baseEvaluationEnvironments: Iterable) : + class Builder internal constructor(baseEvaluationConfigurations: Iterable) : ScriptEvaluationConfigurationKeys, - PropertiesCollection.Builder(baseEvaluationEnvironments) + PropertiesCollection.Builder(baseEvaluationConfigurations) companion object : ScriptEvaluationConfigurationKeys } diff --git a/libraries/scripting/common/src/kotlin/script/experimental/host/configurationFromTemplate.kt b/libraries/scripting/common/src/kotlin/script/experimental/host/configurationFromTemplate.kt index 1c260e434f3..3a9150c88b7 100644 --- a/libraries/scripting/common/src/kotlin/script/experimental/host/configurationFromTemplate.kt +++ b/libraries/scripting/common/src/kotlin/script/experimental/host/configurationFromTemplate.kt @@ -27,7 +27,7 @@ fun createCompilationConfigurationFromTemplate( ): ScriptCompilationConfiguration { val getScriptingClass = hostConfiguration[ScriptingHostConfiguration.getScriptingClass] - ?: throw IllegalArgumentException("${ERROR_MSG_PREFIX}Expecting 'getScriptingClass' parameter in the scripting environment") + ?: throw IllegalArgumentException("${ERROR_MSG_PREFIX}Expecting 'getScriptingClass' parameter in the scripting host configuration") val baseClass: KClass<*> = try { diff --git a/libraries/scripting/common/src/kotlin/script/experimental/host/scriptingEnvironment.kt b/libraries/scripting/common/src/kotlin/script/experimental/host/scriptingEnvironment.kt index a3891fcd356..fc34c646593 100644 --- a/libraries/scripting/common/src/kotlin/script/experimental/host/scriptingEnvironment.kt +++ b/libraries/scripting/common/src/kotlin/script/experimental/host/scriptingEnvironment.kt @@ -12,17 +12,17 @@ import kotlin.script.experimental.util.PropertiesCollection interface ScriptingHostConfigurationKeys -class ScriptingHostConfiguration(baseScriptingEnvironments: Iterable, body: Builder.() -> Unit) : - PropertiesCollection(Builder(baseScriptingEnvironments).apply(body).data) { +class ScriptingHostConfiguration(baseScriptingConfigurations: Iterable, body: Builder.() -> Unit) : + PropertiesCollection(Builder(baseScriptingConfigurations).apply(body).data) { constructor(body: Builder.() -> Unit = {}) : this(emptyList(), body) constructor( vararg baseConfigurations: ScriptingHostConfiguration, body: Builder.() -> Unit = {} ) : this(baseConfigurations.asIterable(), body) - class Builder internal constructor(baseScriptingEnvironments: Iterable) : + class Builder internal constructor(baseScriptingHostConfigurations: Iterable) : ScriptingHostConfigurationKeys, - PropertiesCollection.Builder(baseScriptingEnvironments) + PropertiesCollection.Builder(baseScriptingHostConfigurations) companion object : ScriptingHostConfigurationKeys } diff --git a/libraries/scripting/jvm-host/src/kotlin/script/experimental/jvmhost/BasicJvmScriptingHost.kt b/libraries/scripting/jvm-host/src/kotlin/script/experimental/jvmhost/BasicJvmScriptingHost.kt index 2c658f0ed0b..d113a09a25a 100644 --- a/libraries/scripting/jvm-host/src/kotlin/script/experimental/jvmhost/BasicJvmScriptingHost.kt +++ b/libraries/scripting/jvm-host/src/kotlin/script/experimental/jvmhost/BasicJvmScriptingHost.kt @@ -11,17 +11,17 @@ import kotlin.script.experimental.api.ScriptEvaluator import kotlin.script.experimental.host.ScriptingHostConfiguration import kotlin.script.experimental.host.createCompilationConfigurationFromTemplate import kotlin.script.experimental.host.BasicScriptingHost -import kotlin.script.experimental.jvm.defaultJvmScriptingEnvironment +import kotlin.script.experimental.jvm.defaultJvmScriptingHostConfiguration open class BasicJvmScriptingHost( - hostConfiguration: ScriptingHostConfiguration = defaultJvmScriptingEnvironment, + hostConfiguration: ScriptingHostConfiguration = defaultJvmScriptingHostConfiguration, compiler: JvmScriptCompiler = JvmScriptCompiler(hostConfiguration), evaluator: ScriptEvaluator = BasicJvmScriptEvaluator() ) : BasicScriptingHost(compiler, evaluator) inline fun createCompilationConfigurationFromTemplate( - hostConfiguration: ScriptingHostConfiguration = defaultJvmScriptingEnvironment, + hostConfiguration: ScriptingHostConfiguration = defaultJvmScriptingHostConfiguration, noinline body: ScriptCompilationConfiguration.Builder.() -> Unit = {} ): ScriptCompilationConfiguration = createCompilationConfigurationFromTemplate( KotlinType(T::class), diff --git a/libraries/scripting/jvm-host/src/kotlin/script/experimental/jvmhost/impl/KJVMCompilerImpl.kt b/libraries/scripting/jvm-host/src/kotlin/script/experimental/jvmhost/impl/KJVMCompilerImpl.kt index c51f8271667..81626720523 100644 --- a/libraries/scripting/jvm-host/src/kotlin/script/experimental/jvmhost/impl/KJVMCompilerImpl.kt +++ b/libraries/scripting/jvm-host/src/kotlin/script/experimental/jvmhost/impl/KJVMCompilerImpl.kt @@ -46,7 +46,7 @@ import kotlin.script.experimental.jvm.JvmDependency import kotlin.script.experimental.jvm.impl.BridgeDependenciesResolver import kotlin.script.experimental.jvm.javaHome import kotlin.script.experimental.jvm.jvm -import kotlin.script.experimental.jvmhost.JvmScriptEvaluationEnvironment +import kotlin.script.experimental.jvmhost.JvmScriptEvaluationConfiguration import kotlin.script.experimental.jvmhost.KJvmCompilerProxy import kotlin.script.experimental.jvmhost.baseClassLoader import kotlin.script.experimental.util.getOrError @@ -58,7 +58,7 @@ class KJvmCompiledScript( ) : CompiledScript { override suspend fun getClass(scriptEvaluationConfiguration: ScriptEvaluationConfiguration?): ResultWithDiagnostics> = try { - val baseClassLoader = scriptEvaluationConfiguration?.get(JvmScriptEvaluationEnvironment.baseClassLoader) + val baseClassLoader = scriptEvaluationConfiguration?.get(JvmScriptEvaluationConfiguration.baseClassLoader) ?: Thread.currentThread().contextClassLoader val dependencies = compilationConfiguration[ScriptCompilationConfiguration.dependencies] ?.flatMap { (it as? JvmDependency)?.classpath?.map { it.toURI().toURL() } ?: emptyList() } diff --git a/libraries/scripting/jvm-host/src/kotlin/script/experimental/jvmhost/impl/jvmHostUtil.kt b/libraries/scripting/jvm-host/src/kotlin/script/experimental/jvmhost/impl/jvmHostUtil.kt index abfb251cd7d..d3bd4ceb193 100644 --- a/libraries/scripting/jvm-host/src/kotlin/script/experimental/jvmhost/impl/jvmHostUtil.kt +++ b/libraries/scripting/jvm-host/src/kotlin/script/experimental/jvmhost/impl/jvmHostUtil.kt @@ -6,11 +6,11 @@ package kotlin.script.experimental.jvmhost.impl import kotlin.script.experimental.host.ScriptingHostConfiguration -import kotlin.script.experimental.jvm.defaultJvmScriptingEnvironment +import kotlin.script.experimental.jvm.defaultJvmScriptingHostConfiguration fun ScriptingHostConfiguration.withDefaults(): ScriptingHostConfiguration = - if (this == defaultJvmScriptingEnvironment) { + if (this == defaultJvmScriptingHostConfiguration) { this } else { - ScriptingHostConfiguration(defaultJvmScriptingEnvironment, this) + ScriptingHostConfiguration(defaultJvmScriptingHostConfiguration, this) } diff --git a/libraries/scripting/jvm-host/src/kotlin/script/experimental/jvmhost/jvmScriptCompilation.kt b/libraries/scripting/jvm-host/src/kotlin/script/experimental/jvmhost/jvmScriptCompilation.kt index ec6f82e9988..2db1b9630fc 100644 --- a/libraries/scripting/jvm-host/src/kotlin/script/experimental/jvmhost/jvmScriptCompilation.kt +++ b/libraries/scripting/jvm-host/src/kotlin/script/experimental/jvmhost/jvmScriptCompilation.kt @@ -9,7 +9,7 @@ package kotlin.script.experimental.jvmhost import kotlin.script.experimental.api.* import kotlin.script.experimental.host.ScriptingHostConfiguration -import kotlin.script.experimental.jvm.defaultJvmScriptingEnvironment +import kotlin.script.experimental.jvm.defaultJvmScriptingHostConfiguration import kotlin.script.experimental.jvmhost.impl.KJvmCompilerImpl import kotlin.script.experimental.jvmhost.impl.withDefaults @@ -30,7 +30,7 @@ interface CompiledJvmScriptsCache { } open class JvmScriptCompiler( - hostConfiguration: ScriptingHostConfiguration = defaultJvmScriptingEnvironment, + hostConfiguration: ScriptingHostConfiguration = defaultJvmScriptingHostConfiguration, val compilerProxy: KJvmCompilerProxy = KJvmCompilerImpl(hostConfiguration.withDefaults()), val cache: CompiledJvmScriptsCache = CompiledJvmScriptsCache.NoCache ) : ScriptCompiler { diff --git a/libraries/scripting/jvm-host/src/kotlin/script/experimental/jvmhost/jvmScriptEvaluation.kt b/libraries/scripting/jvm-host/src/kotlin/script/experimental/jvmhost/jvmScriptEvaluation.kt index 1aec59e83f6..bdcb0d9a4d9 100644 --- a/libraries/scripting/jvm-host/src/kotlin/script/experimental/jvmhost/jvmScriptEvaluation.kt +++ b/libraries/scripting/jvm-host/src/kotlin/script/experimental/jvmhost/jvmScriptEvaluation.kt @@ -10,14 +10,14 @@ package kotlin.script.experimental.jvmhost import kotlin.script.experimental.api.* import kotlin.script.experimental.util.PropertiesCollection -open class JvmScriptEvaluationEnvironment : PropertiesCollection.Builder() { +open class JvmScriptEvaluationConfiguration : PropertiesCollection.Builder() { - companion object : JvmScriptEvaluationEnvironment() + companion object : JvmScriptEvaluationConfiguration() } -val JvmScriptEvaluationEnvironment.baseClassLoader by PropertiesCollection.key(Thread.currentThread().contextClassLoader) +val JvmScriptEvaluationConfiguration.baseClassLoader by PropertiesCollection.key(Thread.currentThread().contextClassLoader) -val ScriptEvaluationConfiguration.jvm get() = JvmScriptEvaluationEnvironment() +val ScriptEvaluationConfiguration.jvm get() = JvmScriptEvaluationConfiguration() open class BasicJvmScriptEvaluator : ScriptEvaluator { diff --git a/libraries/scripting/jvm/src/kotlin/script/experimental/jvm/jvmScriptingHostConfiguration.kt b/libraries/scripting/jvm/src/kotlin/script/experimental/jvm/jvmScriptingHostConfiguration.kt index 4ddc53488b2..8f0f2290713 100644 --- a/libraries/scripting/jvm/src/kotlin/script/experimental/jvm/jvmScriptingHostConfiguration.kt +++ b/libraries/scripting/jvm/src/kotlin/script/experimental/jvm/jvmScriptingHostConfiguration.kt @@ -25,7 +25,7 @@ val JvmScriptingHostConfigurationKeys.javaHome by PropertiesCollection.key val ScriptingHostConfigurationKeys.jvm get() = JvmScriptingHostConfigurationBuilder() -val defaultJvmScriptingEnvironment = ScriptingHostConfiguration { +val defaultJvmScriptingHostConfiguration = ScriptingHostConfiguration { getScriptingClass(JvmGetScriptingClass()) } diff --git a/plugins/scripting/scripting-cli/src/org/jetbrains/kotlin/scripting/compiler/plugin/LazyScriptDefinitionFromDiscoveredClass.kt b/plugins/scripting/scripting-cli/src/org/jetbrains/kotlin/scripting/compiler/plugin/LazyScriptDefinitionFromDiscoveredClass.kt index 64f7e223d7b..fb570eb9e99 100644 --- a/plugins/scripting/scripting-cli/src/org/jetbrains/kotlin/scripting/compiler/plugin/LazyScriptDefinitionFromDiscoveredClass.kt +++ b/plugins/scripting/scripting-cli/src/org/jetbrains/kotlin/scripting/compiler/plugin/LazyScriptDefinitionFromDiscoveredClass.kt @@ -19,7 +19,7 @@ import kotlin.script.experimental.host.ScriptingHostConfiguration import kotlin.script.experimental.host.configurationDependencies import kotlin.script.experimental.host.createCompilationConfigurationFromTemplate import kotlin.script.experimental.jvm.JvmDependency -import kotlin.script.experimental.jvm.defaultJvmScriptingEnvironment +import kotlin.script.experimental.jvm.defaultJvmScriptingHostConfiguration class LazyScriptDefinitionFromDiscoveredClass internal constructor( private val annotationsFromAsm: ArrayList, @@ -36,7 +36,7 @@ class LazyScriptDefinitionFromDiscoveredClass internal constructor( ) : this(loadAnnotationsFromClass(classBytes), className, classpath, messageCollector) override val hostConfiguration: ScriptingHostConfiguration by lazy(LazyThreadSafetyMode.PUBLICATION) { - ScriptingHostConfiguration(defaultJvmScriptingEnvironment) { + ScriptingHostConfiguration(defaultJvmScriptingHostConfiguration) { configurationDependencies.append(JvmDependency(classpath)) } } diff --git a/plugins/scripting/scripting-cli/src/org/jetbrains/kotlin/scripting/compiler/plugin/ScriptiDefinitionsFromClasspathDiscoverySource.kt b/plugins/scripting/scripting-cli/src/org/jetbrains/kotlin/scripting/compiler/plugin/ScriptiDefinitionsFromClasspathDiscoverySource.kt index fa0c0e4c776..b03a34d7156 100644 --- a/plugins/scripting/scripting-cli/src/org/jetbrains/kotlin/scripting/compiler/plugin/ScriptiDefinitionsFromClasspathDiscoverySource.kt +++ b/plugins/scripting/scripting-cli/src/org/jetbrains/kotlin/scripting/compiler/plugin/ScriptiDefinitionsFromClasspathDiscoverySource.kt @@ -19,7 +19,7 @@ import kotlin.coroutines.experimental.buildSequence import kotlin.script.experimental.annotations.KotlinScript import kotlin.script.experimental.api.KotlinType import kotlin.script.experimental.host.createCompilationConfigurationFromTemplate -import kotlin.script.experimental.jvm.defaultJvmScriptingEnvironment +import kotlin.script.experimental.jvm.defaultJvmScriptingHostConfiguration import kotlin.script.templates.ScriptTemplateDefinition internal const val SCRIPT_DEFINITION_MARKERS_PATH = "META-INF/kotlin/script/templates/" @@ -272,7 +272,7 @@ private fun loadScriptDefinition( val cls = classLoader.loadClass(template) val def = if (cls.annotations.firstIsInstanceOrNull() != null) { - val environment = defaultJvmScriptingEnvironment + val environment = defaultJvmScriptingHostConfiguration KotlinScriptDefinitionAdapterFromNewAPI( createCompilationConfigurationFromTemplate( KotlinType(cls.kotlin),