azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Implement warning when non-abstract classes containing abstract members invisible from that classes

Browse Source 
#KT-27825 fixed
This commit is contained in:
Ilya Chernikov
2019-11-08 21:09:22 +01:00
parent eae3688c61
commit 808000e458
13 changed files with 370 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/testData/diagnostics/tests/visibility/abstractInvisibleMemberFromJava.kt
Vendored
+21
View File
@@ -0,0 +1,21 @@
// !LANGUAGE: +ProhibitInvisibleAbstractMethodsInSuperclasses
// FILE: base/Base.java
package base;
public abstract class Base {
public void foo() {
packagePrivateFoo();
}
/* package-private */ abstract void packagePrivateFoo();
}
// FILE: Impl.kt
package impl
import base.*
<!INVISIBLE_ABSTRACT_MEMBER_FROM_SUPER!>class Impl<!> : Base()
fun foo() {
Impl().foo()
}
compiler/testData/diagnostics/tests/visibility/abstractInvisibleMemberFromJava.txt
Vendored
+26
View File
@@ -0,0 +1,26 @@
package
package base {
public abstract class Base {
public constructor Base()
public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
public open fun foo(): kotlin.Unit
public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
public/*package*/ abstract fun packagePrivateFoo(): kotlin.Unit
public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
}
}
package impl {
public fun foo(): kotlin.Unit
public final class Impl : base.Base {
public constructor Impl()
public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
public open override /*1*/ /*fake_override*/ fun foo(): kotlin.Unit
public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
invisible_fake abstract override /*1*/ /*fake_override*/ fun packagePrivateFoo(): kotlin.Unit
public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
}
}
compiler/testData/diagnostics/tests/visibility/abstractInvisibleMemberFromKotlin.kt
Vendored
+47
View File
@@ -0,0 +1,47 @@
// !LANGUAGE: +ProhibitInvisibleAbstractMethodsInSuperclasses
// MODULE: base
// FILE: Base.kt
package base
abstract class Base {
fun foo(): String {
return internalFoo()
}
internal abstract fun internalFoo(): String
}
open class BaseWithOverride : Base() {
override fun internalFoo(): String = ""
}
// MODULE: intermediate(base)
// FILE: Intermediate.kt
package intermediate
import base.*
abstract class Intermediate : Base()
// MODULE: impl(base, intermediate)
// FILE: Impl.kt
package impl
import base.*
import intermediate.*
<!INVISIBLE_ABSTRACT_MEMBER_FROM_SUPER!>class ImplDirectFromBase<!> : Base()
<!INVISIBLE_ABSTRACT_MEMBER_FROM_SUPER!>object ImplObjDirectFromBase<!> : Base()
class ImplDirectFromBaseWithOverride : BaseWithOverride()
class ImplDirectFromBaseWithOverrid : Base() {
<!CANNOT_OVERRIDE_INVISIBLE_MEMBER!>override<!> fun internalFoo(): String = ""
}
<!INVISIBLE_ABSTRACT_MEMBER_FROM_SUPER!>class ImplViaIntermediate<!> : Intermediate()
fun foo() {
ImplDirectFromBase().foo()
ImplObjDirectFromBase.foo()
ImplDirectFromBaseWithOverride().foo()
ImplViaIntermediate().foo()
}
compiler/testData/diagnostics/tests/visibility/abstractInvisibleMemberFromKotlin.txt
Vendored
+92
View File
@@ -0,0 +1,92 @@
// -- Module: <base> --
package
package base {
public abstract class Base {
public constructor Base()
public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
public final fun foo(): kotlin.String
public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
internal abstract fun internalFoo(): kotlin.String
public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
}
public open class BaseWithOverride : base.Base {
public constructor BaseWithOverride()
public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
public final override /*1*/ /*fake_override*/ fun foo(): kotlin.String
public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
internal open override /*1*/ fun internalFoo(): kotlin.String
public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
}
}
// -- Module: <impl> --
package
package impl {
public fun foo(): kotlin.Unit
public final class ImplDirectFromBase : base.Base {
public constructor ImplDirectFromBase()
public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
public final override /*1*/ /*fake_override*/ fun foo(): kotlin.String
public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
invisible_fake abstract override /*1*/ /*fake_override*/ fun internalFoo(): kotlin.String
public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
}
public final class ImplDirectFromBaseWithOverrid : base.Base {
public constructor ImplDirectFromBaseWithOverrid()
public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
public final override /*1*/ /*fake_override*/ fun foo(): kotlin.String
public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
public open fun internalFoo(): kotlin.String
public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
}
public final class ImplDirectFromBaseWithOverride : base.BaseWithOverride {
public constructor ImplDirectFromBaseWithOverride()
public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
public final override /*1*/ /*fake_override*/ fun foo(): kotlin.String
public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
invisible_fake open override /*1*/ /*fake_override*/ fun internalFoo(): kotlin.String
public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
}
public object ImplObjDirectFromBase : base.Base {
private constructor ImplObjDirectFromBase()
public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
public final override /*1*/ /*fake_override*/ fun foo(): kotlin.String
public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
invisible_fake abstract override /*1*/ /*fake_override*/ fun internalFoo(): kotlin.String
public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
}
public final class ImplViaIntermediate : intermediate.Intermediate {
public constructor ImplViaIntermediate()
public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
public final override /*1*/ /*fake_override*/ fun foo(): kotlin.String
public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
invisible_fake abstract override /*1*/ /*fake_override*/ fun internalFoo(): kotlin.String
public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
}
}
// -- Module: <intermediate> --
package
package intermediate {
public abstract class Intermediate : base.Base {
public constructor Intermediate()
public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
public final override /*1*/ /*fake_override*/ fun foo(): kotlin.String
public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
invisible_fake abstract override /*1*/ /*fake_override*/ fun internalFoo(): kotlin.String
public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
}
}
compiler/testData/diagnostics/tests/visibility/abstractInvisibleMemberFromKotlinWarning.kt
Vendored
+22
View File
@@ -0,0 +1,22 @@
// !LANGUAGE: -ProhibitInvisibleAbstractMethodsInSuperclasses
// MODULE: base
// FILE: Base.kt
package base
abstract class Base {
fun foo(): String {
return internalFoo()
}
internal abstract fun internalFoo(): String
}
// MODULE: impl(base)
// FILE: Impl.kt
package impl
import base.*
<!INVISIBLE_ABSTRACT_MEMBER_FROM_SUPER_WARNING!>class Impl<!> : Base()
fun foo() {
Impl().foo()
}
compiler/testData/diagnostics/tests/visibility/abstractInvisibleMemberFromKotlinWarning.txt
Vendored
+31
View File
@@ -0,0 +1,31 @@
// -- Module: <base> --
package
package base {
public abstract class Base {
public constructor Base()
public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
public final fun foo(): kotlin.String
public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
internal abstract fun internalFoo(): kotlin.String
public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
}
}
// -- Module: <impl> --
package
package impl {
public fun foo(): kotlin.Unit
public final class Impl : base.Base {
public constructor Impl()
public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
public final override /*1*/ /*fake_override*/ fun foo(): kotlin.String
public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
invisible_fake abstract override /*1*/ /*fake_override*/ fun internalFoo(): kotlin.String
public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
}
}