From 80731437a8c503a8630eddd2c453cce83aa66cf4 Mon Sep 17 00:00:00 2001 From: Alexey Tsvetkov Date: Thu, 17 May 2018 17:12:25 +0300 Subject: [PATCH] Drop forcing Java task to recompile We don't support Gradle <= 3.5 at the moment, it does not make sense to have the code for Gradle < 2.14 --- .../jetbrains/kotlin/gradle/plugin/KotlinPlugin.kt | 14 -------------- .../org/jetbrains/kotlin/gradle/tasks/Tasks.kt | 5 ----- 2 files changed, 19 deletions(-) diff --git a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/plugin/KotlinPlugin.kt b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/plugin/KotlinPlugin.kt index bacfe8bf5c2..4949db58e64 100755 --- a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/plugin/KotlinPlugin.kt +++ b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/plugin/KotlinPlugin.kt @@ -590,20 +590,6 @@ abstract class AbstractAndroidProjectHandler(private val kotlinConfigurationT internal fun configureJavaTask(kotlinTask: KotlinCompile, javaTask: AbstractCompile, logger: Logger) { kotlinTask.javaOutputDir = javaTask.destinationDir - // Gradle Java IC in older Gradle versions (before 2.14) cannot check .class directories updates. - // To make it work, reset the up-to-date status of compileJava with this flag. - kotlinTask.anyClassesCompiled = false - val gradleSupportsJavaIcWithClassesDirs = ParsedGradleVersion.parse(javaTask.project.gradle.gradleVersion) - ?.let { it >= ParsedGradleVersion(2, 14) } ?: false - if (!gradleSupportsJavaIcWithClassesDirs) { - javaTask.outputs.upToDateWhen { task -> - if (kotlinTask.anyClassesCompiled) { - logger.info("Marking $task out of date, because kotlin classes are changed") - false - } else true - } - } - // Make Gradle check if the javaTask is up-to-date based on the Kotlin classes javaTask.inputsCompatible.run { if (isBuildCacheSupported()) { diff --git a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/tasks/Tasks.kt b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/tasks/Tasks.kt index c7fe931cac9..73859ffdfc2 100644 --- a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/tasks/Tasks.kt +++ b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/tasks/Tasks.kt @@ -180,10 +180,6 @@ abstract class AbstractKotlinCompile() : AbstractKo ?: coroutinesFromGradleProperties ?: Coroutines.DEFAULT - // TODO: consider more reliable approach (see usage) - @get:Internal - internal var anyClassesCompiled: Boolean = false - @get:Internal internal var friendTaskName: String? = null @@ -401,7 +397,6 @@ open class KotlinCompile : AbstractKotlinCompile(), Kotl cleanupOnError() throw e } - anyClassesCompiled = true } private fun disableMultiModuleICIfNeeded() {