JPS: ignore removed java files
#KT-27458 Fixed
This commit is contained in:
@@ -463,6 +463,29 @@ open class KotlinJpsBuildTest : KotlinJpsBuildTestBase() {
|
|||||||
buildAllModules().assertSuccessful()
|
buildAllModules().assertSuccessful()
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fun testPureJavaProject() {
|
||||||
|
initProject(JVM_FULL_RUNTIME)
|
||||||
|
|
||||||
|
fun build() {
|
||||||
|
var someFilesCompiled = false
|
||||||
|
|
||||||
|
buildCustom(CanceledStatus.NULL, TestProjectBuilderLogger(), BuildResult()) {
|
||||||
|
project.setTestingContext(TestingContext(LookupTracker.DO_NOTHING, object : TestingBuildLogger {
|
||||||
|
override fun compilingFiles(files: Collection<File>, allRemovedFilesFiles: Collection<File>) {
|
||||||
|
someFilesCompiled = true
|
||||||
|
}
|
||||||
|
}))
|
||||||
|
}
|
||||||
|
|
||||||
|
assertFalse("Kotlin builder should return early if there are no Kotlin files", someFilesCompiled)
|
||||||
|
}
|
||||||
|
|
||||||
|
build()
|
||||||
|
|
||||||
|
rename("${workDir}/src/Test.java", "${workDir}/src/Test1.java")
|
||||||
|
build()
|
||||||
|
}
|
||||||
|
|
||||||
fun testKotlinJavaProject() {
|
fun testKotlinJavaProject() {
|
||||||
doTestWithRuntime()
|
doTestWithRuntime()
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -27,7 +27,6 @@ import org.jetbrains.jps.builders.storage.BuildDataCorruptedException
|
|||||||
import org.jetbrains.jps.incremental.*
|
import org.jetbrains.jps.incremental.*
|
||||||
import org.jetbrains.jps.incremental.ModuleLevelBuilder.ExitCode.*
|
import org.jetbrains.jps.incremental.ModuleLevelBuilder.ExitCode.*
|
||||||
import org.jetbrains.jps.incremental.java.JavaBuilder
|
import org.jetbrains.jps.incremental.java.JavaBuilder
|
||||||
import org.jetbrains.jps.incremental.storage.BuildDataManager
|
|
||||||
import org.jetbrains.jps.model.JpsProject
|
import org.jetbrains.jps.model.JpsProject
|
||||||
import org.jetbrains.kotlin.build.GeneratedFile
|
import org.jetbrains.kotlin.build.GeneratedFile
|
||||||
import org.jetbrains.kotlin.cli.common.ExitCode
|
import org.jetbrains.kotlin.cli.common.ExitCode
|
||||||
@@ -35,7 +34,6 @@ import org.jetbrains.kotlin.cli.common.arguments.CommonCompilerArguments
|
|||||||
import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity
|
import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity
|
||||||
import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity.*
|
import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity.*
|
||||||
import org.jetbrains.kotlin.cli.common.messages.MessageCollectorUtil
|
import org.jetbrains.kotlin.cli.common.messages.MessageCollectorUtil
|
||||||
import org.jetbrains.kotlin.cli.common.toBooleanLenient
|
|
||||||
import org.jetbrains.kotlin.compilerRunner.*
|
import org.jetbrains.kotlin.compilerRunner.*
|
||||||
import org.jetbrains.kotlin.config.IncrementalCompilation
|
import org.jetbrains.kotlin.config.IncrementalCompilation
|
||||||
import org.jetbrains.kotlin.config.KotlinModuleKind
|
import org.jetbrains.kotlin.config.KotlinModuleKind
|
||||||
@@ -55,7 +53,6 @@ import org.jetbrains.kotlin.preloading.ClassCondition
|
|||||||
import org.jetbrains.kotlin.utils.KotlinPaths
|
import org.jetbrains.kotlin.utils.KotlinPaths
|
||||||
import org.jetbrains.kotlin.utils.KotlinPathsFromHomeDir
|
import org.jetbrains.kotlin.utils.KotlinPathsFromHomeDir
|
||||||
import org.jetbrains.kotlin.utils.PathUtil
|
import org.jetbrains.kotlin.utils.PathUtil
|
||||||
import org.jetbrains.org.objectweb.asm.ClassReader
|
|
||||||
import java.io.File
|
import java.io.File
|
||||||
import java.util.*
|
import java.util.*
|
||||||
import kotlin.collections.HashSet
|
import kotlin.collections.HashSet
|
||||||
@@ -406,6 +403,11 @@ class KotlinBuilder : ModuleLevelBuilder(BuilderCategory.SOURCE_PROCESSOR) {
|
|||||||
messageCollector
|
messageCollector
|
||||||
) ?: return ABORT
|
) ?: return ABORT
|
||||||
|
|
||||||
|
context.testingContext?.buildLogger?.compilingFiles(
|
||||||
|
kotlinDirtyFilesHolder.allDirtyFiles,
|
||||||
|
kotlinDirtyFilesHolder.allRemovedFilesFiles
|
||||||
|
)
|
||||||
|
|
||||||
if (LOG.isDebugEnabled) {
|
if (LOG.isDebugEnabled) {
|
||||||
LOG.debug("Compiling files: ${kotlinDirtyFilesHolder.allDirtyFiles}")
|
LOG.debug("Compiling files: ${kotlinDirtyFilesHolder.allDirtyFiles}")
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -73,13 +73,16 @@ class KotlinDirtySourceFilesHolder(
|
|||||||
val byTarget = mutableMapOf<ModuleBuildTarget, TargetFiles>()
|
val byTarget = mutableMapOf<ModuleBuildTarget, TargetFiles>()
|
||||||
|
|
||||||
chunk.targets.forEach { target ->
|
chunk.targets.forEach { target ->
|
||||||
val removedFiles = delegate.getRemovedFiles(target).map { File(it) }
|
val removedFiles = delegate.getRemovedFiles(target)
|
||||||
|
.map { File(it) }
|
||||||
|
.filter { it.isKotlinSourceFile }
|
||||||
|
|
||||||
byTarget[target] = TargetFiles(target, removedFiles)
|
byTarget[target] = TargetFiles(target, removedFiles)
|
||||||
}
|
}
|
||||||
|
|
||||||
delegate.processDirtyFiles { target, file, root ->
|
delegate.processDirtyFiles { target, file, root ->
|
||||||
val targetInfo = byTarget[target]
|
val targetInfo = byTarget[target]
|
||||||
?: error("processDirtyFiles should callback only on chunk `$chunk` targets (`$target` is not)")
|
?: error("processDirtyFiles should callback only on chunk `$chunk` targets (`$target` is not)")
|
||||||
|
|
||||||
if (file.isKotlinSourceFile) {
|
if (file.isKotlinSourceFile) {
|
||||||
targetInfo._markDirty(file, root)
|
targetInfo._markDirty(file, root)
|
||||||
|
|||||||
@@ -26,11 +26,12 @@ import java.io.File
|
|||||||
* Used for assertions in tests.
|
* Used for assertions in tests.
|
||||||
*/
|
*/
|
||||||
interface TestingBuildLogger {
|
interface TestingBuildLogger {
|
||||||
fun invalidOrUnusedCache(chunk: KotlinChunk?, target: KotlinModuleBuildTarget<*>?, attributesDiff: CacheAttributesDiff<*>)
|
fun invalidOrUnusedCache(chunk: KotlinChunk?, target: KotlinModuleBuildTarget<*>?, attributesDiff: CacheAttributesDiff<*>) = Unit
|
||||||
fun chunkBuildStarted(context: CompileContext, chunk: org.jetbrains.jps.ModuleChunk)
|
fun chunkBuildStarted(context: CompileContext, chunk: org.jetbrains.jps.ModuleChunk) = Unit
|
||||||
fun afterChunkBuildStarted(context: CompileContext, chunk: org.jetbrains.jps.ModuleChunk)
|
fun afterChunkBuildStarted(context: CompileContext, chunk: org.jetbrains.jps.ModuleChunk) = Unit
|
||||||
fun addCustomMessage(message: String)
|
fun compilingFiles(files: Collection<File>, allRemovedFilesFiles: Collection<File>) = Unit
|
||||||
fun buildFinished(exitCode: ModuleLevelBuilder.ExitCode)
|
fun addCustomMessage(message: String) = Unit
|
||||||
fun markedAsDirtyBeforeRound(files: Iterable<File>)
|
fun buildFinished(exitCode: ModuleLevelBuilder.ExitCode) = Unit
|
||||||
fun markedAsDirtyAfterRound(files: Iterable<File>)
|
fun markedAsDirtyBeforeRound(files: Iterable<File>) = Unit
|
||||||
|
fun markedAsDirtyAfterRound(files: Iterable<File>) = Unit
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -0,0 +1,12 @@
|
|||||||
|
<?xml version="1.0" encoding="UTF-8"?>
|
||||||
|
<module type="JAVA_MODULE" version="4">
|
||||||
|
<component name="NewModuleRootManager" inherit-compiler-output="true">
|
||||||
|
<exclude-output />
|
||||||
|
<content url="file://$MODULE_DIR$">
|
||||||
|
<sourceFolder url="file://$MODULE_DIR$/src" isTestSource="false" />
|
||||||
|
</content>
|
||||||
|
<orderEntry type="jdk" jdkName="IDEA_JDK" jdkType="JavaSDK" />
|
||||||
|
<orderEntry type="sourceFolder" forTests="false" />
|
||||||
|
<orderEntry type="module" module-name="kotlinProject" />
|
||||||
|
</component>
|
||||||
|
</module>
|
||||||
@@ -0,0 +1,14 @@
|
|||||||
|
<?xml version="1.0" encoding="UTF-8"?>
|
||||||
|
<project version="4">
|
||||||
|
<component name="CompilerConfiguration">
|
||||||
|
<option name="DEFAULT_COMPILER" value="Javac" />
|
||||||
|
</component>
|
||||||
|
<component name="ProjectModuleManager">
|
||||||
|
<modules>
|
||||||
|
<module fileurl="file://$PROJECT_DIR$/kotlinProject.iml" filepath="$PROJECT_DIR$/kotlinProject.iml" />
|
||||||
|
</modules>
|
||||||
|
</component>
|
||||||
|
<component name="ProjectRootManager" version="2" languageLevel="JDK_1_6" assert-keyword="true" jdk-15="true" project-jdk-name="IDEA_JDK" project-jdk-type="JavaSDK">
|
||||||
|
<output url="file://$PROJECT_DIR$/out" />
|
||||||
|
</component>
|
||||||
|
</project>
|
||||||
@@ -0,0 +1,5 @@
|
|||||||
|
class A {
|
||||||
|
public static void main(String[] args) {
|
||||||
|
System.out.println("Hello");
|
||||||
|
}
|
||||||
|
}
|
||||||
Reference in New Issue
Block a user