From 7f3a2ac953a4f789af58dea96b57f9f0aca93fea Mon Sep 17 00:00:00 2001 From: Ilya Goncharov Date: Wed, 5 Aug 2020 15:29:58 +0300 Subject: [PATCH] [Gradle, JS] Renames ^KT-41054 fixed --- .../jetbrains/kotlin/gradle/targets/js/npm/NpmRange.kt | 8 ++++---- .../{NpmVersionInvertedVisitor.kt => NpmRangeVisitor.kt} | 2 +- .../js/npm/{NpmVersionInverter.kt => NpmVersions.kt} | 5 +++-- 3 files changed, 8 insertions(+), 7 deletions(-) rename libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/npm/{NpmVersionInvertedVisitor.kt => NpmRangeVisitor.kt} (98%) rename libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/npm/{NpmVersionInverter.kt => NpmVersions.kt} (95%) diff --git a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/npm/NpmRange.kt b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/npm/NpmRange.kt index a11225d8551..c184fe89ec7 100644 --- a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/npm/NpmRange.kt +++ b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/npm/NpmRange.kt @@ -6,10 +6,10 @@ package org.jetbrains.kotlin.gradle.targets.js.npm import com.github.gundy.semver4j.model.Version -import org.jetbrains.kotlin.gradle.targets.js.npm.NpmVersionInvertedVisitor.Companion.GT -import org.jetbrains.kotlin.gradle.targets.js.npm.NpmVersionInvertedVisitor.Companion.GTEQ -import org.jetbrains.kotlin.gradle.targets.js.npm.NpmVersionInvertedVisitor.Companion.LT -import org.jetbrains.kotlin.gradle.targets.js.npm.NpmVersionInvertedVisitor.Companion.LTEQ +import org.jetbrains.kotlin.gradle.targets.js.npm.NpmRangeVisitor.Companion.GT +import org.jetbrains.kotlin.gradle.targets.js.npm.NpmRangeVisitor.Companion.GTEQ +import org.jetbrains.kotlin.gradle.targets.js.npm.NpmRangeVisitor.Companion.LT +import org.jetbrains.kotlin.gradle.targets.js.npm.NpmRangeVisitor.Companion.LTEQ data class NpmRange( val startVersion: SemVer? = null, diff --git a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/npm/NpmVersionInvertedVisitor.kt b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/npm/NpmRangeVisitor.kt similarity index 98% rename from libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/npm/NpmVersionInvertedVisitor.kt rename to libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/npm/NpmRangeVisitor.kt index a6101ee8106..79106a905c9 100644 --- a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/npm/NpmVersionInvertedVisitor.kt +++ b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/npm/NpmRangeVisitor.kt @@ -10,7 +10,7 @@ import com.github.gundy.semver4j.generated.grammar.NodeSemverExpressionParser import com.github.gundy.semver4j.model.Version import org.antlr.v4.runtime.tree.TerminalNode -class NpmVersionInvertedVisitor : NodeSemverExpressionBaseVisitor>() { +class NpmRangeVisitor : NodeSemverExpressionBaseVisitor>() { override fun visitEmptyRange(ctx: NodeSemverExpressionParser.EmptyRangeContext): List = listOf(null) diff --git a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/npm/NpmVersionInverter.kt b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/npm/NpmVersions.kt similarity index 95% rename from libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/npm/NpmVersionInverter.kt rename to libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/npm/NpmVersions.kt index c9c33ffbba3..ce5c283bc49 100644 --- a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/npm/NpmVersionInverter.kt +++ b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/npm/NpmVersions.kt @@ -15,7 +15,7 @@ fun versionToNpmRanges(version: String): List { val lexer = NodeSemverExpressionLexer(ANTLRInputStream(version)) val tokens = CommonTokenStream(lexer) val parser = NodeSemverExpressionParser(tokens) - return NpmVersionInvertedVisitor() + return NpmRangeVisitor() .visit(parser.rangeSet())!! } @@ -59,5 +59,6 @@ fun buildNpmVersion( } else excludedRanges .mapNotNull { it intersect includedRange } - .joinToString(NpmVersionInvertedVisitor.OR) + .sortedBy { it.startVersion } + .joinToString(NpmRangeVisitor.OR) } \ No newline at end of file