diff --git a/jps/jps-plugin/jps-tests/test/org/jetbrains/kotlin/jps/build/AbstractIncrementalJpsTest.kt b/jps/jps-plugin/jps-tests/test/org/jetbrains/kotlin/jps/build/AbstractIncrementalJpsTest.kt index 295fb525744..eee914ebc4d 100644 --- a/jps/jps-plugin/jps-tests/test/org/jetbrains/kotlin/jps/build/AbstractIncrementalJpsTest.kt +++ b/jps/jps-plugin/jps-tests/test/org/jetbrains/kotlin/jps/build/AbstractIncrementalJpsTest.kt @@ -71,8 +71,6 @@ abstract class AbstractIncrementalJpsTest( private val DEBUG_LOGGING_ENABLED = System.getProperty("debug.logging.enabled") == "true" } - protected open val enableExperimentalIncrementalCompilation = false - protected lateinit var testDataDir: File protected lateinit var workDir: File protected lateinit var projectDescriptor: ProjectDescriptor @@ -81,7 +79,7 @@ abstract class AbstractIncrementalJpsTest( protected var mapWorkingToOriginalFile: MutableMap = hashMapOf() protected open val buildLogFinder: BuildLogFinder - get() = BuildLogFinder(isExperimentalEnabled = enableExperimentalIncrementalCompilation) + get() = BuildLogFinder(isExperimentalEnabled = true) private fun enableDebugLogging() { com.intellij.openapi.diagnostic.Logger.setFactory(TestLoggerFactory::class.java) @@ -112,7 +110,7 @@ abstract class AbstractIncrementalJpsTest( override fun setUp() { super.setUp() lookupsDuringTest = hashSetOf() - IncrementalCompilation.setIsExperimental(enableExperimentalIncrementalCompilation) + IncrementalCompilation.setIsEnabled(true) if (DEBUG_LOGGING_ENABLED) { enableDebugLogging() @@ -279,8 +277,6 @@ abstract class AbstractIncrementalJpsTest( throw IllegalStateException("No build log file in $testDataDir") } - if (!enableExperimentalIncrementalCompilation && File(testDataDir, "dont-check-caches-in-non-experimental-ic.txt").exists()) return - val lastMakeResult = otherMakeResults.last() rebuildAndCheckOutput(lastMakeResult) clearCachesRebuildAndCheckOutput(lastMakeResult) diff --git a/jps/jps-plugin/jps-tests/test/org/jetbrains/kotlin/jps/build/AbstractIncrementalLazyCachesTest.kt b/jps/jps-plugin/jps-tests/test/org/jetbrains/kotlin/jps/build/AbstractIncrementalLazyCachesTest.kt index ea36a1d0d36..573e77ff7d9 100644 --- a/jps/jps-plugin/jps-tests/test/org/jetbrains/kotlin/jps/build/AbstractIncrementalLazyCachesTest.kt +++ b/jps/jps-plugin/jps-tests/test/org/jetbrains/kotlin/jps/build/AbstractIncrementalLazyCachesTest.kt @@ -55,7 +55,7 @@ abstract class AbstractIncrementalLazyCachesTest : AbstractIncrementalJpsTest() IncrementalCompilation.setIsEnabled(modification.dataFile.readAsBool()) } name.endsWith("experimental-compilation") -> { - IncrementalCompilation.setIsExperimental(modification.dataFile.readAsBool()) + IncrementalCompilation.setIsEnabled(modification.dataFile.readAsBool()) } } } diff --git a/jps/jps-plugin/jps-tests/test/org/jetbrains/kotlin/jps/build/experimentalIncrementalCompilationTests.kt b/jps/jps-plugin/jps-tests/test/org/jetbrains/kotlin/jps/build/experimentalIncrementalCompilationTests.kt index 8841eaceb01..b15fb2daad9 100644 --- a/jps/jps-plugin/jps-tests/test/org/jetbrains/kotlin/jps/build/experimentalIncrementalCompilationTests.kt +++ b/jps/jps-plugin/jps-tests/test/org/jetbrains/kotlin/jps/build/experimentalIncrementalCompilationTests.kt @@ -20,12 +20,9 @@ import org.jetbrains.jps.incremental.ModuleBuildTarget import org.jetbrains.kotlin.incremental.testingUtils.BuildLogFinder import org.jetbrains.kotlin.jps.incremental.CacheVersionProvider -abstract class AbstractExperimentalIncrementalJpsTest : AbstractIncrementalJpsTest() { - override val enableExperimentalIncrementalCompilation = true -} +abstract class AbstractExperimentalIncrementalJpsTest : AbstractIncrementalJpsTest() abstract class AbstractExperimentalIncrementalLazyCachesTest : AbstractIncrementalLazyCachesTest() { - override val enableExperimentalIncrementalCompilation = true override val expectedCachesFileName: String get() = "experimental-expected-kotlin-caches.txt" @@ -34,8 +31,6 @@ abstract class AbstractExperimentalIncrementalLazyCachesTest : AbstractIncrement abstract class AbstractExperimentalChangeIncrementalOptionTest : AbstractIncrementalLazyCachesTest() abstract class AbstractExperimentalIncrementalCacheVersionChangedTest : AbstractIncrementalCacheVersionChangedTest() { - override val enableExperimentalIncrementalCompilation = true - override fun getVersions(cacheVersionProvider: CacheVersionProvider, targets: Iterable) = targets.map { cacheVersionProvider.experimentalVersion(it) } } diff --git a/jps/jps-plugin/jps-tests/test/org/jetbrains/kotlin/jps/build/incrementalCustomTests.kt b/jps/jps-plugin/jps-tests/test/org/jetbrains/kotlin/jps/build/incrementalCustomTests.kt index 42a8c9a497c..9047cbfe8ae 100644 --- a/jps/jps-plugin/jps-tests/test/org/jetbrains/kotlin/jps/build/incrementalCustomTests.kt +++ b/jps/jps-plugin/jps-tests/test/org/jetbrains/kotlin/jps/build/incrementalCustomTests.kt @@ -29,5 +29,4 @@ open class IncrementalRenameModuleTest : AbstractIncrementalJpsTest() { } class ExperimentalIncrementalRenameModuleTest : IncrementalRenameModuleTest() { - override val enableExperimentalIncrementalCompilation = true } diff --git a/jps/jps-plugin/src/org/jetbrains/kotlin/jps/build/KotlinBuilder.kt b/jps/jps-plugin/src/org/jetbrains/kotlin/jps/build/KotlinBuilder.kt index c4ccecf8fc6..c9879c12a80 100644 --- a/jps/jps-plugin/src/org/jetbrains/kotlin/jps/build/KotlinBuilder.kt +++ b/jps/jps-plugin/src/org/jetbrains/kotlin/jps/build/KotlinBuilder.kt @@ -92,7 +92,6 @@ class KotlinBuilder : ModuleLevelBuilder(BuilderCategory.SOURCE_PROCESSOR) { override fun buildStarted(context: CompileContext) { LOG.debug("==========================================") LOG.info("is Kotlin incremental compilation enabled: ${IncrementalCompilation.isEnabled()}") - LOG.info("is Kotlin experimental incremental compilation enabled: ${IncrementalCompilation.isExperimental()}") LOG.info("is Kotlin compiler daemon enabled: ${isDaemonEnabled()}") val historyLabel = context.getBuilderParameter("history label") @@ -643,8 +642,6 @@ class KotlinBuilder : ModuleLevelBuilder(BuilderCategory.SOURCE_PROCESSOR) { dirtyFilesHolder: DirtyFilesHolder, filesToCompile: MultiMap ) { - if (!IncrementalCompilation.isExperimental()) return - if (lookupTracker !is LookupTrackerImpl) throw AssertionError("Lookup tracker is expected to be LookupTrackerImpl, got ${lookupTracker::class.java}") val lookupStorage = dataManager.getStorage(KotlinDataContainerTarget, JpsLookupStorageProvider) @@ -845,7 +842,7 @@ private fun CompilationResult.processChangesUsingLookups( private fun getLookupTracker(project: JpsProject): LookupTracker { val testLookupTracker = project.testingContext?.lookupTracker ?: LookupTracker.DO_NOTHING - if (IncrementalCompilation.isExperimental()) return LookupTrackerImpl(testLookupTracker) + if (IncrementalCompilation.isEnabled()) return LookupTrackerImpl(testLookupTracker) return testLookupTracker } diff --git a/jps/jps-plugin/src/org/jetbrains/kotlin/jps/incremental/JpsIncrementalCacheImpl.kt b/jps/jps-plugin/src/org/jetbrains/kotlin/jps/incremental/JpsIncrementalCacheImpl.kt index 409c1f35141..4e5a7762685 100644 --- a/jps/jps-plugin/src/org/jetbrains/kotlin/jps/incremental/JpsIncrementalCacheImpl.kt +++ b/jps/jps-plugin/src/org/jetbrains/kotlin/jps/incremental/JpsIncrementalCacheImpl.kt @@ -45,7 +45,7 @@ class JpsIncrementalCacheImpl( private val inlinedTo = registerMap(InlineFunctionsFilesMap(INLINED_TO.storageFile)) override fun registerInline(fromPath: String, jvmSignature: String, toPath: String) { - if (!IncrementalCompilation.isExperimental()) { + if (!IncrementalCompilation.isEnabled()) { inlinedTo.add(fromPath, jvmSignature, toPath) } }