azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prohibit MIN_VALUE step for unsigned progressions

Browse Source
This commit is contained in:
Ilya Gorbunov
2018-08-01 17:38:34 +03:00
parent 4e574cb017
commit 7dc6c3d7ce
4 changed files with 15 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libraries/stdlib/unsigned/src/kotlin/UIntRange.kt
+4 -1
View File
@@ -51,7 +51,8 @@ internal constructor(
step: Int
) : Iterable<UInt> {
init {
if (step == 0.toInt()) throw kotlin.IllegalArgumentException("Step must be non-zero")
if (step == 0.toInt()) throw kotlin.IllegalArgumentException("Step must be non-zero.")
if (step == Int.MIN_VALUE) throw kotlin.IllegalArgumentException("Step must be greater than Int.MIN_VALUE to avoid overflow on negation.")
}
/**
@@ -89,6 +90,8 @@ internal constructor(
* The progression starts with the [rangeStart] value and goes toward the [rangeEnd] value not excluding it, with the specified [step].
* In order to go backwards the [step] must be negative.
*
* [step] must be greater than `Int.MIN_VALUE` and not equal to zero.
*/
public fun fromClosedRange(rangeStart: UInt, rangeEnd: UInt, step: Int): UIntProgression = UIntProgression(rangeStart, rangeEnd, step)
}
libraries/stdlib/unsigned/src/kotlin/ULongRange.kt
+4 -1
View File
@@ -51,7 +51,8 @@ internal constructor(
step: Long
) : Iterable<ULong> {
init {
if (step == 0.toLong()) throw kotlin.IllegalArgumentException("Step must be non-zero")
if (step == 0.toLong()) throw kotlin.IllegalArgumentException("Step must be non-zero.")
if (step == Long.MIN_VALUE) throw kotlin.IllegalArgumentException("Step must be greater than Long.MIN_VALUE to avoid overflow on negation.")
}
/**
@@ -89,6 +90,8 @@ internal constructor(
* The progression starts with the [rangeStart] value and goes toward the [rangeEnd] value not excluding it, with the specified [step].
* In order to go backwards the [step] must be negative.
*
* [step] must be greater than `Long.MIN_VALUE` and not equal to zero.
*/
public fun fromClosedRange(rangeStart: ULong, rangeEnd: ULong, step: Long): ULongProgression = ULongProgression(rangeStart, rangeEnd, step)
}