FIR: report UNSAFE_CALL on dot when possible

compiler/testData/diagnostics/tests/smartCasts/loops/WhileTrueWithBreakInIfCondition.fir.kt

@@ -9,5 +9,5 @@ fun checkJump(x: Int?, y: Int?) {
         y.hashCode()
     }
     // Smart cast here is erroneous: y is nullable
-    y.<!UNSAFE_CALL!>hashCode<!>()
+    y<!UNSAFE_CALL!>.<!>hashCode()
 }

compiler/testData/diagnostics/tests/smartCasts/loops/assignElvisIfBreakInsideWhileTrue.fir.kt

@@ -4,8 +4,8 @@ public fun foo(x: String?, y: String?): Int {
         // z is not null in both branches
         z.length
         // y is nullable if x != null
-        y.<!UNSAFE_CALL!>length<!>
+        y<!UNSAFE_CALL!>.<!>length
     }
     // y is null because of the break
-    return y.<!UNSAFE_CALL!>length<!>
+    return y<!UNSAFE_CALL!>.<!>length
 }

compiler/testData/diagnostics/tests/smartCasts/loops/assignWhenInsideWhileTrue.fir.kt

@@ -13,5 +13,5 @@ public fun foo(x: String?): Int {
         checkSubtype<Int>(y)
     }    
     // x is null because of the break
-    return x.<!UNSAFE_CALL!>length<!>
+    return x<!UNSAFE_CALL!>.<!>length
 }

compiler/testData/diagnostics/tests/smartCasts/loops/callBreakBetweenInsideDoWhile.fir.kt

@@ -10,7 +10,7 @@ public fun foo(x: String?, z: String?, w: String?): Int {
     // w is not null because of w!!
     w.length
     // z is nullable despite of z!!
-    z.<!UNSAFE_CALL!>length<!>
+    z<!UNSAFE_CALL!>.<!>length
     // x is null because of the break
-    return x.<!UNSAFE_CALL!>length<!>
+    return x<!UNSAFE_CALL!>.<!>length
 }

compiler/testData/diagnostics/tests/smartCasts/loops/callBreakFirstInsideDoWhile.fir.kt

@@ -7,7 +7,7 @@ public fun foo(x: String?, z: String?): Int {
         gav(if (x == null) break else x, z!!)
     } while (bar())
     // z is nullable despite of z!!
-    z.<!UNSAFE_CALL!>length<!>
+    z<!UNSAFE_CALL!>.<!>length
     // x is null because of the break
-    return x.<!UNSAFE_CALL!>length<!>
+    return x<!UNSAFE_CALL!>.<!>length
 }

compiler/testData/diagnostics/tests/smartCasts/loops/callBreakInsideDoWhile.fir.kt

@@ -10,5 +10,5 @@ public fun foo(x: String?): Int {
     } while (bar())
     y.hashCode()
     // x is null because of the break
-    return x.<!UNSAFE_CALL!>length<!>
+    return x<!UNSAFE_CALL!>.<!>length
 }

compiler/testData/diagnostics/tests/smartCasts/loops/callBreakSecondInsideDoWhile.fir.kt

@@ -9,5 +9,5 @@ public fun foo(x: String?, z: String?): Int {
     // z is not null because of z!!
     z.length
     // x is null because of the break
-    return x.<!UNSAFE_CALL!>length<!>
+    return x<!UNSAFE_CALL!>.<!>length
 }

compiler/testData/diagnostics/tests/smartCasts/loops/callBreakThirdInsideDoWhile.fir.kt

@@ -12,5 +12,5 @@ public fun foo(x: String?, z: String?, w: String?): Int {
     // z is not null because of z!!
     z.length
     // x is null because of the break
-    return x.<!UNSAFE_CALL!>length<!>
+    return x<!UNSAFE_CALL!>.<!>length
 }

compiler/testData/diagnostics/tests/smartCasts/loops/doWhileEarlyBreak.fir.kt

@@ -1,13 +0,0 @@
-fun x(): Boolean { return true }
-
-fun y(): Boolean { return false }
-
-public fun foo(p: String?): Int {
-    do {
-        if (y()) break
-        // We do not always reach this statement
-        p!!.length
-    } while (!x())
-    // Here we have do while loop but p is still nullable due to break before
-    return p.<!UNSAFE_CALL!>length<!>
-}

compiler/testData/diagnostics/tests/smartCasts/loops/doWhileEarlyBreak.kt

@@ -1,3 +1,4 @@
+// FIR_IDENTICAL
 fun x(): Boolean { return true }
 
 fun y(): Boolean { return false }

compiler/testData/diagnostics/tests/smartCasts/loops/doWhileInConditionWithBreak.fir.kt

@@ -1,9 +0,0 @@
-fun bar(): Boolean { return true }
-
-fun foo(s: String?): Int {
-    do {
-        if (bar()) break
-    } while (s!!.length > 0)
-    // This call is unsafe due to break
-    return s.<!UNSAFE_CALL!>length<!>
-}

compiler/testData/diagnostics/tests/smartCasts/loops/doWhileInConditionWithBreak.kt

@@ -1,3 +1,4 @@
+// FIR_IDENTICAL
 fun bar(): Boolean { return true }
 
 fun foo(s: String?): Int {

compiler/testData/diagnostics/tests/smartCasts/loops/doWhileNotNullBreak.fir.kt

@@ -1,10 +0,0 @@
-fun x(): Boolean { return true }
-
-public fun foo(p: String?): Int {
-    // See KT-6283
-    do {
-        if (p != null) break
-    } while (!x())
-    // p can be null despite of the break
-    return p.<!UNSAFE_CALL!>length<!>
-}

compiler/testData/diagnostics/tests/smartCasts/loops/doWhileNotNullBreak.kt

@@ -1,3 +1,4 @@
+// FIR_IDENTICAL
 fun x(): Boolean { return true }
 
 public fun foo(p: String?): Int {

compiler/testData/diagnostics/tests/smartCasts/loops/doWhileNullWithBreak.fir.kt

@@ -1,9 +0,0 @@
-fun bar(): Boolean { return true }
-
-fun foo(s: String?): Int {
-    do {
-        if (bar()) break
-    } while (s==null)
-    // This call is unsafe due to break
-    return s.<!UNSAFE_CALL!>length<!>
-}

compiler/testData/diagnostics/tests/smartCasts/loops/doWhileNullWithBreak.kt

@@ -1,3 +1,4 @@
+// FIR_IDENTICAL
 fun bar(): Boolean { return true }
 
 fun foo(s: String?): Int {

compiler/testData/diagnostics/tests/smartCasts/loops/elvisBreakInsideDoWhile.fir.kt

@@ -6,5 +6,5 @@ public fun foo(x: String?): Int {
         x.length
     } while (true)
     // x is null because of the break
-    return x.<!UNSAFE_CALL!>length<!>
+    return x<!UNSAFE_CALL!>.<!>length
 }

compiler/testData/diagnostics/tests/smartCasts/loops/elvisIfBreakInsideWhileTrue.fir.kt

@@ -1,9 +0,0 @@
-public fun foo(x: String?, y: String?): Int {
-    while (true) {
-        x ?: if (y == null) break
-        // y is nullable if x != null
-        y.<!UNSAFE_CALL!>length<!>
-    }
-    // y is null because of the break
-    return y.<!UNSAFE_CALL!>length<!>
-}

compiler/testData/diagnostics/tests/smartCasts/loops/elvisIfBreakInsideWhileTrue.kt

@@ -1,3 +1,4 @@
+// FIR_IDENTICAL
 public fun foo(x: String?, y: String?): Int {
     while (true) {
         x ?: if (y == null) break

compiler/testData/diagnostics/tests/smartCasts/loops/elvisLeftBreakInsideWhileTrue.fir.kt

@@ -1,9 +0,0 @@
-public fun foo(x: String?, y: String?): Int {
-    while (true) {
-        (if (x != null) break else y) ?: y!!
-        // y is not null in both branches but it's hard to determine
-        y.<!UNSAFE_CALL!>length<!>
-    }
-    // y can be null because of the break
-    return y.<!UNSAFE_CALL!>length<!>
-}

compiler/testData/diagnostics/tests/smartCasts/loops/elvisLeftBreakInsideWhileTrue.kt

@@ -1,3 +1,4 @@
+// FIR_IDENTICAL
 public fun foo(x: String?, y: String?): Int {
     while (true) {
         (if (x != null) break else y) ?: y!!

compiler/testData/diagnostics/tests/smartCasts/loops/ifBreakAssignInsideDoWhile.fir.kt

@@ -10,5 +10,5 @@ public fun foo(x: String?): Int {
     } while (bar())
     y.hashCode()
     // x is null because of the break
-    return x.<!UNSAFE_CALL!>length<!>
+    return x<!UNSAFE_CALL!>.<!>length
 }

compiler/testData/diagnostics/tests/smartCasts/loops/ifBreakAssignInsideWhileTrue.fir.kt

@@ -6,5 +6,5 @@ public fun foo(x: String?): Int {
     // In future we can infer this initialization
     <!UNINITIALIZED_VARIABLE!>y<!>.hashCode()
     // x is null because of the break
-    return x.<!UNSAFE_CALL!>length<!>
+    return x<!UNSAFE_CALL!>.<!>length
 }

compiler/testData/diagnostics/tests/smartCasts/loops/ifBreakExprInsideWhileTrue.fir.kt

@@ -6,5 +6,5 @@ public fun foo(x: String?): Int {
         y.length
     }
     // x is null because of the break
-    return x.<!UNSAFE_CALL!>length<!>
+    return x<!UNSAFE_CALL!>.<!>length
 }

compiler/testData/diagnostics/tests/smartCasts/loops/leftElvisBreakInsideWhileTrue.fir.kt

@@ -7,5 +7,5 @@ public fun foo(x: String?, y: String?): Int {
         y.length
     }
     // y is null because of the break
-    return y.<!UNSAFE_CALL!>length<!>
+    return y<!UNSAFE_CALL!>.<!>length
 }

compiler/testData/diagnostics/tests/smartCasts/loops/nestedLoopsWithLongBreak.fir.kt

@@ -13,7 +13,7 @@ public fun foo(p: String?, r: String?, q: String?): Int {
         if (!x(p)) break
     }
     // Long break allows r == null
-    r.<!UNSAFE_CALL!>length<!>
+    r<!UNSAFE_CALL!>.<!>length
     // Smart cast is possible
     q.length
     return p.length

compiler/testData/diagnostics/tests/smartCasts/loops/plusAssignWhenInsideDoWhile.fir.kt

@@ -18,5 +18,5 @@ public fun foo(x: String?): Int {
     // y is always Int even here
     checkSubtype<Int>(y)
     // x is null because of the break
-    return x.<!UNSAFE_CALL!>length<!>
+    return x<!UNSAFE_CALL!>.<!>length
 }

compiler/testData/diagnostics/tests/smartCasts/loops/whenInsideWhileTrue.fir.kt

@@ -8,5 +8,5 @@ public fun foo(x: String?): Int {
         }         
     }
     // x is null because of the break
-    return x.<!UNSAFE_CALL!>length<!>
+    return x<!UNSAFE_CALL!>.<!>length
 }

compiler/testData/diagnostics/tests/smartCasts/loops/whileNullWithBreak.fir.kt

@@ -1,9 +0,0 @@
-fun bar(): Boolean { return true }
-
-fun foo(s: String?): Int {
-    while (s==null) {
-        if (bar()) break
-    }
-    // Call is unsafe due to break
-    return s.<!UNSAFE_CALL!>length<!>
-}

compiler/testData/diagnostics/tests/smartCasts/loops/whileNullWithBreak.kt

@@ -1,3 +1,4 @@
+// FIR_IDENTICAL
 fun bar(): Boolean { return true }
 
 fun foo(s: String?): Int {

compiler/testData/diagnostics/tests/smartCasts/loops/whileSimple.fir.kt

@@ -1,10 +0,0 @@
-fun x(): Boolean { return true }
-
-public fun foo(p: String?): Int {    
-    while(x()) {
-        p!!.length
-        if (x()) break
-    }
-    // p is nullable because it's possible loop body is not executed at all
-    return p.<!UNSAFE_CALL!>length<!>
-}

compiler/testData/diagnostics/tests/smartCasts/loops/whileSimple.kt

@@ -1,3 +1,4 @@
+// FIR_IDENTICAL
 fun x(): Boolean { return true }
 
 public fun foo(p: String?): Int {    

compiler/testData/diagnostics/tests/smartCasts/loops/whileTrivial.fir.kt

@@ -1,11 +0,0 @@
-fun x(): Boolean { return true }
-
-public fun foo(p: String?): Int {
-    // Like whileTrue but 2 == 2 is in use
-    while(2 == 2) {
-        p!!.length
-        if (x()) break
-    }
-    // Smart cast should not work in this case, see KT-6284
-    return p.<!UNSAFE_CALL!>length<!>
-}

compiler/testData/diagnostics/tests/smartCasts/loops/whileTrivial.kt

@@ -1,3 +1,4 @@
+// FIR_IDENTICAL
 fun x(): Boolean { return true }
 
 public fun foo(p: String?): Int {

compiler/testData/diagnostics/tests/smartCasts/loops/whileTrueBreakReturn.fir.kt

@@ -8,5 +8,5 @@ public fun foo(p: String?): Int {
         p.length
     }
     // p can be null because break is earlier than return
-    return p.<!UNSAFE_CALL!>length<!>
+    return p<!UNSAFE_CALL!>.<!>length
 }

compiler/testData/diagnostics/tests/smartCasts/loops/whileTrueEarlyBreak.fir.kt

@@ -1,11 +0,0 @@
-fun x(): Boolean { return true }
-
-public fun foo(p: String?): Int {
-    while(true) {
-        if (x()) break
-        // We do not always reach this statement
-        p!!.length
-    }
-    // Here we have while (true) loop but p is nullable due to break before
-    return p.<!UNSAFE_CALL!>length<!>
-}

compiler/testData/diagnostics/tests/smartCasts/loops/whileTrueEarlyBreak.kt

@@ -1,3 +1,4 @@
+// FIR_IDENTICAL
 fun x(): Boolean { return true }
 
 public fun foo(p: String?): Int {

compiler/testData/diagnostics/tests/smartCasts/loops/whileWithAssertInConditionAndBreakAfter.fir.kt

@@ -8,7 +8,7 @@ fun foo() {
 
     }
     // TODO: this testdata fixates undesired behavior (it should be an unsafe call)
-    x.<!UNSAFE_CALL!>length<!> // 'x' is unsoundly smartcasted here
+    x<!UNSAFE_CALL!>.<!>length // 'x' is unsoundly smartcasted here
 }
 
 fun bar() {
@@ -19,5 +19,5 @@ fun bar() {
 
     }
     // TODO: this testdata fixates undesired behavior (it should be an unsafe call)
-    x.<!UNSAFE_CALL!>size<!> // 'x' is unsoundly smartcasted here
+    x<!UNSAFE_CALL!>.<!>size // 'x' is unsoundly smartcasted here
 }

compiler/testData/diagnostics/tests/smartCasts/loops/whileWithAssertInConditionAndBreakBefore.fir.kt

@@ -7,7 +7,7 @@ fun foo() {
         break
 
     }
-    x.<!UNSAFE_CALL!>length<!> // 'x' is unsoundly smartcasted here
+    x<!UNSAFE_CALL!>.<!>length // 'x' is unsoundly smartcasted here
 }
 
 fun bar() {
@@ -17,5 +17,5 @@ fun bar() {
         break
 
     }
-    x.<!UNSAFE_CALL!>size<!> // 'x' is unsoundly smartcasted here
+    x<!UNSAFE_CALL!>.<!>size // 'x' is unsoundly smartcasted here
 }