Remove explicit jar specification from ide modules build scripts

They often change between ide versions and difficult to maintain

idea/build.gradle.kts

@@ -42,11 +42,7 @@ dependencies {
 
     compileOnly(project(":kotlin-daemon-client"))
 
-    compileOnly(intellijCoreDep()) { includeJars("intellij-core") }
+    compileOnly(intellijDep())
-    compileOnly(intellijDep()) {
-        includeJars("annotations", "openapi", "idea", "velocity", "boot", "gson", "log4j", "asm-all",
-                    "swingx-core", "forms_rt", "util", "jdom", "trove4j", "guava", rootProject = rootProject)
-    }
     compileOnly(commonDep("com.google.code.findbugs", "jsr305"))
     compileOnly(intellijPluginDep("IntelliLang"))
     compileOnly(intellijPluginDep("copyright"))
@@ -82,16 +78,16 @@ dependencies {
     (rootProject.extra["compilerModules"] as Array<String>).forEach {
         testRuntime(project(it))
     }
-    testCompileOnly(intellijCoreDep()) { includeJars("intellij-core") }
+
     testCompile(intellijPluginDep("IntelliLang"))
     testCompile(intellijPluginDep("copyright"))
     testCompile(intellijPluginDep("properties"))
     testCompile(intellijPluginDep("java-i18n"))
-    testCompileOnly(intellijDep()) { includeJars("groovy-all", "velocity", "gson", "idea_rt", "util", "log4j", rootProject = rootProject) }
+    testCompileOnly(intellijDep())
     testCompileOnly(commonDep("com.google.code.findbugs", "jsr305"))
-    testCompileOnly(intellijPluginDep("gradle")) { includeJars("gradle-base-services", "gradle-tooling-extension-impl", "gradle-wrapper", rootProject = rootProject) }
+    testCompileOnly(intellijPluginDep("gradle"))
-    testCompileOnly(intellijPluginDep("Groovy")) { includeJars("Groovy") }
+    testCompileOnly(intellijPluginDep("Groovy"))
-    testCompileOnly(intellijPluginDep("maven")) { includeJars("maven", "maven-server-api") }
+    testCompileOnly(intellijPluginDep("maven"))
 
     testRuntime(intellijPluginDep("junit"))
     testRuntime(intellijPluginDep("gradle"))

idea/formatter/build.gradle.kts

@@ -7,7 +7,7 @@ plugins {
 dependencies {
     compile(project(":compiler:util"))
     compile(project(":compiler:frontend"))
-    compileOnly(intellijDep()) { includeJars("idea", "openapi", "util", "jdom") }
+    compileOnly(intellijDep())
 }
 
 sourceSets {

idea/ide-common/build.gradle.kts

@@ -11,7 +11,7 @@ dependencies {
     compile(project(":js:js.frontend"))
     compile(project(":js:js.serializer"))
     compileOnly(intellijCoreDep()) { includeJars("intellij-core") }
-    compileOnly(intellijDep()) { includeJars("annotations", "guava", rootProject = rootProject) }
+    compileOnly(intellijDep())
 }
 
 sourceSets {

idea/idea-android/build.gradle.kts

@@ -23,10 +23,8 @@ dependencies {
     compile(androidDxJar())
 
     compileOnly(project(":kotlin-android-extensions-runtime"))
-    compileOnly(intellijDep()) { includeJars("openapi", "idea", "extensions", "util", "guava", "android-base-common", rootProject = rootProject) }
+    compileOnly(intellijDep())
-    compileOnly(intellijPluginDep("android")) {
+    compileOnly(intellijPluginDep("android"))
-        includeJars("android", "android-common", "sdk-common", "sdklib", "sdk-tools", "layoutlib-api")
-    }
 
     testCompile(projectDist(":kotlin-test:kotlin-test-jvm"))
     testCompile(projectTests(":idea:idea-test-framework")) { isTransitive = false }
@@ -37,11 +35,9 @@ dependencies {
     testCompile(projectTests(":idea:idea-gradle"))
     testCompile(commonDep("junit:junit"))
 
-    testCompile(intellijDep()) { includeJars("gson", rootProject = rootProject) }
+    testCompile(intellijDep())
     testCompile(intellijPluginDep("properties"))
-    testCompileOnly(intellijPluginDep("android")) {
+    testCompileOnly(intellijPluginDep("android"))
-        includeJars("android", "android-common", "sdk-common", "sdklib", "sdk-tools", "layoutlib-api")
-    }
 
     testRuntime(projectDist(":kotlin-reflect"))
     testRuntime(project(":plugins:android-extensions-ide"))

idea/idea-android/idea-android-output-parser/build.gradle.kts

@@ -8,9 +8,9 @@ apply { plugin("jps-compatible") }
 dependencies {
     compile(project(":compiler:util"))
     compileOnly(intellijCoreDep()) { includeJars("intellij-core") }
-    compileOnly(intellijDep()) { includeJars("guava", "android-base-common", rootProject = rootProject) }
+    compileOnly(intellijDep())
-    compileOnly(intellijPluginDep("gradle")) { includeJars("gradle-tooling-api", rootProject = rootProject) }
+    compileOnly(intellijPluginDep("gradle"))
-    compileOnly(intellijPluginDep("android")) { includeJars("android", "android-common", "sdk-common") }
+    compileOnly(intellijPluginDep("android"))
 }
 
 sourceSets {

idea/idea-core/build.gradle.kts

@@ -22,8 +22,8 @@ dependencies {
     compile(commonDep("org.jetbrains.kotlinx", "kotlinx-coroutines-core")) { isTransitive = false }
     compile(commonDep("org.jetbrains.kotlinx", "kotlinx-coroutines-jdk8")) { isTransitive = false }
     compileOnly(intellijCoreDep()) { includeJars("intellij-core") }
-    compileOnly(intellijDep()) { includeJars("util", "openapi", "idea", "asm-all", "jdom", "annotations", "trove4j", "guava", rootProject = rootProject) }
+    compileOnly(intellijDep())
-    compileOnly(intellijPluginDep("gradle")) { includeJars("gradle-tooling-api", "gradle", rootProject = rootProject) }
+    compileOnly(intellijPluginDep("gradle"))
 }
 
 sourceSets {

idea/idea-gradle/build.gradle.kts

@@ -16,33 +16,17 @@ dependencies {
 
     compile(project(":js:js.frontend"))
 
-    compileOnly(intellijDep()) { includeJars("openapi", "idea", "external-system-rt", "forms_rt", "extensions", "jdom", "util") }
+    compileOnly(intellijDep())
-    compileOnly(intellijPluginDep("gradle")) {
+    compileOnly(intellijPluginDep("gradle"))
-        includeJars(
+    compileOnly(intellijPluginDep("Groovy"))
-            "gradle-tooling-api",
+    compileOnly(intellijPluginDep("junit"))
-            "gradle",
-            "gradle-base-services",
-            rootProject = rootProject
-        )
-    }
-    compileOnly(intellijPluginDep("Groovy")) { includeJars("Groovy") }
-    compileOnly(intellijPluginDep("junit")) { includeJars("idea-junit") }
 
     testCompile(projectTests(":idea"))
     testCompile(projectTests(":idea:idea-test-framework"))
 
-    testCompile(intellijPluginDep("gradle")) {
+    testCompile(intellijPluginDep("gradle"))
-        includeJars(
+    testCompileOnly(intellijPluginDep("Groovy"))
-            "gradle-wrapper",
+    testCompileOnly(intellijDep())
-            "gradle-base-services",
-            "gradle-tooling-extension-impl",
-            "gradle-tooling-api",
-            "gradle",
-            rootProject = rootProject
-        )
-    }
-    testCompileOnly(intellijPluginDep("Groovy")) { includeJars("Groovy") }
-    testCompileOnly(intellijDep()) { includeJars("groovy-all", "idea_rt", rootProject = rootProject) }
 
     testRuntime(projectDist(":kotlin-reflect"))
     testRuntime(project(":idea:idea-jvm"))
@@ -55,11 +39,11 @@ dependencies {
     testRuntime(project(":noarg-ide-plugin"))
     // TODO: the order of the plugins matters here, consider avoiding order-dependency
     testRuntime(intellijPluginDep("junit"))
-    testRuntime(intellijPluginDep("testng")) { includeJars("jcommander", "resources_en") }
+    testRuntime(intellijPluginDep("testng"))
-    testRuntime(intellijPluginDep("properties")) { includeJars("resources_en") }
+    testRuntime(intellijPluginDep("properties"))
     testRuntime(intellijPluginDep("gradle"))
     testRuntime(intellijPluginDep("Groovy"))
-    testRuntime(intellijPluginDep("coverage")) { includeJars("jacocoant") }
+    testRuntime(intellijPluginDep("coverage"))
     testRuntime(intellijPluginDep("maven"))
     testRuntime(intellijPluginDep("android"))
 }

idea/idea-jps-common/build.gradle.kts

@@ -11,7 +11,7 @@ dependencies {
     compile(project(":compiler:cli-common"))
     compile(project(":compiler:frontend.java"))
     compileOnly(intellijCoreDep()) { includeJars("intellij-core") }
-    compileOnly(intellijDep()) { includeJars("jdom", "util") }
+    compileOnly(intellijDep())
 }
 
 sourceSets {

idea/idea-jvm/build.gradle.kts

@@ -8,15 +8,13 @@ dependencies {
     compile(project(":idea"))
     compile(project(":compiler:light-classes"))
     compile(project(":compiler:frontend.java"))
-    compileOnly(intellijDep()) { includeJars("annotations", "openapi", "idea", "extensions", "util", "velocity", "boot", "gson",
+    compileOnly(intellijDep())
-                                             "swingx-core", "forms_rt", "jdom", "log4j", "guava", "asm-all", "picocontainer",
-                                             rootProject = rootProject) }
     compileOnly(commonDep("com.google.code.findbugs", "jsr305"))
 
-    compileOnly(intellijPluginDep("junit")) { includeJars("idea-junit") }
+    compileOnly(intellijPluginDep("junit"))
-    compileOnly(intellijPluginDep("testng")) { includeJars("testng", "testng-plugin") }
+    compileOnly(intellijPluginDep("testng"))
-    compileOnly(intellijPluginDep("coverage")) { includeJars("coverage") }
+    compileOnly(intellijPluginDep("coverage"))
-    compileOnly(intellijPluginDep("java-decompiler")) { includeJars("java-decompiler") }
+    compileOnly(intellijPluginDep("java-decompiler"))
     compileOnly(intellijPluginDep("IntelliLang"))
     compileOnly(intellijPluginDep("copyright"))
     compileOnly(intellijPluginDep("properties"))

idea/idea-maven/build.gradle.kts

@@ -18,15 +18,15 @@ dependencies {
     compile(project(":idea:idea-jvm"))
     compile(project(":idea:idea-jps-common"))
 
-    compileOnly(intellijDep()) { includeJars("openapi", "idea", "gson", "jdom", "extensions", "util", rootProject = rootProject) }
+    compileOnly(intellijDep())
-    excludeInAndroidStudio(rootProject) { compileOnly(intellijPluginDep("maven")) { includeJars("maven", "maven-server-api") } }
+    excludeInAndroidStudio(rootProject) { compileOnly(intellijPluginDep("maven")) }
 
     testCompile(projectTests(":idea"))
     testCompile(projectTests(":compiler:tests-common"))
     testCompile(projectTests(":idea:idea-test-framework"))
 
-    testCompileOnly(intellijDep()) { includeJars("openapi", "idea", "gson", "idea_rt", rootProject = rootProject) }
+    testCompileOnly(intellijDep())
-    testCompileOnly(intellijPluginDep("maven")) { includeJars("maven", "maven-server-api") }
+    testCompileOnly(intellijPluginDep("maven"))
 
     testRuntime(projectDist(":kotlin-reflect"))
     testRuntime(project(":idea:idea-jvm"))
@@ -40,11 +40,11 @@ dependencies {
     testRuntime(intellijDep())
     // TODO: the order of the plugins matters here, consider avoiding order-dependency
     testRuntime(intellijPluginDep("junit"))
-    testRuntime(intellijPluginDep("testng")) { includeJars("jcommander", "resources_en") }
+    testRuntime(intellijPluginDep("testng"))
-    testRuntime(intellijPluginDep("properties")) { includeJars("resources_en") }
+    testRuntime(intellijPluginDep("properties"))
     testRuntime(intellijPluginDep("gradle"))
     testRuntime(intellijPluginDep("Groovy"))
-    testRuntime(intellijPluginDep("coverage")) { includeJars("jacocoant") }
+    testRuntime(intellijPluginDep("coverage"))
     testRuntime(intellijPluginDep("maven"))
     testRuntime(intellijPluginDep("android"))
 }

idea/idea-test-framework/build.gradle.kts

@@ -15,7 +15,7 @@ dependencies {
     testCompile(project(":kotlin-test:kotlin-test-jvm"))
     testCompileOnly(project(":kotlin-reflect-api"))
     testCompile(commonDep("junit:junit"))
-    testCompileOnly(intellijDep()) { includeJars("openapi", "idea", "log4j") }
+    testCompileOnly(intellijDep())
 }
 
 sourceSets {

idea/kotlin-gradle-tooling/build.gradle.kts

@@ -11,14 +11,7 @@ jvmTarget = "1.6"
 dependencies {
     compile(projectDist(":kotlin-stdlib"))
     compile(project(":compiler:cli-common"))
-    compile(intellijPluginDep("gradle")) {
+    compile(intellijPluginDep("gradle"))
-        includeJars("gradle-tooling-api",
-                    "gradle-tooling-extension-api",
-                    "gradle",
-                    "gradle-core",
-                    "gradle-base-services-groovy",
-                    rootProject = rootProject)
-    }
 }
 
 sourceSets {

plugins/allopen/allopen-ide/build.gradle.kts

@@ -17,9 +17,9 @@ dependencies {
     compile(project(":idea:idea-jvm"))
     compile(project(":idea:idea-jps-common"))
     compile(project(":plugins:annotation-based-compiler-plugins-ide-support"))
-    compileOnly(intellijDep()) { includeJars("openapi", "idea", "util", "extensions") }
+    compileOnly(intellijDep())
-    excludeInAndroidStudio(rootProject) { compileOnly(intellijPluginDep("maven")) { includeJars("maven") } }
+    excludeInAndroidStudio(rootProject) { compileOnly(intellijPluginDep("maven")) }
-    compileOnly(intellijPluginDep("gradle")) { includeJars("gradle-tooling-api", "gradle", rootProject = rootProject) }
+    compileOnly(intellijPluginDep("gradle"))
 }
 
 sourceSets {

plugins/android-extensions/android-extensions-idea/build.gradle.kts

@@ -19,9 +19,9 @@ dependencies {
     compile(project(":idea:idea-gradle"))
     compile(project(":plugins:android-extensions-compiler"))
     compileOnly(project(":kotlin-android-extensions-runtime"))
-    compileOnly(intellijPluginDep("android")) { includeJars("android", "android-common", "sdk-common", "sdk-tools") }
+    compileOnly(intellijPluginDep("android"))
-    compileOnly(intellijPluginDep("Groovy")) { includeJars("Groovy") }
+    compileOnly(intellijPluginDep("Groovy"))
-    compileOnly(intellijDep()) { includeJars("extensions", "openapi", "util", "idea", "android-base-common", rootProject = rootProject) }
+    compileOnly(intellijDep())
 
     testCompile(project(":compiler:tests-common"))
     testCompile(project(":compiler:cli"))
@@ -34,9 +34,9 @@ dependencies {
     testCompile(projectDist(":kotlin-test:kotlin-test-jvm"))
     testCompile(commonDep("junit:junit"))
     testRuntime(projectDist(":kotlin-reflect"))
-    testCompile(intellijPluginDep("android")) { includeJars("android", "android-common", "sdk-common", "sdk-tools") }
+    testCompile(intellijPluginDep("android"))
-    testCompile(intellijPluginDep("Groovy")) { includeJars("Groovy") }
+    testCompile(intellijPluginDep("Groovy"))
-    testCompile(intellijDep()) { includeJars("extensions") }
+    testCompile(intellijDep())
 
     testRuntime(project(":idea:idea-jvm"))
     testRuntime(project(":plugins:android-extensions-jps"))

plugins/annotation-based-compiler-plugins-ide-support/build.gradle.kts

@@ -15,9 +15,9 @@ dependencies {
     compile(project(":idea:idea-jps-common"))
     compile(project(":idea:idea-gradle"))
     compile(project(":idea:idea-maven"))
-    excludeInAndroidStudio(rootProject) { compileOnly(intellijPluginDep("maven")) { includeJars("maven", "maven-server-api") } }
+    excludeInAndroidStudio(rootProject) { compileOnly(intellijPluginDep("maven")) }
-    compileOnly(intellijPluginDep("gradle")) { includeJars("gradle-tooling-api", "gradle", rootProject = rootProject) }
+    compileOnly(intellijPluginDep("gradle"))
-    compileOnly(intellijDep()) { includeJars("openapi", "idea", "extensions", "jdom", "util") }
+    compileOnly(intellijDep())
  }
 
 sourceSets {

plugins/kapt3/kapt3-idea/build.gradle.kts

@@ -12,9 +12,9 @@ dependencies {
     compile(project(":idea")) { isTransitive = false }
     compile(project(":idea:kotlin-gradle-tooling"))
     compile(project(":kotlin-annotation-processing"))
-    compileOnly(intellijDep()) { includeJars("openapi", "external-system-rt", "util") }
+    compileOnly(intellijDep())
-    compileOnly(intellijPluginDep("gradle")) { includeJars("gradle-core", "gradle-tooling-api", "gradle", rootProject = rootProject) }
+    compileOnly(intellijPluginDep("gradle"))
-    compileOnly(intellijPluginDep("android")) { includeJars("android", "android-common", "sdklib", "sdk-common", "sdk-tools") }
+    compileOnly(intellijPluginDep("android"))
 }
 
 sourceSets {

plugins/lint/build.gradle.kts

@@ -13,12 +13,8 @@ dependencies {
     compile(project(":idea:idea-android"))
     compile(project(":plugins:uast-kotlin"))
     compileOnly(project(":kotlin-android-extensions-runtime"))
-    compileOnly(intellijCoreDep()) { includeJars("intellij-core") }
+    compileOnly(intellijDep())
-    compileOnly(intellijDep()) { includeJars("util", "guava", "openapi", "idea", "asm-all", "annotations", rootProject = rootProject) }
+    compileOnly(intellijPluginDep("android"))
-    compileOnly(intellijPluginDep("android")) {
-        includeJars("android", "android-common", "sdklib", "sdk-common", "sdk-tools",
-                    "repository", "lombok-ast", "layoutlib-api", "kxml2", rootProject = rootProject)
-    }
 }
 
 sourceSets {

plugins/noarg/noarg-ide/build.gradle.kts

@@ -18,9 +18,9 @@ dependencies {
     compile(project(":idea"))
     compile(project(":idea:idea-jps-common"))
     compile(project(":plugins:annotation-based-compiler-plugins-ide-support"))
-    compileOnly(intellijDep()) { includeJars("openapi", "idea", "util", "extensions") }
+    compileOnly(intellijDep())
-    excludeInAndroidStudio(rootProject) { compileOnly(intellijPluginDep("maven")) { includeJars("maven") } }
+    excludeInAndroidStudio(rootProject) { compileOnly(intellijPluginDep("maven")) }
-    compileOnly(intellijPluginDep("gradle")) { includeJars("gradle-tooling-api", "gradle", rootProject = rootProject) }
+    compileOnly(intellijPluginDep("gradle"))
 }
 
 sourceSets {

plugins/uast-kotlin-idea/build.gradle.kts

@@ -11,7 +11,7 @@ dependencies {
     compile(project(":compiler:frontend.java"))
     compile(project(":idea:ide-common"))
     compile(project(":plugins:uast-kotlin"))
-    compileOnly(intellijDep()) { includeJars("openapi", "util") }
+    compileOnly(intellijDep())
 }
 
 sourceSets {