[FIR IDE] Resolve explicit invoke calls more correctly

Also, enable some muted tests

^KTIJ-21343 Fixed

analysis/analysis-api-fir/src/org/jetbrains/kotlin/analysis/api/fir/FirUtils.kt

@@ -28,21 +28,6 @@ import org.jetbrains.kotlin.psi.KtNameReferenceExpression
 import org.jetbrains.kotlin.util.OperatorNameConventions
 import org.jetbrains.kotlin.utils.addToStdlib.safeAs
 
-/**
- * Checks if the function call is an implicit invoke call with a simple qualified receiver, or looks like it.
- *
- * For example, `foo()` and `foo.bar()` have simple qualified receivers, while `foo!!()`, `{}()` and `(foo ?: bar)()` - don't.
- *
- * @return `true` if the function call has a simple qualified receiver and is an implicit invoke call,
- * or looks like it and resolves to the `invoke` function.
- */
-fun FirFunctionCall.isImplicitFunctionCall(): Boolean {
-    if (extensionReceiver !is FirQualifiedAccessExpression && dispatchReceiver !is FirQualifiedAccessExpression) return false
-
-    return this is FirImplicitInvokeCall ||
-            calleeReference.getCandidateSymbols().any(FirBasedSymbol<*>::isInvokeFunction)
-}
-
 /**
  * Returns `true` if the symbol is for a function named `invoke`.
  */

analysis/analysis-api-fir/src/org/jetbrains/kotlin/analysis/api/fir/references/FirReferenceResolveHelper.kt

@@ -340,19 +340,13 @@ internal object FirReferenceResolveHelper {
         if (expression is KtLabelReferenceExpression && fir is FirPropertyAccessExpression && fir.calleeReference is FirSuperReference) {
             return listOfNotNull((fir.dispatchReceiver.typeRef as? FirResolvedTypeRef)?.toTargetSymbol(session, symbolBuilder))
         }
-        val calleeReference =
+        val implicitInvokeReceiver = if (fir is FirImplicitInvokeCall) {
-            if (fir is FirFunctionCall &&
+            fir.explicitReceiver as? FirQualifiedAccessExpression
-                fir.isImplicitFunctionCall() &&
+        } else {
-                expression is KtNameReferenceExpression
+            null
-            ) {
+        }
-                // we are resolving implicit invoke call, like
+        val calleeReference = implicitInvokeReceiver?.calleeReference ?: fir.calleeReference
-                // fun foo(a: () -> Unit) {
+
-                //     <expression>a</expression>()
-                // }
-                val receiver =
-                    fir.dispatchReceiver as? FirQualifiedAccessExpression ?: fir.extensionReceiver as FirQualifiedAccessExpression
-                receiver.calleeReference
-            } else fir.calleeReference
         return calleeReference.toTargetSymbol(session, symbolBuilder, isInLabelReference = expression is KtLabelReferenceExpression)
     }
 

analysis/analysis-api-fir/tests/org/jetbrains/kotlin/analysis/api/fir/FirLibrarySourceReferenceResolveTestGenerated.java

@@ -142,6 +142,18 @@ public class FirLibrarySourceReferenceResolveTestGenerated extends AbstractRefer
         runTest("analysis/analysis-api/testData/referenceResolve/EnumValues.kt");
     }
 
+    @Test
+    @TestMetadata("explicitFunctionalInterfaceInvoke_globalVal.kt")
+    public void testExplicitFunctionalInterfaceInvoke_globalVal() throws Exception {
+        runTest("analysis/analysis-api/testData/referenceResolve/explicitFunctionalInterfaceInvoke_globalVal.kt");
+    }
+
+    @Test
+    @TestMetadata("explicitFunctionalInterfaceInvoke_parameter.kt")
+    public void testExplicitFunctionalInterfaceInvoke_parameter() throws Exception {
+        runTest("analysis/analysis-api/testData/referenceResolve/explicitFunctionalInterfaceInvoke_parameter.kt");
+    }
+
     @Test
     @TestMetadata("ExternalCompanionObject.kt")
     public void testExternalCompanionObject() throws Exception {
@@ -508,6 +520,12 @@ public class FirLibrarySourceReferenceResolveTestGenerated extends AbstractRefer
         runTest("analysis/analysis-api/testData/referenceResolve/TopLevelObjectVsLocalClassConstructor3.kt");
     }
 
+    @Test
+    @TestMetadata("TopLevelObjectVsLocalClassConstructor4.kt")
+    public void testTopLevelObjectVsLocalClassConstructor4() throws Exception {
+        runTest("analysis/analysis-api/testData/referenceResolve/TopLevelObjectVsLocalClassConstructor4.kt");
+    }
+
     @Test
     @TestMetadata("TopLevelObjectVsLocalClassQualifier.kt")
     public void testTopLevelObjectVsLocalClassQualifier() throws Exception {

analysis/analysis-api-fir/tests/org/jetbrains/kotlin/analysis/api/fir/FirSourceReferenceResolveTestGenerated.java

@@ -142,6 +142,18 @@ public class FirSourceReferenceResolveTestGenerated extends AbstractReferenceRes
         runTest("analysis/analysis-api/testData/referenceResolve/EnumValues.kt");
     }
 
+    @Test
+    @TestMetadata("explicitFunctionalInterfaceInvoke_globalVal.kt")
+    public void testExplicitFunctionalInterfaceInvoke_globalVal() throws Exception {
+        runTest("analysis/analysis-api/testData/referenceResolve/explicitFunctionalInterfaceInvoke_globalVal.kt");
+    }
+
+    @Test
+    @TestMetadata("explicitFunctionalInterfaceInvoke_parameter.kt")
+    public void testExplicitFunctionalInterfaceInvoke_parameter() throws Exception {
+        runTest("analysis/analysis-api/testData/referenceResolve/explicitFunctionalInterfaceInvoke_parameter.kt");
+    }
+
     @Test
     @TestMetadata("ExternalCompanionObject.kt")
     public void testExternalCompanionObject() throws Exception {
@@ -508,6 +520,12 @@ public class FirSourceReferenceResolveTestGenerated extends AbstractReferenceRes
         runTest("analysis/analysis-api/testData/referenceResolve/TopLevelObjectVsLocalClassConstructor3.kt");
     }
 
+    @Test
+    @TestMetadata("TopLevelObjectVsLocalClassConstructor4.kt")
+    public void testTopLevelObjectVsLocalClassConstructor4() throws Exception {
+        runTest("analysis/analysis-api/testData/referenceResolve/TopLevelObjectVsLocalClassConstructor4.kt");
+    }
+
     @Test
     @TestMetadata("TopLevelObjectVsLocalClassQualifier.kt")
     public void testTopLevelObjectVsLocalClassQualifier() throws Exception {

analysis/analysis-api/testData/referenceResolve/TopLevelObjectVsLocalClassConstructor3.kt

@@ -1,5 +1,3 @@
-// IGNORE_FIR
-
 package test
 
 object Conflict {

analysis/analysis-api/testData/referenceResolve/TopLevelObjectVsLocalClassConstructor4.kt

@@ -0,0 +1,12 @@
+package test
+
+object Conflict
+
+operator fun Conflict.invoke() {}
+
+fun test() {
+    class Conflict(i: Int)
+
+    <caret>Conflict()
+}
+

analysis/analysis-api/testData/referenceResolve/TopLevelObjectVsLocalClassConstructor4.txt

@@ -0,0 +1,2 @@
+Resolved to:
+0: (in test) operator fun test.Conflict.invoke()

analysis/analysis-api/testData/referenceResolve/explicitFunctionalInterfaceInvoke_globalVal.kt

@@ -0,0 +1,9 @@
+fun interface A {
+    operator fun invoke()
+}
+
+val globalA: A = A {}
+
+fun foo() {
+    globalA.invo<caret>ke()
+}

analysis/analysis-api/testData/referenceResolve/explicitFunctionalInterfaceInvoke_globalVal.txt

@@ -0,0 +1,2 @@
+Resolved to:
+0: (in A) operator fun invoke()

analysis/analysis-api/testData/referenceResolve/explicitFunctionalInterfaceInvoke_parameter.kt

@@ -0,0 +1,7 @@
+fun interface A {
+    operator fun invoke()
+}
+
+fun foo(param: A) {
+    param.invo<caret>ke()
+}

analysis/analysis-api/testData/referenceResolve/explicitFunctionalInterfaceInvoke_parameter.txt

@@ -0,0 +1,2 @@
+Resolved to:
+0: (in A) operator fun invoke()