From 79e2886da11b168d1f16ce3911a9c8c5727dfcec Mon Sep 17 00:00:00 2001
From: Roman Artemev <roman.artemev@jetbrains.com>
Date: Wed, 9 Sep 2020 16:15:04 +0300
Subject: [PATCH] [IR] Add `isHidden` flag into IrValueParameter

---
 .../kotlin/ir/declarations/impl/IrValueParameterImpl.kt      | 3 ++-
 .../ir/declarations/persistent/PersistentIrValueParameter.kt | 5 +++--
 .../org/jetbrains/kotlin/ir/declarations/IrValueParameter.kt | 5 +++++
 3 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/compiler/ir/ir.tree.impl/src/org/jetbrains/kotlin/ir/declarations/impl/IrValueParameterImpl.kt b/compiler/ir/ir.tree.impl/src/org/jetbrains/kotlin/ir/declarations/impl/IrValueParameterImpl.kt
index 493ea69a2b9..da3370ea42c 100644
--- a/compiler/ir/ir.tree.impl/src/org/jetbrains/kotlin/ir/declarations/impl/IrValueParameterImpl.kt
+++ b/compiler/ir/ir.tree.impl/src/org/jetbrains/kotlin/ir/declarations/impl/IrValueParameterImpl.kt
@@ -38,7 +38,8 @@ class IrValueParameterImpl(
     override val type: IrType,
     override val varargElementType: IrType?,
     override val isCrossinline: Boolean,
-    override val isNoinline: Boolean
+    override val isNoinline: Boolean,
+    override val isHidden: Boolean = false
 ) : IrValueParameter() {
     @ObsoleteDescriptorBasedAPI
     override val descriptor: ParameterDescriptor
diff --git a/compiler/ir/ir.tree.persistent/src/org/jetbrains/kotlin/ir/declarations/persistent/PersistentIrValueParameter.kt b/compiler/ir/ir.tree.persistent/src/org/jetbrains/kotlin/ir/declarations/persistent/PersistentIrValueParameter.kt
index 7746e667b33..e732cace35e 100644
--- a/compiler/ir/ir.tree.persistent/src/org/jetbrains/kotlin/ir/declarations/persistent/PersistentIrValueParameter.kt
+++ b/compiler/ir/ir.tree.persistent/src/org/jetbrains/kotlin/ir/declarations/persistent/PersistentIrValueParameter.kt
@@ -40,7 +40,8 @@ internal class PersistentIrValueParameter(
     override val type: IrType,
     override val varargElementType: IrType?,
     override val isCrossinline: Boolean,
-    override val isNoinline: Boolean
+    override val isNoinline: Boolean,
+    override val isHidden: Boolean = false
 ) : IrValueParameter(),
     PersistentIrDeclarationBase<ValueParameterCarrier>,
     ValueParameterCarrier {
@@ -52,7 +53,7 @@ internal class PersistentIrValueParameter(
     init {
         symbol.bind(this)
     }
-
+    
     override var lastModified: Int = stageController.currentStage
     override var loweredUpTo: Int = stageController.currentStage
     override var values: Array<Carrier>? = null
diff --git a/compiler/ir/ir.tree/src/org/jetbrains/kotlin/ir/declarations/IrValueParameter.kt b/compiler/ir/ir.tree/src/org/jetbrains/kotlin/ir/declarations/IrValueParameter.kt
index 8e62f0db2cc..ea6526ecf63 100644
--- a/compiler/ir/ir.tree/src/org/jetbrains/kotlin/ir/declarations/IrValueParameter.kt
+++ b/compiler/ir/ir.tree/src/org/jetbrains/kotlin/ir/declarations/IrValueParameter.kt
@@ -32,6 +32,11 @@ abstract class IrValueParameter : IrValueDeclaration(), IrSymbolDeclaration<IrVa
     abstract val varargElementType: IrType?
     abstract val isCrossinline: Boolean
     abstract val isNoinline: Boolean
+    // if true parameter is not included into IdSignature.
+    // Skipping hidden params makes IrFunction be look similar to FE.
+    // NOTE: it is introduced to fix KT-40980 because more clear solution was not possible to implement.
+    // Once we are able to load any top-level declaration from klib this hack should be deprecated and removed.
+    abstract val isHidden: Boolean
 
     abstract var defaultValue: IrExpressionBody?