From 78d3c7ef47228c7cac0a314e6a9815967abafc6e Mon Sep 17 00:00:00 2001 From: James Strachan Date: Sat, 17 Mar 2012 16:38:50 +0000 Subject: [PATCH] switched back to cleaner nested functions & used the same name --- .../stdlib/test/language/scala/OptionTest.kt | 58 +++++++++---------- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/libraries/stdlib/test/language/scala/OptionTest.kt b/libraries/stdlib/test/language/scala/OptionTest.kt index 23977c75e9e..e08a31813f1 100644 --- a/libraries/stdlib/test/language/scala/OptionTest.kt +++ b/libraries/stdlib/test/language/scala/OptionTest.kt @@ -62,7 +62,7 @@ class OptionTest: TestCase() { } fun testPatternMatchingUsingIf() { - fun foo2(request: Request): String { + fun foo(request: Request): String { /* Scala: @@ -86,40 +86,40 @@ class OptionTest: TestCase() { } } - assertEquals("No name value", foo2(Request(null))) - assertEquals("BAR", foo2(Request("BAR"))) - assertEquals("BAR", foo2(Request(" bar "))) + assertEquals("No name value", foo(Request(null))) + assertEquals("BAR", foo(Request("BAR"))) + assertEquals("BAR", foo(Request(" bar "))) - println("foo2(Request(null)) = ${foo2(Request(null))}") - println("foo2(Request(\" bar \")) = ${foo2(Request(" bar "))}") + println("foo(Request(null)) = ${foo(Request(null))}") + println("foo(Request(\" bar \")) = ${foo(Request(" bar "))}") } fun testFunctionComposition() { - assertEquals("", foo3(Request(null))) - assertEquals("", foo3(Request(" "))) - assertEquals("BAR", foo3(Request(" bar "))) - } - - fun foo3(request: Request): String { - /* Scala: - - val name:Option[String] = request.getParameter("name") - val upper = name map { _.trim } filter { _.length != 0 } map { _.toUpperCase } - println(upper.getOrElse("")) - */ - - val name = request.getParameter("name") - val upper = name.map{ it.trim() }.filter{ it.length != 0 }.map{ it.toUpperCase() } - return upper ?: "" - - // TODO when http://youtrack.jetbrains.com/issue/KT-1145 is fixed - // we can get rid of the unnecessary on map + fun foo(request: Request): String { + /* Scala: + + val name:Option[String] = request.getParameter("name") + val upper = name map { _.trim } filter { _.length != 0 } map { _.toUpperCase } + println(upper.getOrElse("")) + */ + + val name = request.getParameter("name") + val upper = name.map{ it.trim() }.filter{ it.length != 0 }.map{ it.toUpperCase() } + return upper ?: "" + + // TODO when http://youtrack.jetbrains.com/issue/KT-1145 is fixed + // we can get rid of the unnecessary on map + } + + assertEquals("", foo(Request(null))) + assertEquals("", foo(Request(" "))) + assertEquals("BAR", foo(Request(" bar "))) } fun testCompositionWithFor() { - fun foo4(request: Request): String { + fun foo(request: Request): String { /* Scala: val upper = for { @@ -143,8 +143,8 @@ class OptionTest: TestCase() { return "" } - assertEquals("", foo4(Request(null))) - assertEquals("", foo4(Request(""))) - assertEquals("BAR", foo4(Request(" bar "))) + assertEquals("", foo(Request(null))) + assertEquals("", foo(Request(""))) + assertEquals("BAR", foo(Request(" bar "))) } } \ No newline at end of file