[FIR] Report all `Visibilities.Unknown` in `FirOverrideChecker`

Check all members for `Visibility.Unknown`,
otherwise we miss them when they come
from supertypes. This is the reason why
the FP intellij build failed with a
cryptic stacktrace instead of a
human-readable diagnostic.

Also, do report the diagnostic at all
cases of `Visibilities.Unknown`. Turns
out, there are no "simple to reason
about" situations here :(

Also, an interesting detail:
`retrieveDirectOverriddenOf` returns an
empty list for intersection overrides.
But this doesn't seem to break anything...

Replacing `CANNOT_INFER_VISIBILITY`'s
type `KtDeclaration` with
`PsiNameIdentifierOwner` and the related
changes in `PositioningStrategies`
were needed to prevent an exception saying that
`PsiClassImpl` is not a subtype of
`KtDeclaration`.

This commit is contained in:

Nikolay Lunyak

2024-02-20 14:20:22 +02:00

committed by

Space Team

parent 053eb07692

commit 76ed5453b3

27 changed files with 149 additions and 46 deletions

									
										compiler/testData/diagnostics/tests/j+k/primitiveOverrides/triangleWithFlexibleTypeAndSubstitution4.fir.kt
									
Vendored

		+1
		-1
	
												View File
												
				@@ -21,7 +21,7 @@ open class C : A<Int>()

				interface D : B<Int>

				<!MANY_IMPL_MEMBER_NOT_IMPLEMENTED!>class E<!> : C(), D

				<!CANNOT_INFER_VISIBILITY, MANY_IMPL_MEMBER_NOT_IMPLEMENTED!>class E<!> : C(), D

				fun main() {

				    E().foo(42)

[FIR] Report all Visibilities.Unknown in FirOverrideChecker

[FIR] Report all `Visibilities.Unknown` in `FirOverrideChecker`