[FIR] Report all `Visibilities.Unknown` in `FirOverrideChecker`

Check all members for `Visibility.Unknown`,
otherwise we miss them when they come
from supertypes. This is the reason why
the FP intellij build failed with a
cryptic stacktrace instead of a
human-readable diagnostic.

Also, do report the diagnostic at all
cases of `Visibilities.Unknown`. Turns
out, there are no "simple to reason
about" situations here :(

Also, an interesting detail:
`retrieveDirectOverriddenOf` returns an
empty list for intersection overrides.
But this doesn't seem to break anything...

Replacing `CANNOT_INFER_VISIBILITY`'s
type `KtDeclaration` with
`PsiNameIdentifierOwner` and the related
changes in `PositioningStrategies`
were needed to prevent an exception saying that
`PsiClassImpl` is not a subtype of
`KtDeclaration`.

This commit is contained in:

Nikolay Lunyak

2024-02-20 14:20:22 +02:00

committed by

Space Team

parent 053eb07692

commit 76ed5453b3

27 changed files with 149 additions and 46 deletions

									
										compiler/testData/diagnostics/tests/intersectionWithMultipleDefaultsInJava.kt
									
Vendored

		-1
	
												View File
												
				@@ -1,4 +1,3 @@

				// FIR_IDENTICAL

				// TARGET_BACKEND: JVM

				// FILE: IntCollection.java

[FIR] Report all Visibilities.Unknown in FirOverrideChecker

[FIR] Report all `Visibilities.Unknown` in `FirOverrideChecker`