Fixed wrong linearization for open classes and traits.

openList changed during neighbors calculation because the same TLinkable object cannot be put into more than one TLinkedList at the same time.

#KT-3499 fixed

js/js.tests/test/org/jetbrains/k2js/test/semantics/ClassInheritanceTest.java

@@ -55,6 +55,10 @@ public final class ClassInheritanceTest extends SingleFileTranslationTest {
     public void testAbstractVarOverride() throws Exception {
         fooBoxTest();
     }
+
+    public void testKt3499() throws Exception {
+        fooBoxTest();
+    }
 }
 
 

js/js.translator/src/org/jetbrains/k2js/translate/declaration/ClassDeclarationTranslator.java

@@ -129,7 +129,7 @@ public final class ClassDeclarationTranslator extends AbstractTranslator {
                     @NotNull
                     @Override
                     public Iterable<FinalListItem> getNeighbors(FinalListItem current) {
-                        TLinkedList<FinalListItem> parents = new TLinkedList<FinalListItem>();
+                        LinkedList<FinalListItem> parents = new LinkedList<FinalListItem>();
                         ClassDescriptor classDescriptor = getClassDescriptor(context().bindingContext(), current.declaration);
                         Collection<JetType> superTypes = classDescriptor.getTypeConstructor().getSupertypes();
 
@@ -147,6 +147,8 @@ public final class ClassDeclarationTranslator extends AbstractTranslator {
                     }
                 });
 
+        assert sortedOpenClasses.size() == openList.size();
+
         // second pass: generate
         Iterator<FinalListItem> it = sortedOpenClasses.descendingIterator();
         while (it.hasNext()) {

js/js.translator/testFiles/inheritance/cases/kt3499.kt

@@ -0,0 +1,13 @@
+package foo
+
+trait A : B, E
+trait B
+open class C {
+  fun foo() = true
+}
+trait D
+trait E
+trait F : G, D
+trait G
+
+fun box() = C().foo()