[FIR] fix contract violation from meta annotations

^KT-60448 Fixed

compiler/fir/resolve/src/org/jetbrains/kotlin/fir/extensions/FirPredicateBasedProviderImpl.kt

@@ -215,12 +215,13 @@ fun FirRegularClassSymbol?.markedWithMetaAnnotationImpl(
     session: FirSession,
     metaAnnotations: Set<AnnotationFqn>,
     includeItself: Boolean,
-    visited: MutableSet<FirRegularClassSymbol>
+    visited: MutableSet<FirRegularClassSymbol>,
+    resolvedCompilerAnnotations: (FirRegularClassSymbol) -> List<FirAnnotation> = FirBasedSymbol<*>::resolvedCompilerAnnotationsWithClassIds,
 ): Boolean {
     if (this == null) return false
     if (!visited.add(this)) return false
     if (this.classId.asSingleFqName() in metaAnnotations) return includeItself
-    return this.resolvedCompilerAnnotationsWithClassIds
+    return resolvedCompilerAnnotations(this)
         .mapNotNull { it.annotationTypeRef.coneTypeSafe<ConeKotlinType>()?.toRegularClassSymbol(session) }
-        .any { it.markedWithMetaAnnotationImpl(session, metaAnnotations, includeItself = true, visited) }
+        .any { it.markedWithMetaAnnotationImpl(session, metaAnnotations, includeItself = true, visited, resolvedCompilerAnnotations) }
 }

compiler/fir/resolve/src/org/jetbrains/kotlin/fir/resolve/transformers/plugin/AbstractFirSpecificAnnotationResolveTransformer.kt

@@ -276,7 +276,10 @@ abstract class AbstractFirSpecificAnnotationResolveTransformer(
     }
 
     private fun ConeKotlinType.markedWithMetaAnnotation(session: FirSession, metaAnnotations: Set<AnnotationFqn>): Boolean {
-        return toRegularClassSymbol(session).markedWithMetaAnnotationImpl(session, metaAnnotations, includeItself = true, mutableSetOf())
+        return toRegularClassSymbol(session).markedWithMetaAnnotationImpl(session, metaAnnotations, includeItself = true, mutableSetOf()) {
+            computationSession.resolveAnnotationsOnAnnotationIfNeeded(it, scopeSession)
+            it.annotations
+        }
     }
 
 

plugins/allopen/testData/diagnostics/kt60448.kt

@@ -0,0 +1,9 @@
+// FIR_IDENTICAL
+// WITH_STDLIB
+annotation class AllOpen
+
+@AllOpen
+class Test {
+    @JvmName("g")
+    private fun f() {}
+}

plugins/allopen/tests-gen/org/jetbrains/kotlin/allopen/DiagnosticTestForAllOpenBaseGenerated.java

@@ -30,6 +30,12 @@ public class DiagnosticTestForAllOpenBaseGenerated extends AbstractDiagnosticTes
         runTest("plugins/allopen/testData/diagnostics/kt54260.kt");
     }
 
+    @Test
+    @TestMetadata("kt60448.kt")
+    public void testKt60448() throws Exception {
+        runTest("plugins/allopen/testData/diagnostics/kt60448.kt");
+    }
+
     @Test
     @TestMetadata("smartcast.kt")
     public void testSmartcast() throws Exception {

plugins/allopen/tests-gen/org/jetbrains/kotlin/allopen/FirLightTreeDiagnosticTestForAllOpenGenerated.java

@@ -30,6 +30,12 @@ public class FirLightTreeDiagnosticTestForAllOpenGenerated extends AbstractFirLi
         runTest("plugins/allopen/testData/diagnostics/kt54260.kt");
     }
 
+    @Test
+    @TestMetadata("kt60448.kt")
+    public void testKt60448() throws Exception {
+        runTest("plugins/allopen/testData/diagnostics/kt60448.kt");
+    }
+
     @Test
     @TestMetadata("smartcast.kt")
     public void testSmartcast() throws Exception {

plugins/allopen/tests-gen/org/jetbrains/kotlin/allopen/FirPsiDiagnosticTestForAllOpenGenerated.java

@@ -30,6 +30,12 @@ public class FirPsiDiagnosticTestForAllOpenGenerated extends AbstractFirPsiDiagn
         runTest("plugins/allopen/testData/diagnostics/kt54260.kt");
     }
 
+    @Test
+    @TestMetadata("kt60448.kt")
+    public void testKt60448() throws Exception {
+        runTest("plugins/allopen/testData/diagnostics/kt60448.kt");
+    }
+
     @Test
     @TestMetadata("smartcast.kt")
     public void testSmartcast() throws Exception {

plugins/fir-plugin-prototype/testData/box/expectComposableFunction.kt

@@ -1,4 +1,3 @@
-// FIR_DISABLE_LAZY_RESOLVE_CHECKS
 // LANGUAGE: +MultiPlatformProjects
 // ISSUE: KT-58539
 

plugins/fir-plugin-prototype/testData/box/metaAnnotationFromLibrary.kt

@@ -1,4 +1,3 @@
-// FIR_DISABLE_LAZY_RESOLVE_CHECKS
 // MODULE: lib
 import org.jetbrains.kotlin.fir.plugin.AllOpen
 

plugins/fir-plugin-prototype/testData/diagnostics/status/metaAnnotation.kt

@@ -1,4 +1,3 @@
-// FIR_DISABLE_LAZY_RESOLVE_CHECKS
 // FILE: first.kt
 
 @Open

plugins/fir-plugin-prototype/testData/diagnostics/status/metaAnnotationClashesWithSupertype.kt

@@ -1,4 +1,3 @@
-// FIR_DISABLE_LAZY_RESOLVE_CHECKS
 import org.jetbrains.kotlin.fir.plugin.AllOpen
 
 @AllOpen

plugins/fir-plugin-prototype/testData/diagnostics/supertypes/metaAnnotationOrder.kt

@@ -1,4 +1,3 @@
-// FIR_DISABLE_LAZY_RESOLVE_CHECKS
 // FILE: main.kt
 package foo
 

plugins/kotlinx-serialization/testData/diagnostics/repeatableSerialInfo.kt

@@ -1,4 +1,3 @@
-// FIR_DISABLE_LAZY_RESOLVE_CHECKS
 // FIR_IDENTICAL
 // SKIP_TXT