[Commonizer] Minor: Improve naming of methods and types

^KT-48288

native/commonizer/src/org/jetbrains/kotlin/commonizer/core/ClassOrTypeAliasTypeCommonizer.kt

@@ -197,7 +197,7 @@ internal class ClassOrTypeAliasTypeCommonizer(
         }
 
         val commonId = types.singleDistinctValueOrNull {
-            classifiers.commonClassifierIdResolver.findCommonId(it.classifierId)
+            classifiers.commonClassifierIdResolver.resolveId(it.classifierId)
         } ?: return null
 
         val typeSubstitutionCandidates = resolveTypeSubstitutionCandidates(classifiers, commonId, types)

native/commonizer/src/org/jetbrains/kotlin/commonizer/mergedtree/CirCommonClassifierIdResolver.kt

@@ -23,7 +23,7 @@ internal fun CirCommonClassifierIdResolver(
 }
 
 interface CirCommonClassifierIdResolver {
-    fun findCommonId(id: CirEntityId): CirCommonClassifierId?
+    fun resolveId(id: CirEntityId): CirCommonClassifierId?
 }
 
 internal interface CirCommonClassifierIdResolverCache {
@@ -63,12 +63,9 @@ private class CirCommonClassifierIdResolverImpl(
     private val cache: CirCommonClassifierIdResolverCache
 ) : CirCommonClassifierIdResolver {
 
-    override fun findCommonId(id: CirEntityId): CirCommonClassifierId? {
+    override fun resolveId(id: CirEntityId): CirCommonClassifierId? {
         cache[id]?.let { return it }
-        return doFindCommonId(id)
-    }
 
-    private fun doFindCommonId(id: CirEntityId): CirCommonClassifierId? {
         val results = ArrayList<CirEntityId>()
 
         /* Set of every classifier id that once was enqueued already */

native/commonizer/src/org/jetbrains/kotlin/commonizer/mergedtree/CirTypeSignature.kt

@@ -62,9 +62,9 @@ internal sealed interface ClassifierSignatureBuildingContext {
         override fun appendSignature(signature: CirTypeSignature, classifierId: CirEntityId) = signature.add(classifierId)
     }
 
-    class TypeAliasInvariant(private val commonIdResolver: CirCommonClassifierIdResolver) : ClassifierSignatureBuildingContext {
+    class TypeAliasInvariant(private val commonClassifierIdResolver: CirCommonClassifierIdResolver) : ClassifierSignatureBuildingContext {
         override fun appendSignature(signature: CirTypeSignature, classifierId: CirEntityId) {
-            return signature.add(commonIdResolver.findCommonId(classifierId) ?: classifierId)
+            return signature.add(commonClassifierIdResolver.resolveId(classifierId) ?: classifierId)
         }
     }
 }
@@ -99,7 +99,7 @@ internal sealed interface ArgumentsSignatureBuildingContext {
     /**
      * Won't render any type arguments
      */
-    object Skip : ArgumentsSignatureBuildingContext {
+    object SkipArguments : ArgumentsSignatureBuildingContext {
         override fun appendSignature(
             signature: CirTypeSignature, context: SignatureBuildingContext, arguments: List<CirTypeProjection>
         ) = Unit
@@ -124,7 +124,6 @@ private enum class TypeSignatureElements(val stringRepresentation: String) {
     }
 }
 
-
 internal fun buildApproximationSignature(context: SignatureBuildingContext, type: CirType): CirTypeSignature {
     val signature = CirTypeSignature()
     signature.appendTypeApproximationSignature(context, type)

native/commonizer/src/org/jetbrains/kotlin/commonizer/transformer/ReApproximationCirNodeTransformer.kt

@@ -28,7 +28,7 @@ internal class ReApproximationCirNodeTransformer(
                 memberContext = member, functionOrPropertyOrConstructor = functionOrPropertyOrConstructor,
                 classifierSignatureBuildingContext = if (typeAliasInvariant) TypeAliasInvariant(classifiers.commonClassifierIdResolver)
                 else ClassifierSignatureBuildingContext.Default,
-                argumentsSignatureBuildingContext = if (skipArguments) ArgumentsSignatureBuildingContext.Skip
+                argumentsSignatureBuildingContext = if (skipArguments) ArgumentsSignatureBuildingContext.SkipArguments
                 else ArgumentsSignatureBuildingContext.Default
             )
         }

native/commonizer/tests/org/jetbrains/kotlin/commonizer/CirCommonClassifierIdResolverTest.kt

@@ -360,5 +360,5 @@ private fun createCommonClassifierIdResolver(
 }
 
 private fun CirCommonClassifierIdResolver.findCommonId(id: String): Set<String> =
-    findCommonId(CirEntityId.create(id))?.aliases.orEmpty().map { it.toQualifiedNameString() }.toSet()
+    resolveId(CirEntityId.create(id))?.aliases.orEmpty().map { it.toQualifiedNameString() }.toSet()