diff --git a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/testing/KotlinJsTest.kt b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/testing/KotlinJsTest.kt index 120fcc7f2db..9b6fc27f062 100644 --- a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/testing/KotlinJsTest.kt +++ b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/testing/KotlinJsTest.kt @@ -26,8 +26,7 @@ import org.jetbrains.kotlin.gradle.tasks.KotlinTest import java.io.File open class KotlinJsTest : KotlinTest(), RequiresNpmDependencies { - @Internal - @SkipWhenEmpty + @get:Internal internal var testFramework: KotlinJsTestFramework? = null val testFrameworkSettings: String @@ -52,7 +51,7 @@ open class KotlinJsTest : KotlinTest(), RequiresNpmDependencies { @Internal get() = listOf("./" + compilation.npmProject.main) override val requiredNpmDependencies: Collection - get() = testFramework!!.requiredNpmDependencies + @Internal get() = testFramework!!.requiredNpmDependencies fun useNodeJs(body: KotlinNodeJsTestRunner.() -> Unit) = use(KotlinNodeJsTestRunner(compilation), body) fun useNodeJs(fn: Closure<*>) { diff --git a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/webpack/KotlinWebpack.kt b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/webpack/KotlinWebpack.kt index 79ceceb83c9..2d571aecf57 100644 --- a/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/webpack/KotlinWebpack.kt +++ b/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/js/webpack/KotlinWebpack.kt @@ -45,7 +45,7 @@ open class KotlinWebpack : DefaultTask(), RequiresNpmDependencies { } val entry: File - get() = compilation.compileKotlinTask.outputFile + @InputFile get() = compilation.compileKotlinTask.outputFile open val configFile: File @OutputFile get() = compilation.npmProject.dir.resolve("webpack.config.js") @@ -78,25 +78,6 @@ open class KotlinWebpack : DefaultTask(), RequiresNpmDependencies { @Optional var devServer: KotlinWebpackConfigWriter.DevServer? = null - override val requiredNpmDependencies: Collection - get() = mutableListOf().also { - it.add(versions.webpack) - it.add(versions.webpackCli) - - if (report) { - it.add(versions.webpackBundleAnalyzer) - } - - if (sourceMaps) { - it.add(versions.sourceMapLoader) - it.add(versions.sourceMapSupport) - } - - if (devServer != null) { - it.add(versions.webpackDevServer) - } - } - private fun createRunner() = KotlinWebpackRunner( compilation.npmProject, configFile, @@ -114,6 +95,25 @@ open class KotlinWebpack : DefaultTask(), RequiresNpmDependencies { ) ) + override val requiredNpmDependencies: Collection + @Internal get() = mutableListOf().also { + it.add(versions.webpack) + it.add(versions.webpackCli) + + if (report) { + it.add(versions.webpackBundleAnalyzer) + } + + if (sourceMaps) { + it.add(versions.sourceMapLoader) + it.add(versions.sourceMapSupport) + } + + if (devServer != null) { + it.add(versions.webpackDevServer) + } + } + @TaskAction fun execute() { NpmResolver.checkRequiredDependencies(project, this)