azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

KT-2240 Wrong overload resolution ambiguity when object literal is involved

Browse Source 
#KT-2240 fixed
This commit is contained in:
Svetlana Isakova
2012-06-09 17:40:22 +04:00
parent 198c7c1bd2
commit 74f4fde180
2 changed files with 28 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/frontend/src/org/jetbrains/jet/lang/resolve/calls/TaskPrioritizer.java
+15 -13
View File
@@ -184,7 +184,7 @@ import static org.jetbrains.jet.lang.resolve.scopes.receivers.ReceiverDescriptor
} }
} }
public static <D extends CallableDescriptor> Collection<ResolutionCandidate<D>> convertWithImpliedThis(JetScope scope, Iterable<ReceiverDescriptor> receiverParameters, Collection<? extends D> descriptors) { public static <D extends CallableDescriptor> Collection<ResolutionCandidate<D>> convertWithImpliedThis(JetScope scope, Collection<ReceiverDescriptor> receiverParameters, Collection<? extends D> descriptors) {
Collection<ResolutionCandidate<D>> result = Lists.newArrayList(); Collection<ResolutionCandidate<D>> result = Lists.newArrayList();
for (ReceiverDescriptor receiverParameter : receiverParameters) { for (ReceiverDescriptor receiverParameter : receiverParameters) {
for (D descriptor : descriptors) { for (D descriptor : descriptors) {
@@ -197,18 +197,20 @@ import static org.jetbrains.jet.lang.resolve.scopes.receivers.ReceiverDescriptor
} }
} }
} }
for (D descriptor : descriptors) { if (receiverParameters.size() == 1 && !receiverParameters.iterator().next().exists()) {
if (descriptor.getExpectedThisObject().exists()) { for (D descriptor : descriptors) {
DeclarationDescriptor containingDeclaration = descriptor.getContainingDeclaration(); if (descriptor.getExpectedThisObject().exists() && !descriptor.getReceiverParameter().exists()) {
if (descriptor instanceof ConstructorDescriptor) { DeclarationDescriptor containingDeclaration = descriptor.getContainingDeclaration();
assert containingDeclaration != null; if (descriptor instanceof ConstructorDescriptor) {
containingDeclaration = containingDeclaration.getContainingDeclaration(); assert containingDeclaration != null;
} containingDeclaration = containingDeclaration.getContainingDeclaration();
if (containingDeclaration instanceof ClassDescriptor && ((ClassDescriptor) containingDeclaration).getKind() == ClassKind.OBJECT) { }
ResolutionCandidate<D> candidate = ResolutionCandidate.create(descriptor); if (containingDeclaration instanceof ClassDescriptor && DescriptorUtils.isClassObject(containingDeclaration)) {
candidate.setThisObject(new ClassReceiver((ClassDescriptor) containingDeclaration)); ResolutionCandidate<D> candidate = ResolutionCandidate.create(descriptor);
candidate.setExplicitReceiverKind(ExplicitReceiverKind.NO_EXPLICIT_RECEIVER); candidate.setThisObject(new ClassReceiver((ClassDescriptor) containingDeclaration));
result.add(candidate); candidate.setExplicitReceiverKind(ExplicitReceiverKind.NO_EXPLICIT_RECEIVER);
result.add(candidate);
}
} }
} }
} }
compiler/testData/diagnostics/tests/objects/kt2240.jet
+13
View File
@@ -0,0 +1,13 @@
package a
//KT-2240 Wrong overload resolution ambiguity when object literal is involved
class A {}
fun A.foo<T>(<!UNUSED_PARAMETER!>f<!> : T) {}
val o = object {
fun foo<T>(f: T) {
A().foo(f) // Ambiguity here!
}
}