[repo] Enable warnings as errors for Gradle Kotlin scripts

buildSrc/gradle.properties

@@ -1,4 +1,5 @@
 org.gradle.jvmargs=-Duser.country=US -Dfile.encoding=UTF-8
+org.gradle.kotlin.dsl.allWarningsAsErrors=true
 
 cacheRedirectorEnabled=true
 

gradle.properties

@@ -7,6 +7,7 @@ kotlin.incremental.useClasspathSnapshot=true
 
 org.gradle.parallel=true
 org.gradle.caching=true
+org.gradle.kotlin.dsl.allWarningsAsErrors=true
 
 # Please keep it in sync with buildSrc gradle.properties.
 # It's currently needed for proper configuration cache work, the reason will be investigated later

js/js.tests/build.gradle.kts

@@ -1,4 +1,5 @@
 import com.github.gradle.node.npm.task.NpmTask
+import com.github.gradle.node.variant.computeNodeExec
 import org.jetbrains.kotlin.gradle.plugin.KotlinPlatformType
 import org.jetbrains.kotlin.gradle.plugin.mpp.KotlinUsages
 import org.jetbrains.kotlin.ideaExt.idea
@@ -214,11 +215,7 @@ val generateTypeScriptJsExportOnFileTests by parallel(
 fun Test.setupNodeJs() {
     systemProperty("javascript.engine.path.NodeJs", com.github.gradle.node.variant.VariantComputer()
         .let { variantComputer ->
-            variantComputer
+            computeNodeExec(node, variantComputer.computeNodeBinDir(node.computedNodeDir)).get()
-                .computeNodeDir(node)
-                .let { variantComputer.computeNodeBinDir(it) }
-                .let { variantComputer.computeNodeExec(node, it) }
-                .get()
         }
     )
 }

libraries/kotlin.test/js-ir/it/build.gradle.kts

@@ -31,9 +31,9 @@ val ignoreTestFailures by extra(project.kotlinBuildProperties.ignoreTestFailures
 kotlin {
     js(IR) {
         nodejs {
-            testTask {
+            testTask(Action {
                 enabled = false
-            }
+            })
         }
     }
 

libraries/stdlib/js-ir/build.gradle.kts

@@ -7,11 +7,11 @@ plugins {
 kotlin {
     js(IR) {
         nodejs {
-            testTask {
+            testTask(Action {
                 useMocha {
                     timeout = "10s"
                 }
-            }
+            })
         }
     }
 }

repo/gradle-settings-conventions/gradle.properties

@@ -2,4 +2,6 @@ kotlin.build.gradlePlugin.version=0.0.39
 kotlin.options.suppressFreeCompilerArgsModificationWarning=true
 cacheRedirectorEnabled=true
 # Should be in sync with ":kotlin-daemon-config" project convention script configuration
-kotlin.daemon.jvmargs=-Xmx3g
+kotlin.daemon.jvmargs=-Xmx3g
+
+org.gradle.kotlin.dsl.allWarningsAsErrors=true