[FIR] Fix translation of invokes & add return expressions for lambdas

* fixed NoSuchMethod caused by mismatched signatures of the "invoke" method generated for lambda arguments
* added test cases in invoke.kt for KFunction and anonymous functions
* added a transformer to wrap the last expression in the bodies of lambdas with return

compiler/testData/codegen/box/binaryOp/divisionByZero.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 // IGNORE_BACKEND: JS_IR
 // IGNORE_BACKEND: JS
 // reason - no error from division by zero in JS

compiler/testData/codegen/box/callableReference/function/newArray.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 private fun <T> upcast(value: T): T = value
 
 fun box(): String {

compiler/testData/codegen/box/callableReference/function/overloadedFun.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 fun foo(): String = "foo1"
 fun foo(i: Int): String = "foo2"
 

compiler/testData/codegen/box/casts/asForConstants.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 // IGNORE_BACKEND: JS_IR
 // TODO: muted automatically, investigate should it be ran for JS or not
 // IGNORE_BACKEND: JS

compiler/testData/codegen/box/casts/lambdaToUnitCast.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 val foo: () -> Unit = {}
 
 fun box(): String {

compiler/testData/codegen/box/classes/kt1439.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 class MyClass(var fnc : () -> String) {
 
     fun test(): String {

compiler/testData/codegen/box/classes/kt1721.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 class T(val f : () -> Any?) {
     fun call() : Any? = f()
 }

compiler/testData/codegen/box/classes/kt1726.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 class Foo(
         var state : Int,
         val f : (Int) -> Int){

compiler/testData/codegen/box/closures/captureInSuperConstructorCall/localCapturedInLambdaInLocalClass.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 open class Base(val fn: () -> String)
 
 fun box(): String {

compiler/testData/codegen/box/closures/captureInSuperConstructorCall/referenceToCapturedVariablesInMultipleLambdas.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 open class Base(val fn1: () -> String, val fn2: () -> String)
 
 fun box(): String {

compiler/testData/codegen/box/closures/closureWithParameter.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 fun box() : String {
     return apply( "OK", {arg: String -> arg } )
 }

compiler/testData/codegen/box/closures/closureWithParameterAndBoxing.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 fun box() : String {
     return if (apply( 5, {arg: Int -> arg + 13 } ) == 18) "OK" else "fail"
 }

compiler/testData/codegen/box/closures/doubleEnclosedLocalVariable.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 fun box() : String {
     val cl = 39
     return if (sum(200, { val ff = {cl}; ff() }) == 239) "OK" else "FAIL"

compiler/testData/codegen/box/closures/enclosingLocalVariable.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 fun box() : String {
     val cl = 39
     return if (sum(200, { val m = { val r = { cl };  r() }; m() }) == 239) "OK" else "FAIL"

compiler/testData/codegen/box/closures/kt4137.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 open class A(val s: Int) {
 
 }

compiler/testData/codegen/box/closures/localClassLambdaClosure.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 fun box(): String {
     val o = "O"
     val ok_L = {o + "K"}

compiler/testData/codegen/box/closures/localReturn.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 fun box(): String {
     val a = 1
     val explicitlyReturned = run1 f@{

compiler/testData/codegen/box/closures/localReturnWithAutolabel.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 fun box(): String {
     val a = 1
     val explicitlyReturned = run1 {

compiler/testData/codegen/box/closures/simplestClosure.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 fun box() : String {
     return invoker( {"OK"} )
 }

compiler/testData/codegen/box/closures/simplestClosureAndBoxing.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 fun box() : String {
     return if (int_invoker( { 7 } ) == 7) "OK" else "fail"
 }

compiler/testData/codegen/box/closures/underscoreParameters.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 fun foo(block: (String, String, String) -> String): String = block("O", "fail", "K")
 
 fun box() = foo { x, _, y -> x + y }

compiler/testData/codegen/box/constants/divisionByZero.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 // IGNORE_BACKEND: JS_IR
 // IGNORE_BACKEND: JS
 // reason - no error from division by zero in JS

compiler/testData/codegen/box/constants/privateConst.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 private const val z = "OK";
 
 fun box(): String {

compiler/testData/codegen/box/controlStructures/kt17590.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 fun zap(s: String): String? = s
 
 inline fun tryZap(s: String, fn: (String) -> String): String {

compiler/testData/codegen/box/controlStructures/tryCatchInExpressions/deadTryCatch.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 inline fun catchAll(x: String, block: () -> Unit): String {
     try {
         block()

compiler/testData/codegen/box/controlStructures/tryCatchInExpressions/inlineTryCatch.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 inline fun <T> tryOrElse(f1: () -> T, f2: () -> T): T {
     try {
         return f1()

compiler/testData/codegen/box/controlStructures/tryCatchInExpressions/inlineTryExpr.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 inline fun <T> tryOrElse(f1: () -> T, f2: () -> T): T =
         try { f1() } catch (e: Exception) { f2() }
 

compiler/testData/codegen/box/controlStructures/tryCatchInExpressions/inlineTryFinally.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 inline fun <T> tryAndThen(f1: () -> Unit, f2: () -> Unit, f3: () -> T): T {
     try {
         f1()

compiler/testData/codegen/box/controlStructures/tryCatchInExpressions/kt17572.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 fun zap(s: String) = s
 
 inline fun tryZap(string: String, fn: (String) -> String) =

compiler/testData/codegen/box/controlStructures/tryCatchInExpressions/kt17572_2.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 fun zap(s: String) = s
 
 inline fun tryZap(s1: String, s2: String, fn: (String, String) -> String) =

compiler/testData/codegen/box/controlStructures/tryCatchInExpressions/kt17572_nested.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 fun zap(s: String) = s
 
 inline fun tryZap(string: String, fn: (String) -> String) =

compiler/testData/codegen/box/controlStructures/tryCatchInExpressions/kt17573.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 fun zap(s: String) = s
 
 inline fun tryZap(string: String, fn: (String) -> String) =

compiler/testData/codegen/box/controlStructures/tryCatchInExpressions/kt17573_nested.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 fun zap(s: String) = s
 
 inline fun tryZap1(string: String, fn: (String) -> String) =

compiler/testData/codegen/box/controlStructures/tryCatchInExpressions/splitTry.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 inline fun test(s: () -> Int): Int =
         try {
             val i = s()

compiler/testData/codegen/box/delegatedProperty/provideDelegate/evaluationOrder.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 // WITH_RUNTIME
 
 import kotlin.test.*

compiler/testData/codegen/box/destructuringDeclInLambdaParam/inline.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 data class A(val x: String, val y: String)
 
 inline fun foo(a: A, block: (A) -> String): String = block(a)

compiler/testData/codegen/box/destructuringDeclInLambdaParam/otherParameters.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 data class A(val x: String, val y: String)
 
 fun foo(a: A, block: (Int, A, String) -> String): String = block(1, a, "#")

compiler/testData/codegen/box/destructuringDeclInLambdaParam/simple.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 data class A(val x: String, val y: String)
 
 fun foo(a: A, block: (A) -> String): String = block(a)

compiler/testData/codegen/box/diagnostics/functions/inference/kt6176.kt

@@ -1,5 +1,4 @@
 // !DIAGNOSTICS: -DEBUG_INFO_SMARTCAST
-// IGNORE_BACKEND_FIR: JVM_IR
 
 fun <R> foo(f: () -> R): R = f()
 

compiler/testData/codegen/box/extensionFunctions/kt1249.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 //KT-1249 IllegalStateException invoking function property
 class TestClass(val body : () -> Unit) : Any() {
     fun run() {

compiler/testData/codegen/box/extensionFunctions/shared.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 infix fun <T> T.mustBe(t : T) {
     assert("$this must be $t") {this == t}
 }

compiler/testData/codegen/box/functions/bigArity/invokeLambda.kt

@@ -1,5 +1,4 @@
 // !LANGUAGE: +FunctionTypesWithBigArity
-// IGNORE_BACKEND_FIR: JVM_IR
 
 class A(val value: Int)
 

compiler/testData/codegen/box/functions/functionExpression/underscoreParameters.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 fun foo(block: (String, String, String) -> String): String = block("O", "fail", "K")
 
 fun box() = foo(fun(x: String, _: String, y: String) = x + y)

compiler/testData/codegen/box/functions/invoke/invoke.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 package invoke
 
 fun test1(predicate: (Int) -> Int, i: Int) = predicate(i)
@@ -24,6 +23,9 @@ fun box() : String {
     if (test2({ it }, 2) != 2) return "fail 2"
     if (test3(Method(), 3) != 3) return "fail 3"
     if (test4(Method(), 4) != 4) return "fail 4"
-    if (test5(Method2(), "s") != "s") return "fail5"
+    if (test5(Method2(), "s") != "s") return "fail 5"
+    if (test1(Int::dec, 1) != 0) return "fail 6"
+    if (test2(Int::dec, 1) != 0) return "fail 7"
+    if (test1(fun(x: Int) = x - 1, 1) != 0) return "fail 8"
     return "OK"
 }

compiler/testData/codegen/box/functions/invoke/invokeOnExprByConvention.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 //KT-3217 Invoke convention after function invocation doesn't work
 //KT-2728 Can't compile A()()
 

compiler/testData/codegen/box/functions/invoke/kt3189.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 //KT-3189 Function invoke is called with no reason
 
 fun box(): String {

compiler/testData/codegen/box/functions/invoke/kt3297.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 //KT-3297 Calling the wrong function inside an extension method to the Function0 class
 
 infix fun <R> Function0<R>.or(alt: () -> R): R {

compiler/testData/codegen/box/functions/kt1739.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 // IGNORE_BACKEND: JS_IR
 // TODO: muted automatically, investigate should it be ran for JS or not
 // IGNORE_BACKEND: JS, NATIVE

compiler/testData/codegen/box/functions/nothisnoclosure.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 fun foo(x: Int) {}
 
 fun loop(times : Int) {

compiler/testData/codegen/box/inference/lastExpressionOfLambdaWithNothingConstraint.kt

@@ -1,5 +1,4 @@
 // !LANGUAGE: +NewInference
-// IGNORE_BACKEND_FIR: JVM_IR
 // WITH_RUNTIME
 
 inline fun <T> foo(f: () -> T): String {

compiler/testData/codegen/box/javaInterop/lambdaInstanceOf.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 // TARGET_BACKEND: JVM
 
 // WITH_RUNTIME

compiler/testData/codegen/box/jvmField/capturePackageFields.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 // TARGET_BACKEND: JVM
 
 // WITH_RUNTIME

compiler/testData/codegen/box/jvmPackageName/rootPackage.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 // TARGET_BACKEND: JVM
 // WITH_RUNTIME
 

compiler/testData/codegen/box/jvmPackageName/simple.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 // TARGET_BACKEND: JVM
 // WITH_RUNTIME
 

compiler/testData/codegen/box/jvmPackageName/withJvmName.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 // TARGET_BACKEND: JVM
 // WITH_RUNTIME
 

compiler/testData/codegen/box/localClasses/kt2873.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 fun foo() : String {
     val u = {
         class B(val data : String)

compiler/testData/codegen/box/multiDecl/ValCapturedInFunctionLiteral.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 class A {
     operator fun component1() = 1
     operator fun component2() = 2

compiler/testData/codegen/box/multiDecl/forRange/MultiDeclForValCaptured.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 class Range(val from : C, val to: C) {
     operator fun iterator() = It(from, to)
 }

compiler/testData/codegen/box/multiDecl/forRange/explicitRangeTo/MultiDeclForValCaptured.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 class Range(val from : C, val to: C) {
     operator fun iterator() = It(from, to)
 }

compiler/testData/codegen/box/multiDecl/forRange/explicitRangeTo/int/MultiDeclForComponentExtensionsValCaptured.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 operator fun Int.component1() = this + 1
 operator fun Int.component2() = this + 2
 

compiler/testData/codegen/box/multiDecl/forRange/explicitRangeTo/long/MultiDeclForComponentExtensionsValCaptured.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 operator fun Long.component1() = this + 1
 operator fun Long.component2() = this + 2
 

compiler/testData/codegen/box/multiDecl/forRange/explicitRangeToWithDot/MultiDeclForValCaptured.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 class Range(val from : C, val to: C) {
     operator fun iterator() = It(from, to)
 }

compiler/testData/codegen/box/multiDecl/forRange/explicitRangeToWithDot/int/MultiDeclForComponentExtensionsValCaptured.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 operator fun Int.component1() = this + 1
 operator fun Int.component2() = this + 2
 

compiler/testData/codegen/box/multiDecl/forRange/explicitRangeToWithDot/long/MultiDeclForComponentExtensionsValCaptured.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 operator fun Long.component1() = this + 1
 operator fun Long.component2() = this + 2
 

compiler/testData/codegen/box/multiDecl/forRange/int/MultiDeclForComponentExtensionsValCaptured.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 operator fun Int.component1() = this + 1
 operator fun Int.component2() = this + 2
 

compiler/testData/codegen/box/multiDecl/forRange/long/MultiDeclForComponentExtensionsValCaptured.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 operator fun Long.component1() = this + 1
 operator fun Long.component2() = this + 2
 

compiler/testData/codegen/box/multifileClasses/inlineMultifileClassMemberFromOtherPackage.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 // TARGET_BACKEND: JVM
 // WITH_RUNTIME
 // FILE: box.kt

compiler/testData/codegen/box/multifileClasses/optimized/callInInlineLambda.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 // TARGET_BACKEND: JVM
 // IGNORE_LIGHT_ANALYSIS
 // WITH_RUNTIME

compiler/testData/codegen/box/nullCheckOptimization/kt22410.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 fun box(): String {
     defineFunc<String>()
 

compiler/testData/codegen/box/objects/selfReferenceToObjectInLambdaInSuperConstructorCall.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 abstract class Base(val fn: () -> String)
 
 object Test : Base({ Test.ok() }) {

compiler/testData/codegen/box/package/privateTopLevelPropAndVarInInner.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 private var x = "O"
 private fun f() = "K"
 

compiler/testData/codegen/box/primitiveTypes/equalityWithObject/boxedEqPrimitiveEvaluationOrder.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 var order: String = ""
 
 fun a(i: Int): Int? {

compiler/testData/codegen/box/properties/fieldInsideLambda.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 val my: String = "O"
     get() = { field }() + "K"
 

compiler/testData/codegen/box/properties/kt1892.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 val Int.ext: () -> Int get() = { 5 }
 val Long.ext: Long get() = 4.ext().toLong()  //(c.kt:4)
 val y: Long get() = 10L.ext

compiler/testData/codegen/box/properties/lateinit/local/capturedLocalLateinit.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 fun runNoInline(f: () -> Unit) = f()
 
 fun box(): String {

compiler/testData/codegen/box/smartCasts/lambdaArgumentWithoutType.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 // IGNORE_BACKEND: JS_IR
 // TODO: muted automatically, investigate should it be ran for JS or not
 // IGNORE_BACKEND: JS

compiler/testData/codegen/box/topLevelPrivate/syntheticAccessor.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 package test
 
 private val prop = "O"

compiler/testData/codegen/box/topLevelPrivate/syntheticAccessorInMultiFile.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 // TARGET_BACKEND: JVM
 // WITH_RUNTIME
 

compiler/testData/codegen/box/unit/closureReturnsNullableUnit.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND_FIR: JVM_IR
 fun isNull(x: Unit?) = x == null
 
 fun box(): String {

compiler/testData/codegen/box/when/whenSubjectVariable/captureSubjectVariable.kt

@@ -1,5 +1,4 @@
 // !LANGUAGE: +VariableDeclarationInWhenSubject
-// IGNORE_BACKEND_FIR: JVM_IR
 
 fun box(): String {
     var y: String = "OK"